[fix](nereids)alter sql block rule lost sql pattern info #53559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34239 ms |
TPC-DS: Total hot run time: 191472 ms |
ClickBench: Total hot run time: 32.66 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34184 ms |
TPC-DS: Total hot run time: 191420 ms |
ClickBench: Total hot run time: 33.49 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
starocean999
force-pushed
the
master_0331
branch
from
a13df4c to
09b0ce4
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33865 ms |
TPC-DS: Total hot run time: 186723 ms |
ClickBench: Total hot run time: 32.4 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
morrySnow
reviewed
Jul 30, 2025
| CREATE SQL_BLOCK_RULE rule_drop | ||
| PROPERTIES( | ||
| "sql"="select \\* from order_analysis", |
Contributor
There was a problem hiding this comment.
not get the purpose of this case
Contributor
Author
There was a problem hiding this comment.
without the change, sqlPattern will be 'NULL', so 'select NULL' would hit this sql block rule
morrySnow
approved these changes
Jul 30, 2025
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
zddr
approved these changes
Jul 30, 2025
Contributor
|
run check_coverage |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 30, 2025
CREATE SQL_BLOCK_RULE rule_drop
PROPERTIES(
"sql"="select \\* from order_analysis",
"global"="true",
"enable"="true");
ALTER SQL_BLOCK_RULE rule_drop PROPERTIES("global"="true");
when ALTER SQL_BLOCK_RULE, we use new properties in the command and keep
other properties unchanged, but we need call setSqlPattern to fill the
new sql pattern or it will be 'NULL' which is a wrong pattern
github-actions bot
pushed a commit
that referenced
this pull request
Jul 30, 2025
CREATE SQL_BLOCK_RULE rule_drop
PROPERTIES(
"sql"="select \\* from order_analysis",
"global"="true",
"enable"="true");
ALTER SQL_BLOCK_RULE rule_drop PROPERTIES("global"="true");
when ALTER SQL_BLOCK_RULE, we use new properties in the command and keep
other properties unchanged, but we need call setSqlPattern to fill the
new sql pattern or it will be 'NULL' which is a wrong pattern
github-actions bot
pushed a commit
that referenced
this pull request
Jul 30, 2025
CREATE SQL_BLOCK_RULE rule_drop
PROPERTIES(
"sql"="select \\* from order_analysis",
"global"="true",
"enable"="true");
ALTER SQL_BLOCK_RULE rule_drop PROPERTIES("global"="true");
when ALTER SQL_BLOCK_RULE, we use new properties in the command and keep
other properties unchanged, but we need call setSqlPattern to fill the
new sql pattern or it will be 'NULL' which is a wrong pattern
morrySnow
pushed a commit
that referenced
this pull request
Jul 31, 2025
dataroaring
pushed a commit
that referenced
this pull request
Aug 12, 2025
yiguolei
pushed a commit
to yiguolei/incubator-doris
that referenced
this pull request
Dec 19, 2025
## Proposed changes pick from apache#53559 <!--Describe your changes.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when ALTER SQL_BLOCK_RULE, we use new properties in the command and keep other properties unchanged, but we need call setSqlPattern to fill the new sql pattern or it will be 'NULL' which is a wrong pattern
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)