Skip to content

[chore](load) optimize show create load error message #53694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Jul 22, 2025
Merged

[chore](load) optimize show create load error message #53694

dataroaring merged 1 commit into from
Jul 22, 2025

Conversation

@sollhui
Copy link
Contributor

@sollhui sollhui commented Jul 22, 2025

What problem does this PR solve?

If show create load with not exist label, the error message is Database does not exist, it make users confused and not correct, and it should be Label does not exist

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@sollhui sollhui marked this pull request as ready for review July 22, 2025 06:26
@sollhui
Copy link
Contributor Author

sollhui commented Jul 22, 2025

run buildall

dataroaring
dataroaring previously approved these changes Jul 22, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 22, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2025

PR approved by anyone and no changes requested.

liaoxin01
liaoxin01 previously approved these changes Jul 22, 2025
View reviewed changes
Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doris-robot
Copy link

doris-robot commented Jul 22, 2025

TPC-H: Total hot run time: 34193 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 565dc5b0df678d9658f929b30267e21a2ecbc410, data reload: false

------ Round 1 ----------------------------------
q1	17588	5358	5065	5065
q2	1924	289	187	187
q3	10295	1309	745	745
q4	10207	1024	529	529
q5	7641	2469	2297	2297
q6	182	158	130	130
q7	900	725	594	594
q8	9301	1326	1065	1065
q9	7228	5177	5170	5170
q10	6904	2378	2003	2003
q11	472	287	280	280
q12	347	351	213	213
q13	17760	3674	3141	3141
q14	224	243	218	218
q15	545	489	470	470
q16	422	443	370	370
q17	614	868	376	376
q18	7642	7201	7182	7182
q19	1281	957	580	580
q20	354	348	223	223
q21	4093	2566	2392	2392
q22	1082	1031	963	963
Total cold run time: 107006 ms
Total hot run time: 34193 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5179	5116	5184	5116
q2	239	333	219	219
q3	2268	2672	2268	2268
q4	1335	1806	1324	1324
q5	4246	4502	4567	4502
q6	237	183	130	130
q7	2037	1942	1799	1799
q8	2636	2581	2560	2560
q9	7439	7326	7275	7275
q10	3101	3262	2886	2886
q11	568	502	476	476
q12	723	819	672	672
q13	3607	3972	3404	3404
q14	289	307	273	273
q15	522	475	455	455
q16	462	497	439	439
q17	1195	1577	1374	1374
q18	8133	7879	7452	7452
q19	793	792	839	792
q20	2037	1962	1834	1834
q21	4806	4360	4347	4347
q22	1079	1032	1014	1014
Total cold run time: 52931 ms
Total hot run time: 50611 ms

@doris-robot
Copy link

doris-robot commented Jul 22, 2025

TPC-DS: Total hot run time: 187295 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 565dc5b0df678d9658f929b30267e21a2ecbc410, data reload: false

query1	984	381	401	381
query2	6548	1782	1733	1733
query3	6743	219	219	219
query4	26980	23407	23952	23407
query5	4833	619	485	485
query6	306	221	228	221
query7	4621	510	291	291
query8	274	222	231	222
query9	8606	2809	2809	2809
query10	477	349	286	286
query11	15989	15102	14778	14778
query12	160	111	111	111
query13	1645	526	388	388
query14	9113	5873	5917	5873
query15	218	186	161	161
query16	7236	666	460	460
query17	1142	703	571	571
query18	1988	409	317	317
query19	199	185	162	162
query20	126	119	121	119
query21	215	121	109	109
query22	4238	4152	4118	4118
query23	33576	32984	32920	32920
query24	8155	2389	2394	2389
query25	582	504	442	442
query26	733	282	166	166
query27	2681	519	353	353
query28	4312	2202	2154	2154
query29	746	612	487	487
query30	294	221	191	191
query31	913	843	775	775
query32	92	87	85	85
query33	578	389	349	349
query34	787	838	534	534
query35	847	824	742	742
query36	966	1026	942	942
query37	124	103	89	89
query38	4125	4150	4109	4109
query39	1508	1428	1388	1388
query40	223	129	114	114
query41	60	57	55	55
query42	123	112	114	112
query43	501	512	476	476
query44	1373	837	841	837
query45	177	175	171	171
query46	841	1004	632	632
query47	1736	1867	1751	1751
query48	385	439	312	312
query49	681	479	391	391
query50	636	686	415	415
query51	5544	5711	5186	5186
query52	124	116	102	102
query53	237	257	186	186
query54	597	582	531	531
query55	93	91	91	91
query56	327	313	307	307
query57	1189	1177	1138	1138
query58	285	284	278	278
query59	2577	2678	2565	2565
query60	344	336	327	327
query61	133	124	127	124
query62	826	737	663	663
query63	227	195	198	195
query64	3236	1033	673	673
query65	4273	4152	4223	4152
query66	1042	429	383	383
query67	16102	15594	15350	15350
query68	8491	901	569	569
query69	485	323	283	283
query70	1268	1205	1133	1133
query71	469	330	316	316
query72	5343	4715	4741	4715
query73	773	583	350	350
query74	8956	9037	8798	8798
query75	3883	3084	2650	2650
query76	3611	1190	737	737
query77	783	394	314	314
query78	9970	10172	9324	9324
query79	2410	810	596	596
query80	627	531	471	471
query81	484	252	224	224
query82	419	147	105	105
query83	276	259	238	238
query84	286	113	82	82
query85	797	377	344	344
query86	346	318	301	301
query87	4374	4368	4313	4313
query88	2982	2245	2217	2217
query89	385	321	284	284
query90	1918	226	216	216
query91	146	152	124	124
query92	85	70	67	67
query93	1108	964	623	623
query94	686	398	345	345
query95	403	330	313	313
query96	481	590	277	277
query97	2656	2789	2605	2605
query98	231	221	208	208
query99	1448	1391	1300	1300
Total cold run time: 274132 ms
Total hot run time: 187295 ms

@doris-robot
Copy link

doris-robot commented Jul 22, 2025

ClickBench: Total hot run time: 32.31 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 565dc5b0df678d9658f929b30267e21a2ecbc410, data reload: false

query1	0.04	0.03	0.04
query2	0.08	0.04	0.04
query3	0.25	0.08	0.07
query4	1.62	0.10	0.10
query5	0.43	0.40	0.42
query6	1.15	0.66	0.68
query7	0.02	0.02	0.01
query8	0.05	0.03	0.04
query9	0.59	0.52	0.52
query10	0.58	0.58	0.59
query11	0.16	0.11	0.11
query12	0.15	0.11	0.11
query13	0.62	0.60	0.61
query14	0.81	0.82	0.85
query15	0.89	0.88	0.85
query16	0.38	0.39	0.41
query17	1.03	1.01	1.03
query18	0.21	0.20	0.20
query19	1.94	1.80	1.81
query20	0.01	0.02	0.01
query21	15.42	0.89	0.54
query22	0.75	1.19	0.75
query23	14.85	1.39	0.64
query24	5.88	1.77	0.59
query25	0.50	0.25	0.10
query26	0.54	0.18	0.14
query27	0.06	0.05	0.06
query28	10.11	0.93	0.43
query29	12.53	3.89	3.24
query30	3.09	3.03	3.04
query31	2.83	0.59	0.39
query32	3.23	0.54	0.48
query33	3.15	3.05	3.10
query34	16.04	5.46	4.83
query35	4.90	4.86	4.94
query36	0.68	0.50	0.50
query37	0.09	0.07	0.07
query38	0.05	0.04	0.04
query39	0.03	0.03	0.03
query40	0.17	0.14	0.15
query41	0.09	0.02	0.03
query42	0.03	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.07 s
Total hot run time: 32.31 s

@sollhui sollhui dismissed stale reviews from liaoxin01 and dataroaring via 90d13c3 July 22, 2025 08:22
@sollhui sollhui force-pushed the show_create_load_error_msg branch from 565dc5b to 90d13c3 Compare July 22, 2025 08:22
@sollhui
Copy link
Contributor Author

sollhui commented Jul 22, 2025

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jul 22, 2025
@doris-robot
Copy link

doris-robot commented Jul 22, 2025

TPC-H: Total hot run time: 34190 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 90d13c31e0057b7aae372629323f924f388cebf9, data reload: false

------ Round 1 ----------------------------------
q1	17626	5229	5043	5043
q2	1939	275	175	175
q3	10307	1220	694	694
q4	10211	1017	524	524
q5	7628	2469	2305	2305
q6	199	162	126	126
q7	878	744	596	596
q8	9303	1241	1039	1039
q9	6839	5087	5144	5087
q10	6868	2383	1987	1987
q11	467	282	269	269
q12	336	343	214	214
q13	17775	3630	3076	3076
q14	227	241	217	217
q15	548	475	471	471
q16	417	421	364	364
q17	592	861	355	355
q18	7904	7227	7031	7031
q19	1366	962	556	556
q20	332	331	218	218
q21	3659	3147	2894	2894
q22	1065	1022	949	949
Total cold run time: 106486 ms
Total hot run time: 34190 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5164	5083	5069	5069
q2	247	319	221	221
q3	2169	2611	2263	2263
q4	1335	1772	1324	1324
q5	4170	4530	4480	4480
q6	201	159	123	123
q7	2024	2020	1888	1888
q8	2660	2556	2582	2556
q9	7436	7380	7410	7380
q10	3141	3323	2944	2944
q11	624	558	488	488
q12	692	824	650	650
q13	3994	4101	3533	3533
q14	304	308	285	285
q15	564	490	478	478
q16	457	506	445	445
q17	1248	1565	1415	1415
q18	8184	8051	7752	7752
q19	760	813	904	813
q20	2005	2117	1943	1943
q21	4746	4318	4406	4318
q22	1095	1034	972	972
Total cold run time: 53220 ms
Total hot run time: 51340 ms

@doris-robot
Copy link

doris-robot commented Jul 22, 2025

TPC-DS: Total hot run time: 187564 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 90d13c31e0057b7aae372629323f924f388cebf9, data reload: false

query1	1005	405	395	395
query2	6519	1674	1691	1674
query3	6740	227	224	224
query4	27028	23746	23100	23100
query5	4372	630	482	482
query6	306	224	205	205
query7	4629	502	289	289
query8	268	234	232	232
query9	8613	2847	2829	2829
query10	486	341	270	270
query11	16011	15013	14935	14935
query12	169	115	114	114
query13	1657	537	412	412
query14	9427	6109	6002	6002
query15	215	184	172	172
query16	7507	666	436	436
query17	1209	722	582	582
query18	2019	425	320	320
query19	197	203	171	171
query20	129	119	115	115
query21	216	123	175	123
query22	4112	4194	4028	4028
query23	33830	33091	32939	32939
query24	8104	2359	2420	2359
query25	530	495	401	401
query26	777	273	158	158
query27	2685	502	340	340
query28	4352	2163	2110	2110
query29	642	570	437	437
query30	286	220	186	186
query31	904	858	769	769
query32	85	76	70	70
query33	580	380	333	333
query34	780	846	517	517
query35	779	834	740	740
query36	981	1010	941	941
query37	118	101	84	84
query38	4197	4134	4049	4049
query39	1487	1434	1412	1412
query40	220	121	114	114
query41	57	58	53	53
query42	117	106	105	105
query43	516	503	473	473
query44	1322	834	849	834
query45	178	169	166	166
query46	842	999	629	629
query47	1768	1812	1743	1743
query48	372	427	309	309
query49	676	487	405	405
query50	621	713	396	396
query51	5518	5678	5523	5523
query52	115	109	106	106
query53	231	254	183	183
query54	579	593	520	520
query55	91	86	89	86
query56	313	304	316	304
query57	1152	1203	1144	1144
query58	281	295	270	270
query59	2493	2567	2495	2495
query60	363	339	326	326
query61	126	122	127	122
query62	764	741	686	686
query63	224	192	187	187
query64	3303	1004	667	667
query65	4299	4201	4224	4201
query66	937	420	409	409
query67	15719	15608	15475	15475
query68	8179	892	550	550
query69	478	318	278	278
query70	1244	1179	1126	1126
query71	477	336	320	320
query72	5745	4815	4901	4815
query73	770	669	351	351
query74	9137	9084	8991	8991
query75	3827	3092	2574	2574
query76	3613	1187	730	730
query77	799	392	323	323
query78	9899	10199	9315	9315
query79	1918	827	577	577
query80	625	531	475	475
query81	496	254	223	223
query82	429	138	113	113
query83	284	261	241	241
query84	295	102	85	85
query85	766	360	423	360
query86	341	303	293	293
query87	4399	4472	4319	4319
query88	2793	2244	2225	2225
query89	388	308	286	286
query90	1936	226	225	225
query91	151	138	110	110
query92	85	70	68	68
query93	1110	956	627	627
query94	673	397	300	300
query95	398	324	390	324
query96	467	655	281	281
query97	2698	2732	2678	2678
query98	226	214	219	214
query99	1430	1427	1281	1281
Total cold run time: 273224 ms
Total hot run time: 187564 ms

@doris-robot
Copy link

doris-robot commented Jul 22, 2025

ClickBench: Total hot run time: 32.63 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 90d13c31e0057b7aae372629323f924f388cebf9, data reload: false

query1	0.05	0.03	0.04
query2	0.08	0.04	0.05
query3	0.24	0.07	0.08
query4	1.61	0.11	0.11
query5	0.44	0.40	0.42
query6	1.18	0.67	0.67
query7	0.03	0.02	0.02
query8	0.05	0.04	0.04
query9	0.60	0.54	0.50
query10	0.58	0.57	0.57
query11	0.16	0.11	0.11
query12	0.15	0.12	0.11
query13	0.64	0.62	0.60
query14	0.84	0.80	0.83
query15	0.91	0.87	0.88
query16	0.38	0.39	0.40
query17	1.05	1.06	1.04
query18	0.21	0.21	0.19
query19	1.94	1.83	1.90
query20	0.01	0.02	0.01
query21	15.42	0.92	0.53
query22	0.77	1.06	0.66
query23	15.08	1.39	0.61
query24	5.79	2.23	0.83
query25	0.47	0.23	0.12
query26	0.62	0.17	0.15
query27	0.06	0.06	0.05
query28	9.37	0.99	0.44
query29	12.53	3.93	3.30
query30	3.09	3.05	2.97
query31	2.83	0.59	0.39
query32	3.24	0.55	0.49
query33	3.11	3.11	3.11
query34	16.04	5.47	4.85
query35	4.90	4.87	4.88
query36	0.68	0.50	0.49
query37	0.10	0.07	0.07
query38	0.06	0.04	0.04
query39	0.04	0.03	0.03
query40	0.17	0.15	0.15
query41	0.07	0.03	0.02
query42	0.04	0.03	0.03
query43	0.04	0.03	0.03
Total cold run time: 105.67 s
Total hot run time: 32.63 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 22, 2025

FE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉
Increment coverage report
Complete coverage report

dataroaring
dataroaring approved these changes Jul 22, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 22, 2025
@dataroaring dataroaring merged commit ee4b255 into apache:master Jul 22, 2025
27 of 29 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 22, 2025
@sollhui
[chore](load) optimize show create load error message (#53694)
6de5d15 
### What problem does this PR solve?

If show create load with not exist label, the error message is `Database
does not exist`, it make users confused and not correct, and it should
be `Label does not exist`
@github-actions github-actions bot mentioned this pull request Jul 22, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jul 22, 2025
@sollhui
[chore](load) optimize show create load error message (#53694)
7106f80 
### What problem does this PR solve?

If show create load with not exist label, the error message is `Database
does not exist`, it make users confused and not correct, and it should
be `Label does not exist`
@github-actions github-actions bot mentioned this pull request Jul 22, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jul 22, 2025
@sollhui
[chore](load) optimize show create load error message (#53694)
1e6dec3 
### What problem does this PR solve?

If show create load with not exist label, the error message is `Database
does not exist`, it make users confused and not correct, and it should
be `Label does not exist`
@github-actions github-actions bot mentioned this pull request Jul 22, 2025
Merged
dataroaring pushed a commit that referenced this pull request Jul 23, 2025
@github-actions @sollhui
branch-3.0: [chore](load) optimize show create load error message #53694
7844a65 
 (#53730)

Cherry-picked from #53694

Co-authored-by: hui lai <laihui@selectdb.com>
morrySnow pushed a commit that referenced this pull request Jul 23, 2025
@github-actions @sollhui
branch-3.1: [chore](load) optimize show create load error message #53694
ca4222a 
 (#53732)

Cherry-picked from #53694

Co-authored-by: hui lai <laihui@selectdb.com>
yiguolei pushed a commit that referenced this pull request Jul 26, 2025
@github-actions @sollhui
branch-2.1: [chore](load) optimize show create load error message #53694
159975f 
 (#53731)

Cherry-picked from #53694

Co-authored-by: hui lai <laihui@selectdb.com>
w41ter pushed a commit to w41ter/incubator-doris that referenced this pull request Jul 30, 2025
@sollhui @w41ter
[chore](load) optimize show create load error message (apache#53694)
53a5280 
### What problem does this PR solve?

If show create load with not exist label, the error message is `Database
does not exist`, it make users confused and not correct, and it should
be `Label does not exist`
@gavinchou gavinchou mentioned this pull request Aug 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liaoxin01 liaoxin01 liaoxin01 approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.11-merged dev/3.1.0-merged p0_easy reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sollhui @doris-robot @hello-stephen @liaoxin01 @dataroaring @yiguolei @morrySnow