Skip to content

[Bug] Fix NPE when replaying modify table property #5378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 1 commit into from
Feb 16, 2021
Merged

[Bug] Fix NPE when replaying modify table property #5378

morningman merged 1 commit into from
Feb 16, 2021

Conversation

@xxiao2018
Copy link
Contributor

@xxiao2018 xxiao2018 commented Feb 9, 2021

No description provided.

morningman
morningman approved these changes Feb 14, 2021
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman self-assigned this Feb 14, 2021
@morningman morningman added approved Indicates a PR has been approved by one committer. kind/fix Categorizes issue or PR as related to a bug. labels Feb 14, 2021
@morningman morningman merged commit 99e1a97 into apache:master Feb 16, 2021
EmmyMiao87 pushed a commit to EmmyMiao87/incubator-doris that referenced this pull request Apr 21, 2021
@xxiao2018 @morningman-cmy
[Bug] Fix NPE when replaying modify table property (apache#5378)
27e8e5b
This was referenced Aug 5, 2021
Closed
Merged
morningman pushed a commit that referenced this pull request Sep 3, 2021
@ccoffline
[Catalog] Enforce null check at Catalog.getDb and Database.getTable (#…
df54b34 
…6416)

fix #5378 #5391 #5688 #5973 #6155 and all replay NPE. All replay method can now throw MetaNotFoundException and caught to log a warning for potential inconsistent metadata cases.

try to establish a clear notice for future developer to check null.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

Assignees

@morningman morningman

Labels

approved Indicates a PR has been approved by one committer. area/editlog-replay kind/fix Categorizes issue or PR as related to a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xxiao2018 @morningman @wangbo