Skip to content

Conversation

@Mryange
Copy link
Contributor

@Mryange Mryange commented Jul 24, 2025

picked from #53660

@Mryange Mryange requested a review from morrySnow as a code owner July 24, 2025 10:43
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Mryange Mryange changed the title [fix](core) Fix format round would core under boundary conditions. (#… [branch-3.1](core) Fix format round would core under boundary conditions Jul 24, 2025
@Mryange
Copy link
Contributor Author

Mryange commented Jul 24, 2025

run buildall

@Mryange Mryange force-pushed the branch-3.1-pick-53660- branch from 5070253 to af8308b Compare July 24, 2025 15:03
@Mryange
Copy link
Contributor Author

Mryange commented Jul 24, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32665 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit af8308ba886d1baf4f5025ab1a8387238245277c, data reload: false

------ Round 1 ----------------------------------
q1	17607	5518	5355	5355
q2	2056	285	167	167
q3	11013	1297	783	783
q4	10560	882	458	458
q5	9723	2374	2134	2134
q6	210	162	134	134
q7	902	754	607	607
q8	9334	1444	1213	1213
q9	5807	4956	5010	4956
q10	6815	2273	1825	1825
q11	472	271	257	257
q12	332	361	209	209
q13	17768	3612	3017	3017
q14	238	230	225	225
q15	526	470	479	470
q16	425	434	378	378
q17	609	877	363	363
q18	6601	6464	6353	6353
q19	1223	971	558	558
q20	334	348	206	206
q21	2970	2273	2017	2017
q22	1063	1037	980	980
Total cold run time: 106588 ms
Total hot run time: 32665 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5618	5516	5537	5516
q2	241	325	238	238
q3	2293	2654	2352	2352
q4	1393	1821	1375	1375
q5	4438	5046	4994	4994
q6	173	163	133	133
q7	2088	1979	1800	1800
q8	2653	2833	2760	2760
q9	7301	7244	7227	7227
q10	3038	3272	2756	2756
q11	572	536	493	493
q12	716	793	619	619
q13	3449	3800	3194	3194
q14	287	295	277	277
q15	525	479	482	479
q16	440	509	438	438
q17	1261	1778	1267	1267
q18	7555	7351	7422	7351
q19	813	1159	1088	1088
q20	1998	2025	1940	1940
q21	5381	5147	4641	4641
q22	1051	1068	1011	1011
Total cold run time: 53284 ms
Total hot run time: 51949 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 198127 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit af8308ba886d1baf4f5025ab1a8387238245277c, data reload: false

query1	1304	937	902	902
query2	6130	1878	1877	1877
query3	10940	4508	4232	4232
query4	33127	23716	23587	23587
query5	3673	617	450	450
query6	264	194	182	182
query7	3979	490	316	316
query8	301	247	237	237
query9	9152	2636	2610	2610
query10	467	329	264	264
query11	18134	15797	15143	15143
query12	166	109	109	109
query13	1571	559	435	435
query14	10847	7912	7505	7505
query15	224	210	199	199
query16	7754	663	548	548
query17	1602	800	614	614
query18	2064	415	319	319
query19	219	197	165	165
query20	134	122	121	121
query21	208	127	107	107
query22	4549	4442	4477	4442
query23	35217	34432	34040	34040
query24	7900	2805	2779	2779
query25	500	496	443	443
query26	1213	291	175	175
query27	2040	507	364	364
query28	5093	2206	2184	2184
query29	693	606	467	467
query30	247	199	174	174
query31	1006	941	879	879
query32	65	66	56	56
query33	510	355	302	302
query34	754	856	530	530
query35	819	853	723	723
query36	1026	1025	979	979
query37	106	93	67	67
query38	4102	4064	4117	4064
query39	1528	1532	1611	1532
query40	206	121	107	107
query41	51	47	48	47
query42	126	106	100	100
query43	504	514	486	486
query44	1399	828	856	828
query45	193	183	179	179
query46	903	1078	704	704
query47	1951	1978	1918	1918
query48	415	438	344	344
query49	767	492	411	411
query50	664	689	432	432
query51	7396	7349	7234	7234
query52	102	99	97	97
query53	244	270	188	188
query54	561	565	481	481
query55	82	83	80	80
query56	293	279	276	276
query57	1298	1289	1232	1232
query58	237	223	243	223
query59	3086	3209	3047	3047
query60	290	291	282	282
query61	123	155	119	119
query62	793	775	717	717
query63	241	197	192	192
query64	3993	1028	633	633
query65	3361	3290	3301	3290
query66	1078	421	326	326
query67	16143	15692	15703	15692
query68	6846	838	532	532
query69	497	303	259	259
query70	1203	1150	1116	1116
query71	394	302	269	269
query72	5778	3832	3857	3832
query73	640	752	356	356
query74	10485	9062	9177	9062
query75	3206	3170	2690	2690
query76	3215	1193	805	805
query77	464	387	289	289
query78	10484	10381	9579	9579
query79	3408	903	592	592
query80	788	523	436	436
query81	515	256	227	227
query82	1025	126	92	92
query83	166	157	145	145
query84	251	101	85	85
query85	800	366	302	302
query86	393	329	279	279
query87	4306	4288	4251	4251
query88	5274	2394	2386	2386
query89	424	327	293	293
query90	1809	190	196	190
query91	144	144	106	106
query92	68	54	51	51
query93	2902	892	528	528
query94	680	407	310	310
query95	353	284	278	278
query96	489	598	290	290
query97	3197	3301	3193	3193
query98	239	211	215	211
query99	1554	1431	1306	1306
Total cold run time: 298125 ms
Total hot run time: 198127 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.03 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit af8308ba886d1baf4f5025ab1a8387238245277c, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.03	0.03
query3	0.23	0.07	0.07
query4	1.63	0.11	0.10
query5	0.52	0.53	0.52
query6	1.13	0.75	0.72
query7	0.03	0.02	0.02
query8	0.04	0.03	0.03
query9	0.57	0.49	0.50
query10	0.54	0.55	0.56
query11	0.15	0.11	0.11
query12	0.14	0.11	0.12
query13	0.62	0.60	0.59
query14	0.78	0.78	0.81
query15	0.86	0.84	0.82
query16	0.37	0.38	0.39
query17	1.03	0.97	1.06
query18	0.23	0.21	0.22
query19	1.91	1.87	1.81
query20	0.02	0.00	0.01
query21	15.40	0.98	0.61
query22	0.73	0.78	0.66
query23	15.12	1.51	0.51
query24	2.67	1.92	1.22
query25	0.22	0.21	0.09
query26	0.30	0.16	0.13
query27	0.05	0.07	0.04
query28	14.31	1.03	0.45
query29	12.57	3.91	3.26
query30	0.24	0.09	0.07
query31	2.82	0.60	0.37
query32	3.22	0.54	0.47
query33	2.99	2.99	3.02
query34	16.65	5.17	4.50
query35	4.58	4.54	4.55
query36	0.66	0.49	0.49
query37	0.09	0.06	0.06
query38	0.04	0.04	0.03
query39	0.03	0.02	0.02
query40	0.16	0.13	0.12
query41	0.07	0.02	0.03
query42	0.03	0.02	0.02
query43	0.03	0.02	0.03
Total cold run time: 103.87 s
Total hot run time: 29.03 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 87.50% (28/32) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.28% (12572/27762)
Line Coverage 36.20% (111972/309347)
Region Coverage 35.26% (57892/164169)
Branch Coverage 32.45% (31476/96990)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 93.75% (30/32) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.09% (20871/27429)
Line Coverage 69.48% (214771/309110)
Region Coverage 67.54% (128536/190300)
Branch Coverage 61.11% (66866/109424)

1 similar comment
@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 93.75% (30/32) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.09% (20871/27429)
Line Coverage 69.48% (214771/309110)
Region Coverage 67.54% (128536/190300)
Branch Coverage 61.11% (66866/109424)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 93.75% (30/32) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.09% (20871/27429)
Line Coverage 69.48% (214770/309110)
Region Coverage 67.54% (128531/190300)
Branch Coverage 61.11% (66867/109424)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 93.75% (30/32) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.09% (20870/27429)
Line Coverage 69.47% (214753/309110)
Region Coverage 67.53% (128501/190300)
Branch Coverage 61.10% (66855/109424)

@morrySnow morrySnow changed the title [branch-3.1](core) Fix format round would core under boundary conditions branch-3.1: [fix](core) Fix format round would core under boundary conditions. #53660 Jul 25, 2025
@morrySnow morrySnow merged commit 092dab7 into apache:branch-3.1 Jul 25, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants