Skip to content

Conversation

@Hastyshell
Copy link
Collaborator

@Hastyshell Hastyshell commented Jul 29, 2025

What problem does this PR solve?

As title.

Branch master do not have this problem

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Hastyshell Hastyshell requested a review from dataroaring as a code owner July 29, 2025 12:42
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Hastyshell
Copy link
Collaborator Author

run buildall

@Hastyshell Hastyshell changed the title [fix](schema-change) Forbid dropping distribution columns [fix](schema-change) Forbid dropping distribution columns (branch-3.0) Jul 29, 2025
@doris-robot
Copy link

TPC-H: Total hot run time: 39388 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f7f6975328846d8ba5c93d4613746be704037623, data reload: false

------ Round 1 ----------------------------------
q1	17634	6691	6597	6597
q2	2071	195	170	170
q3	10574	1122	1130	1122
q4	10231	736	678	678
q5	7766	2832	2807	2807
q6	214	131	129	129
q7	964	619	594	594
q8	9341	1894	1978	1894
q9	6634	6342	6314	6314
q10	7000	2251	2263	2251
q11	462	255	261	255
q12	404	209	202	202
q13	17794	2969	2964	2964
q14	234	201	197	197
q15	520	475	463	463
q16	488	371	374	371
q17	949	507	524	507
q18	7203	6597	6663	6597
q19	1394	1010	1110	1010
q20	476	197	203	197
q21	4014	3175	3105	3105
q22	1119	964	972	964
Total cold run time: 107486 ms
Total hot run time: 39388 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6614	6571	6615	6571
q2	324	241	228	228
q3	2888	2833	2868	2833
q4	2108	1754	1803	1754
q5	5703	5728	5657	5657
q6	215	129	126	126
q7	2217	1821	1774	1774
q8	3370	3570	3496	3496
q9	8767	8834	8894	8834
q10	3570	3542	3631	3542
q11	591	490	502	490
q12	827	599	608	599
q13	9185	3236	3301	3236
q14	306	294	283	283
q15	512	485	479	479
q16	507	453	441	441
q17	1824	1616	1630	1616
q18	8483	8101	7662	7662
q19	1699	1550	1565	1550
q20	2052	1778	1807	1778
q21	5197	5137	4957	4957
q22	1131	1061	1059	1059
Total cold run time: 68090 ms
Total hot run time: 58965 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 195898 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f7f6975328846d8ba5c93d4613746be704037623, data reload: false

query1	1273	910	884	884
query2	6333	1868	1846	1846
query3	10888	4473	4672	4473
query4	33343	23453	23504	23453
query5	3626	440	435	435
query6	260	165	179	165
query7	3977	322	321	321
query8	285	227	221	221
query9	9310	2544	2535	2535
query10	465	260	246	246
query11	17870	15175	15094	15094
query12	158	105	105	105
query13	1552	462	421	421
query14	8853	6692	6611	6611
query15	229	193	194	193
query16	7758	496	491	491
query17	1657	602	601	601
query18	2041	315	324	315
query19	224	163	171	163
query20	124	122	122	122
query21	209	105	110	105
query22	4702	4489	4364	4364
query23	35957	34009	33801	33801
query24	12272	2975	2920	2920
query25	585	430	428	428
query26	1112	175	183	175
query27	3018	353	365	353
query28	7333	2125	2133	2125
query29	692	471	464	464
query30	264	164	162	162
query31	1047	807	845	807
query32	96	59	60	59
query33	787	303	311	303
query34	939	521	515	515
query35	894	738	707	707
query36	1076	919	957	919
query37	114	71	70	70
query38	4129	3977	4037	3977
query39	1524	1520	1447	1447
query40	262	108	102	102
query41	51	50	48	48
query42	121	101	102	101
query43	514	467	484	467
query44	1216	834	822	822
query45	185	172	187	172
query46	1158	753	712	712
query47	1985	1918	1910	1910
query48	469	382	384	382
query49	1004	392	399	392
query50	851	421	429	421
query51	7415	7167	7211	7167
query52	101	93	93	93
query53	276	186	194	186
query54	1364	471	464	464
query55	75	76	81	76
query56	260	271	241	241
query57	1330	1224	1185	1185
query58	227	211	233	211
query59	3247	2919	2903	2903
query60	294	273	273	273
query61	112	155	108	108
query62	819	681	689	681
query63	218	190	198	190
query64	5246	652	657	652
query65	3391	3291	3309	3291
query66	1364	306	313	306
query67	16083	15593	15510	15510
query68	4718	583	573	573
query69	439	263	257	257
query70	1144	1144	1159	1144
query71	364	266	254	254
query72	5975	4082	3997	3997
query73	775	347	349	347
query74	10602	8964	9057	8964
query75	3350	2609	2614	2609
query76	2599	1024	1209	1024
query77	368	265	267	265
query78	10816	9628	9625	9625
query79	2075	606	595	595
query80	1079	431	434	431
query81	547	223	219	219
query82	841	86	87	86
query83	227	138	136	136
query84	236	83	78	78
query85	1369	296	289	289
query86	454	303	299	299
query87	4420	4214	4282	4214
query88	4007	2355	2336	2336
query89	421	293	296	293
query90	1894	193	188	188
query91	186	148	148	148
query92	63	47	51	47
query93	2283	564	561	561
query94	817	297	299	297
query95	363	260	261	260
query96	625	276	277	276
query97	3277	3143	3171	3143
query98	220	205	210	205
query99	1501	1303	1276	1276
Total cold run time: 304669 ms
Total hot run time: 195898 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.47 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f7f6975328846d8ba5c93d4613746be704037623, data reload: false

query1	0.03	0.03	0.04
query2	0.07	0.03	0.03
query3	0.23	0.06	0.06
query4	1.64	0.11	0.10
query5	0.49	0.53	0.51
query6	1.13	0.73	0.73
query7	0.03	0.02	0.01
query8	0.04	0.03	0.03
query9	0.56	0.50	0.50
query10	0.55	0.56	0.58
query11	0.15	0.10	0.10
query12	0.14	0.11	0.11
query13	0.61	0.59	0.59
query14	0.76	0.80	0.80
query15	0.85	0.82	0.82
query16	0.39	0.39	0.39
query17	1.06	1.02	1.05
query18	0.23	0.20	0.21
query19	1.94	1.87	1.85
query20	0.01	0.01	0.01
query21	15.38	0.60	0.58
query22	2.33	3.00	1.65
query23	17.21	0.81	0.91
query24	3.11	0.32	1.79
query25	0.35	0.12	0.24
query26	0.31	0.14	0.13
query27	0.07	0.04	0.04
query28	10.52	0.50	0.49
query29	12.58	3.21	3.21
query30	0.25	0.06	0.06
query31	2.87	0.41	0.40
query32	3.23	0.46	0.46
query33	2.96	2.99	3.02
query34	17.10	4.57	4.48
query35	4.53	4.57	4.53
query36	0.68	0.47	0.48
query37	0.08	0.06	0.05
query38	0.04	0.03	0.04
query39	0.03	0.02	0.02
query40	0.16	0.12	0.13
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 104.86 s
Total hot run time: 29.47 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 0.00% (0/2) 🎉
Increment coverage report
Complete coverage report

dataroaring
dataroaring previously approved these changes Jul 29, 2025
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 29, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jul 30, 2025
@Hastyshell
Copy link
Collaborator Author

run buildall

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 6491551 into apache:branch-3.0 Jul 30, 2025
24 of 26 checks passed
@gavinchou gavinchou mentioned this pull request Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants