Skip to content

[enhance](auth)support ldap user show grants #54087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
starocean999 merged 3 commits into from
Aug 13, 2025
Merged

[enhance](auth)support ldap user show grants #54087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
635b426
1
zddr Jul 30, 2025
df6267f
1
zddr Aug 7, 2025
a1df479
1
zddr Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ...e-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/ShowGrantsCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,16 +81,17 @@ public ShowResultSet doRun(ConnectContext ctx, StmtExecutor executor) throws Exc
userIdent = ConnectContext.get().getCurrentUserIdentity();
}
}
boolean isSelf = userIdent != null && ConnectContext.get().getCurrentUserIdentity().equals(userIdent);
Preconditions.checkState(isAll || userIdent != null);
UserIdentity self = ConnectContext.get().getCurrentUserIdentity();

// if show all grants, or show other user's grants, need global GRANT priv.
if (isAll || !self.equals(userIdent)) {
if (isAll || !isSelf) {
if (!Env.getCurrentEnv().getAccessManager().checkGlobalPriv(ConnectContext.get(), PrivPredicate.GRANT)) {
ErrorReport.reportAnalysisException(ErrorCode.ERR_SPECIFIC_ACCESS_DENIED_ERROR, "GRANT");
}
}
if (userIdent != null && !Env.getCurrentEnv().getAccessManager().getAuth().doesUserExist(userIdent)) {
// ldap user not exist in userManager, so should not check
if (userIdent != null && !isSelf && !Env.getCurrentEnv().getAccessManager().getAuth()
.doesUserExist(userIdent)) {
throw new AnalysisException(String.format("User: %s does not exist", userIdent));
}
List<List<String>> infos = Env.getCurrentEnv().getAuth().getAuthInfo(userIdent);
Expand Down
17 changes: 17 additions & 0 deletions ...re/src/test/java/org/apache/doris/nereids/trees/plans/commands/ShowGrantsCommandTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,4 +86,21 @@ void testDorun() throws Exception {
int size = results.size();
Assertions.assertEquals("'zzz'@'%'", results.get(size - 1).get(0));
}

@Test
void testNonExistUser() {
ConnectContext ctx = ConnectContext.get();
UserIdentity nonExistUser = UserIdentity.createAnalyzedUserIdentWithIp("non_exist_user", "%");
Assertions.assertThrows(AnalysisException.class, () -> {
ShowGrantsCommand sg = new ShowGrantsCommand(nonExistUser, false);
sg.doRun(ctx, null);
});

ctx.setIsTempUser(true);
ctx.setCurrentUserIdentity(nonExistUser);
Assertions.assertDoesNotThrow(() -> {
ShowGrantsCommand sg = new ShowGrantsCommand(null, false);
sg.doRun(ctx, null);
});
}
}