[fix](decimal256) fix casting decimal256 to float #54140

jacktengg · 2025-07-31T07:12:52Z

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

hello-stephen · 2025-07-31T07:12:57Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

jacktengg · 2025-07-31T07:13:49Z

run buildall

hello-stephen · 2025-07-31T08:47:20Z

BE UT Coverage Report

Increment line coverage 0.00% (0/7) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	41.90% (11137/26580)
Line Coverage	32.43% (95410/294186)
Region Coverage	31.56% (49267/156117)
Branch Coverage	27.99% (25247/90186)

doris-robot · 2025-07-31T08:49:03Z

TPC-H: Total hot run time: 40099 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 24cb2bdd7e0e5989e4847ee0e7e877bac49b9a03, data reload: false

------ Round 1 ----------------------------------
q1	17878	7137	6724	6724
q2	2094	163	154	154
q3	10689	1150	1184	1150
q4	10411	749	761	749
q5	7746	2943	2870	2870
q6	216	135	132	132
q7	979	633	605	605
q8	9356	2026	2013	2013
q9	6742	6479	6441	6441
q10	7026	2262	2295	2262
q11	459	263	263	263
q12	392	214	223	214
q13	17776	2975	3006	2975
q14	236	207	206	206
q15	517	476	461	461
q16	450	371	391	371
q17	992	589	482	482
q18	7245	6726	6754	6726
q19	1405	1105	1038	1038
q20	486	195	201	195
q21	3872	3239	3069	3069
q22	1089	999	1006	999
Total cold run time: 108056 ms
Total hot run time: 40099 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6672	6632	6647	6632
q2	331	233	234	233
q3	2958	2920	2999	2920
q4	2052	1834	1854	1834
q5	5758	5764	5791	5764
q6	213	136	136	136
q7	2289	1807	1820	1807
q8	3410	3612	3567	3567
q9	8792	8972	8901	8901
q10	3583	3543	3541	3541
q11	600	509	505	505
q12	789	590	651	590
q13	8167	3185	3154	3154
q14	304	267	267	267
q15	517	478	459	459
q16	500	442	437	437
q17	1890	1626	1659	1626
q18	8304	7799	7714	7714
q19	1729	1472	1489	1472
q20	2105	1824	1883	1824
q21	5246	5225	4984	4984
q22	1139	1076	1019	1019
Total cold run time: 67348 ms
Total hot run time: 59386 ms

doris-robot · 2025-07-31T09:01:25Z

TPC-DS: Total hot run time: 196490 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 24cb2bdd7e0e5989e4847ee0e7e877bac49b9a03, data reload: false

query1	1302	929	884	884
query2	6249	1962	1845	1845
query3	10942	4559	4358	4358
query4	33032	24108	23564	23564
query5	4848	449	449	449
query6	286	167	177	167
query7	3987	306	329	306
query8	299	218	221	218
query9	9592	2565	2549	2549
query10	495	255	245	245
query11	18024	15599	15180	15180
query12	161	105	100	100
query13	1557	427	436	427
query14	8940	7380	6802	6802
query15	246	187	193	187
query16	7984	488	516	488
query17	1508	628	622	622
query18	2161	328	316	316
query19	238	162	166	162
query20	133	119	114	114
query21	222	117	118	117
query22	4731	4429	4398	4398
query23	35833	34162	34342	34162
query24	11842	2917	2967	2917
query25	672	380	411	380
query26	1763	170	164	164
query27	3040	346	344	344
query28	7713	2131	2144	2131
query29	1021	443	454	443
query30	259	158	158	158
query31	1054	795	830	795
query32	93	54	57	54
query33	759	297	298	297
query34	1042	507	514	507
query35	855	718	736	718
query36	1110	961	969	961
query37	274	67	70	67
query38	4096	3976	3914	3914
query39	1554	1470	1470	1470
query40	263	105	114	105
query41	58	56	53	53
query42	120	101	110	101
query43	530	482	482	482
query44	1237	811	819	811
query45	192	175	173	173
query46	1167	766	747	747
query47	2018	1897	1944	1897
query48	489	385	378	378
query49	1157	412	440	412
query50	838	428	422	422
query51	7469	7331	7248	7248
query52	105	97	90	90
query53	266	190	186	186
query54	1064	481	485	481
query55	78	78	82	78
query56	273	267	274	267
query57	1306	1226	1176	1176
query58	252	218	222	218
query59	3204	2945	2973	2945
query60	303	260	271	260
query61	133	153	135	135
query62	836	694	717	694
query63	228	197	200	197
query64	4853	684	644	644
query65	3378	3306	3289	3289
query66	1210	301	303	301
query67	16163	15551	15433	15433
query68	4787	576	577	576
query69	416	267	256	256
query70	1166	1080	1116	1080
query71	318	265	249	249
query72	6166	4134	4007	4007
query73	765	344	345	344
query74	10054	9041	8871	8871
query75	3393	2656	2678	2656
query76	2682	1058	1090	1058
query77	361	272	275	272
query78	10531	9551	9570	9551
query79	1722	595	587	587
query80	1087	430	437	430
query81	554	217	220	217
query82	948	89	89	89
query83	245	139	138	138
query84	241	77	81	77
query85	1274	296	291	291
query86	407	315	301	301
query87	4382	4274	4320	4274
query88	3630	2368	2335	2335
query89	420	307	290	290
query90	1879	184	183	183
query91	184	146	143	143
query92	73	51	49	49
query93	2136	560	554	554
query94	743	296	280	280
query95	358	264	251	251
query96	605	275	276	275
query97	3319	3126	3107	3107
query98	214	202	194	194
query99	1486	1317	1302	1302
Total cold run time: 305653 ms
Total hot run time: 196490 ms

doris-robot · 2025-07-31T09:07:01Z

ClickBench: Total hot run time: 30.15 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 24cb2bdd7e0e5989e4847ee0e7e877bac49b9a03, data reload: false

query1	0.04	0.04	0.02
query2	0.08	0.04	0.03
query3	0.23	0.07	0.07
query4	1.61	0.11	0.11
query5	0.51	0.51	0.51
query6	1.12	0.74	0.72
query7	0.05	0.02	0.01
query8	0.04	0.03	0.03
query9	0.57	0.52	0.51
query10	0.54	0.57	0.58
query11	0.15	0.09	0.11
query12	0.14	0.11	0.11
query13	0.60	0.60	0.59
query14	0.78	0.79	0.81
query15	0.84	0.81	0.82
query16	0.37	0.36	0.38
query17	1.08	1.08	1.05
query18	0.24	0.23	0.22
query19	1.95	1.80	1.89
query20	0.02	0.01	0.01
query21	15.39	0.58	0.58
query22	2.61	1.98	2.22
query23	16.98	1.08	0.83
query24	3.31	0.66	1.05
query25	0.23	0.08	0.06
query26	0.44	0.14	0.15
query27	0.04	0.05	0.06
query28	10.46	0.52	0.47
query29	12.56	3.26	3.21
query30	0.25	0.06	0.06
query31	2.85	0.39	0.38
query32	3.23	0.46	0.45
query33	2.99	3.03	3.04
query34	17.13	4.50	4.57
query35	4.61	4.59	4.56
query36	0.70	0.48	0.48
query37	0.08	0.06	0.06
query38	0.05	0.03	0.03
query39	0.04	0.02	0.02
query40	0.16	0.13	0.12
query41	0.09	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 105.23 s
Total hot run time: 30.15 s

hello-stephen · 2025-07-31T11:05:12Z

BE Regression && UT Coverage Report

Increment line coverage 100.00% (7/7) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	74.98% (19671/26234)
Line Coverage	68.27% (200595/293821)
Region Coverage	66.39% (120042/180819)
Branch Coverage	59.77% (60945/101966)

jacktengg · 2025-07-31T14:02:07Z

run buildall

doris-robot · 2025-07-31T14:30:50Z

TPC-H: Total hot run time: 39725 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 17ae2f131ea8dbc068c655c9dbffa2457e23e08f, data reload: false

------ Round 1 ----------------------------------
q1	17593	6737	6589	6589
q2	2078	185	160	160
q3	10516	1138	1242	1138
q4	10217	720	730	720
q5	7742	2800	2816	2800
q6	213	135	134	134
q7	958	613	614	613
q8	9361	1897	2020	1897
q9	6643	6399	6374	6374
q10	7056	2310	2287	2287
q11	466	258	258	258
q12	412	211	214	211
q13	17776	2947	2989	2947
q14	227	202	209	202
q15	507	479	478	478
q16	513	377	380	377
q17	977	580	517	517
q18	7120	6625	6656	6625
q19	1386	1092	1024	1024
q20	462	194	207	194
q21	3891	3184	3212	3184
q22	1082	996	1006	996
Total cold run time: 107196 ms
Total hot run time: 39725 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6600	6601	6610	6601
q2	325	229	223	223
q3	2914	2897	2969	2897
q4	2089	1834	1917	1834
q5	5812	5861	5808	5808
q6	218	134	133	133
q7	2343	1867	1871	1867
q8	3418	3543	3573	3543
q9	8862	8985	8947	8947
q10	3626	3543	3629	3543
q11	589	501	508	501
q12	846	579	590	579
q13	9054	3195	3151	3151
q14	308	280	269	269
q15	503	476	476	476
q16	491	434	453	434
q17	1834	1615	1624	1615
q18	8118	7780	7817	7780
q19	1628	1529	1438	1438
q20	2049	1814	1865	1814
q21	5174	5142	4845	4845
q22	1144	1042	1027	1027
Total cold run time: 67945 ms
Total hot run time: 59325 ms

doris-robot · 2025-07-31T14:43:10Z

TPC-DS: Total hot run time: 197082 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 17ae2f131ea8dbc068c655c9dbffa2457e23e08f, data reload: false

query1	1294	914	878	878
query2	6251	1837	1814	1814
query3	10945	4450	4407	4407
query4	33465	23627	23601	23601
query5	3436	469	457	457
query6	265	177	194	177
query7	3987	305	315	305
query8	277	236	226	226
query9	9373	2567	2568	2567
query10	489	267	259	259
query11	17647	15278	15218	15218
query12	155	101	102	101
query13	1546	440	423	423
query14	9614	6778	6768	6768
query15	224	192	191	191
query16	7764	504	490	490
query17	1575	613	608	608
query18	2026	323	319	319
query19	225	173	170	170
query20	118	115	113	113
query21	209	110	116	110
query22	4725	4381	4323	4323
query23	35190	34242	34672	34242
query24	11534	2964	2916	2916
query25	742	424	455	424
query26	1806	178	171	171
query27	2861	361	362	361
query28	8113	2145	2169	2145
query29	1114	466	485	466
query30	272	164	175	164
query31	1072	848	832	832
query32	92	52	52	52
query33	761	286	304	286
query34	1181	525	541	525
query35	932	735	721	721
query36	1160	970	932	932
query37	141	65	65	65
query38	4130	4000	3968	3968
query39	1507	1452	1462	1452
query40	262	103	97	97
query41	47	52	46	46
query42	119	102	105	102
query43	513	472	496	472
query44	1281	821	815	815
query45	186	180	167	167
query46	1170	724	729	724
query47	2025	1921	1952	1921
query48	486	371	383	371
query49	1048	403	394	394
query50	843	425	428	425
query51	7534	7328	7276	7276
query52	99	88	88	88
query53	257	185	182	182
query54	1282	479	484	479
query55	81	78	78	78
query56	286	244	256	244
query57	1343	1215	1211	1211
query58	230	218	208	208
query59	3103	2952	2913	2913
query60	279	257	252	252
query61	115	107	111	107
query62	883	701	709	701
query63	223	203	205	203
query64	4908	653	639	639
query65	3362	3295	3293	3293
query66	1330	312	310	310
query67	16121	15527	15524	15524
query68	4941	579	579	579
query69	439	269	263	263
query70	1151	1113	1146	1113
query71	333	256	249	249
query72	6236	4080	4015	4015
query73	770	344	352	344
query74	9502	9225	9099	9099
query75	3366	2619	2647	2619
query76	2545	1128	1077	1077
query77	407	263	282	263
query78	10579	9638	9636	9636
query79	2306	585	613	585
query80	874	450	424	424
query81	536	222	222	222
query82	631	86	89	86
query83	247	146	139	139
query84	234	81	72	72
query85	1459	307	298	298
query86	437	288	311	288
query87	4401	4260	4234	4234
query88	4264	2369	2310	2310
query89	420	286	280	280
query90	1952	188	185	185
query91	185	149	152	149
query92	64	52	53	52
query93	2255	558	561	558
query94	804	293	297	293
query95	358	252	255	252
query96	627	285	279	279
query97	3347	3157	3160	3157
query98	221	193	193	193
query99	1530	1331	1280	1280
Total cold run time: 305055 ms
Total hot run time: 197082 ms

doris-robot · 2025-07-31T14:48:34Z

ClickBench: Total hot run time: 30.33 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 17ae2f131ea8dbc068c655c9dbffa2457e23e08f, data reload: false

query1	0.03	0.03	0.02
query2	0.07	0.02	0.03
query3	0.23	0.06	0.06
query4	1.63	0.10	0.10
query5	0.51	0.51	0.51
query6	1.12	0.73	0.73
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.57	0.50	0.49
query10	0.54	0.57	0.59
query11	0.14	0.11	0.11
query12	0.14	0.11	0.11
query13	0.60	0.59	0.60
query14	0.76	0.79	0.81
query15	0.83	0.84	0.82
query16	0.37	0.36	0.39
query17	1.04	1.03	1.06
query18	0.24	0.23	0.21
query19	1.89	1.83	1.87
query20	0.01	0.01	0.01
query21	15.42	0.58	0.58
query22	2.20	1.73	1.65
query23	16.75	0.97	0.81
query24	3.36	1.11	2.00
query25	0.31	0.11	0.13
query26	0.45	0.15	0.14
query27	0.06	0.04	0.04
query28	9.04	0.56	0.53
query29	12.58	3.21	3.23
query30	0.25	0.06	0.06
query31	2.86	0.40	0.39
query32	3.22	0.46	0.45
query33	2.97	3.03	3.09
query34	16.74	4.52	4.54
query35	4.52	4.56	4.54
query36	0.66	0.47	0.47
query37	0.08	0.06	0.05
query38	0.04	0.03	0.04
query39	0.04	0.02	0.03
query40	0.16	0.13	0.12
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 102.63 s
Total hot run time: 30.33 s

hello-stephen · 2025-07-31T15:39:30Z

BE UT Coverage Report

Increment line coverage 0.00% (0/7) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	41.90% (11137/26580)
Line Coverage	32.43% (95390/294184)
Region Coverage	31.56% (49273/156117)
Branch Coverage	28.00% (25248/90186)

hello-stephen · 2025-07-31T16:33:57Z

BE Regression && UT Coverage Report

Increment line coverage 100.00% (7/7) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	75.05% (19689/26234)
Line Coverage	68.31% (200714/293819)
Region Coverage	66.40% (120057/180819)
Branch Coverage	59.74% (60919/101966)

dataroaring

LGTM

…)" This reverts commit 54d4aca.

…54231) picked from #54140

jacktengg requested a review from dataroaring as a code owner July 31, 2025 07:12

[fix](decimal256) fix casting decimal256 to float

17ae2f1

jacktengg force-pushed the fix-dec256-cast branch from 24cb2bd to 17ae2f1 Compare July 31, 2025 14:01

yiguolei added dev/2.1.x usercase Important user case type label labels Aug 1, 2025

dataroaring approved these changes Aug 1, 2025

View reviewed changes

dataroaring merged commit 54d4aca into apache:branch-3.0 Aug 1, 2025
22 of 25 checks passed

yiguolei added dev/3.0.x dev/3.1.x labels Aug 1, 2025

dataroaring added dev/3.0.7-merged and removed dev/3.0.x labels Aug 1, 2025

morrySnow added dev/2.1.11-merged and removed dev/2.1.x labels Aug 1, 2025

This was referenced Aug 1, 2025

[fix](decimal256) fix casting decimal256 to float #54178

Merged

branch-3.1: [fix](decimal256) fix casting decimal256 to float #54140 #54231

Merged

BiteTheDDDDt added a commit to BiteTheDDDDt/incubator-doris that referenced this pull request Aug 4, 2025

Revert "[fix](decimal256) fix casting decimal256 to float (apache#54140…

9a6630a

…)" This reverts commit 54d4aca.

morrySnow pushed a commit that referenced this pull request Aug 4, 2025

branch-3.1: [fix](decimal256) fix casting decimal256 to float #54140 (#…

3702559

…54231) picked from #54140

morrySnow added dev/3.1.0-merged and removed dev/3.1.x labels Aug 4, 2025

gavinchou mentioned this pull request Aug 15, 2025

Release Note 3.0.7 #54868

Open

[fix](decimal256) fix casting decimal256 to float #54140

[fix](decimal256) fix casting decimal256 to float #54140

Uh oh!

Conversation

jacktengg commented Jul 31, 2025

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

hello-stephen commented Jul 31, 2025

Uh oh!

jacktengg commented Jul 31, 2025

Uh oh!

hello-stephen commented Jul 31, 2025

BE UT Coverage Report

Uh oh!

doris-robot commented Jul 31, 2025

Uh oh!

doris-robot commented Jul 31, 2025

Uh oh!

doris-robot commented Jul 31, 2025

Uh oh!

hello-stephen commented Jul 31, 2025

BE Regression && UT Coverage Report

Uh oh!

jacktengg commented Jul 31, 2025

Uh oh!

doris-robot commented Jul 31, 2025

Uh oh!

doris-robot commented Jul 31, 2025

Uh oh!

doris-robot commented Jul 31, 2025

Uh oh!

hello-stephen commented Jul 31, 2025

BE UT Coverage Report

Uh oh!

hello-stephen commented Jul 31, 2025

BE Regression && UT Coverage Report

Uh oh!

dataroaring left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants