Skip to content

branch-30: [Bug](agg) fix agg with topn limit coredump with ctor same key twice (#54137) #54271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataroaring merged 1 commit into from
Sep 5, 2025
Merged

branch-30: [Bug](agg) fix agg with topn limit coredump with ctor same key twice (#54137) #54271

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion be/src/pipeline/exec/aggregation_sink_operator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,6 +601,7 @@ bool AggSinkLocalState::_emplace_into_hash_table_limit(vectorized::AggregateData
try {
HashMethodType::try_presis_key_and_origin(key, origin,
*_agg_arena_pool);
_shared_state->refresh_top_limit(i, key_columns);
auto mapped =
_shared_state->aggregate_data_container->append_data(
origin);
Expand All @@ -609,7 +610,6 @@ bool AggSinkLocalState::_emplace_into_hash_table_limit(vectorized::AggregateData
throw Exception(st.code(), st.to_string());
}
ctor(key, mapped);
_shared_state->refresh_top_limit(i, key_columns);
} catch (...) {
// Exception-safety - if it can not allocate memory or create status,
// the destructors will not be called.
Expand Down
Loading