Skip to content

Conversation

@englefly
Copy link
Contributor

@englefly englefly commented Aug 7, 2025

What problem does this PR solve?

pick #53834
Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@englefly englefly requested a review from dataroaring as a code owner August 7, 2025 04:39
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@englefly
Copy link
Contributor Author

englefly commented Aug 7, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39699 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a78040128edf82a22e338c7a35d007129963187c, data reload: false

------ Round 1 ----------------------------------
q1	17639	6720	6577	6577
q2	2049	196	171	171
q3	10509	1109	1194	1109
q4	10220	779	724	724
q5	7735	2811	2766	2766
q6	212	131	128	128
q7	942	609	599	599
q8	9355	1935	1951	1935
q9	6685	6418	6423	6418
q10	7010	2216	2286	2216
q11	457	259	251	251
q12	404	215	210	210
q13	17797	2934	2963	2934
q14	251	209	220	209
q15	512	475	476	475
q16	490	392	383	383
q17	974	591	526	526
q18	7209	6624	6637	6624
q19	1405	1082	1096	1082
q20	480	205	206	205
q21	3903	3131	3153	3131
q22	1148	1026	1032	1026
Total cold run time: 107386 ms
Total hot run time: 39699 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6636	6613	6725	6613
q2	329	240	228	228
q3	2953	2926	2915	2915
q4	2071	1803	1834	1803
q5	5705	5720	5719	5719
q6	213	129	125	125
q7	2234	1810	1789	1789
q8	3370	3548	3491	3491
q9	8812	8816	8836	8816
q10	3562	3500	3520	3500
q11	597	481	492	481
q12	799	611	596	596
q13	9568	3236	3089	3089
q14	292	264	270	264
q15	513	470	467	467
q16	477	421	434	421
q17	1834	1616	1582	1582
q18	8301	7769	7738	7738
q19	1670	1605	1461	1461
q20	2052	1785	1841	1785
q21	5283	5007	4930	4930
q22	1151	1087	1049	1049
Total cold run time: 68422 ms
Total hot run time: 58862 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 193224 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a78040128edf82a22e338c7a35d007129963187c, data reload: false

query1	960	395	412	395
query2	6330	1900	1830	1830
query3	8690	204	198	198
query4	33784	24271	23806	23806
query5	4511	462	446	446
query6	304	185	178	178
query7	4190	308	319	308
query8	293	223	218	218
query9	9526	2582	2583	2582
query10	492	267	249	249
query11	18049	15361	15244	15244
query12	150	104	102	102
query13	1549	440	425	425
query14	9753	6895	7139	6895
query15	250	168	174	168
query16	8087	501	520	501
query17	1611	608	604	604
query18	2191	342	338	338
query19	355	170	167	167
query20	125	118	119	118
query21	212	112	115	112
query22	4678	4542	4485	4485
query23	35133	34560	33998	33998
query24	11083	2964	2914	2914
query25	653	403	410	403
query26	1201	170	205	170
query27	2879	354	363	354
query28	7403	2154	2150	2150
query29	874	462	441	441
query30	260	175	166	166
query31	1078	843	801	801
query32	96	53	55	53
query33	768	299	319	299
query34	1021	534	522	522
query35	890	715	729	715
query36	1160	946	964	946
query37	135	73	62	62
query38	4119	4008	3948	3948
query39	1537	1499	1504	1499
query40	198	101	102	101
query41	50	48	49	48
query42	111	104	101	101
query43	536	487	484	484
query44	1312	810	791	791
query45	182	167	168	167
query46	1165	750	722	722
query47	2044	1943	1902	1902
query48	484	379	389	379
query49	905	388	389	388
query50	834	427	442	427
query51	7669	7456	7285	7285
query52	106	93	86	86
query53	263	180	181	180
query54	1169	473	461	461
query55	81	80	74	74
query56	278	244	245	244
query57	1361	1231	1205	1205
query58	227	221	222	221
query59	3243	2957	2937	2937
query60	299	249	249	249
query61	109	108	109	108
query62	834	718	688	688
query63	227	195	190	190
query64	4067	681	639	639
query65	3450	3341	3389	3341
query66	915	316	302	302
query67	15911	15478	15460	15460
query68	4837	564	575	564
query69	440	262	268	262
query70	1180	1037	1135	1037
query71	335	255	252	252
query72	6412	4229	4313	4229
query73	756	346	352	346
query74	10466	9241	9247	9241
query75	3468	2670	2734	2670
query76	2679	1221	1062	1062
query77	378	266	263	263
query78	11041	9943	9937	9937
query79	2383	594	599	594
query80	892	416	415	415
query81	561	231	228	228
query82	617	88	86	86
query83	252	139	142	139
query84	238	77	83	77
query85	1609	303	300	300
query86	453	306	285	285
query87	4405	4293	4231	4231
query88	4179	2354	2346	2346
query89	432	304	294	294
query90	1966	185	181	181
query91	179	155	154	154
query92	64	52	50	50
query93	2158	550	544	544
query94	854	311	288	288
query95	352	253	252	252
query96	623	276	280	276
query97	3328	3152	3199	3152
query98	223	200	208	200
query99	1512	1318	1279	1279
Total cold run time: 303682 ms
Total hot run time: 193224 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.91 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a78040128edf82a22e338c7a35d007129963187c, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.03	0.03
query3	0.23	0.07	0.07
query4	1.62	0.11	0.10
query5	0.54	0.49	0.52
query6	1.13	0.73	0.73
query7	0.02	0.01	0.02
query8	0.04	0.05	0.03
query9	0.55	0.51	0.50
query10	0.54	0.56	0.57
query11	0.15	0.10	0.10
query12	0.14	0.10	0.10
query13	0.62	0.59	0.59
query14	0.77	0.80	0.78
query15	0.85	0.83	0.82
query16	0.38	0.37	0.37
query17	1.05	0.98	1.01
query18	0.24	0.21	0.22
query19	1.98	1.78	1.87
query20	0.01	0.01	0.02
query21	15.40	0.61	0.58
query22	2.74	2.09	1.46
query23	17.18	0.91	0.91
query24	3.18	0.92	1.71
query25	0.20	0.13	0.16
query26	0.38	0.13	0.14
query27	0.03	0.04	0.05
query28	9.82	0.55	0.50
query29	12.60	3.27	3.26
query30	0.25	0.06	0.07
query31	2.86	0.37	0.37
query32	3.24	0.45	0.45
query33	2.95	2.99	3.00
query34	17.21	4.47	4.52
query35	4.54	4.57	4.57
query36	0.67	0.48	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.04	0.03	0.02
query40	0.16	0.13	0.12
query41	0.07	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.04
Total cold run time: 104.68 s
Total hot run time: 29.91 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 0.00% (0/7) 🎉
Increment coverage report
Complete coverage report

@englefly
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 0.00% (0/7) 🎉
Increment coverage report
Complete coverage report

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 43b104d into apache:branch-3.0 Aug 14, 2025
23 of 25 checks passed
@gavinchou gavinchou mentioned this pull request Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants