Skip to content

Conversation

@englefly
Copy link
Contributor

@englefly englefly commented Aug 7, 2025

picked from #53834

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@englefly englefly changed the base branch from master to branch-3.1 August 8, 2025 03:53
@englefly englefly requested a review from morrySnow as a code owner August 8, 2025 03:53
@englefly
Copy link
Contributor Author

englefly commented Aug 8, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32947 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6594630725c5de83b31992571985ef434ecfdec0, data reload: false

------ Round 1 ----------------------------------
q1	17585	5728	5762	5728
q2	2033	394	277	277
q3	11850	1228	749	749
q4	10341	881	459	459
q5	9602	2380	2096	2096
q6	194	167	136	136
q7	888	746	628	628
q8	9328	1403	1145	1145
q9	5228	5167	4909	4909
q10	6752	2252	1851	1851
q11	489	278	268	268
q12	339	360	215	215
q13	17783	3603	2997	2997
q14	234	224	207	207
q15	521	479	461	461
q16	414	424	375	375
q17	573	852	357	357
q18	6880	6473	6490	6473
q19	1214	939	558	558
q20	321	342	201	201
q21	2774	2124	1907	1907
q22	1056	1046	950	950
Total cold run time: 106399 ms
Total hot run time: 32947 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5919	5889	5875	5875
q2	232	322	232	232
q3	2209	2614	2284	2284
q4	1314	1782	1376	1376
q5	4408	4995	4971	4971
q6	169	163	134	134
q7	2032	1942	1838	1838
q8	2594	2801	2696	2696
q9	7229	7219	7178	7178
q10	3073	3271	2776	2776
q11	604	501	493	493
q12	646	772	595	595
q13	3421	3733	3136	3136
q14	279	296	277	277
q15	521	475	474	474
q16	437	484	427	427
q17	1221	1750	1277	1277
q18	7738	7476	7136	7136
q19	798	1027	1125	1027
q20	2028	2073	1910	1910
q21	5322	4954	4730	4730
q22	1063	1046	1029	1029
Total cold run time: 53257 ms
Total hot run time: 51871 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 190248 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6594630725c5de83b31992571985ef434ecfdec0, data reload: false

query1	937	398	401	398
query2	6126	1961	1957	1957
query3	8702	200	192	192
query4	33618	23908	23180	23180
query5	3585	598	442	442
query6	297	198	184	184
query7	4209	486	310	310
query8	310	245	248	245
query9	9679	2569	2543	2543
query10	446	323	250	250
query11	18011	15655	15226	15226
query12	158	107	107	107
query13	1564	543	414	414
query14	9841	6503	7082	6503
query15	258	192	171	171
query16	8060	604	497	497
query17	1569	788	579	579
query18	2147	423	348	348
query19	228	180	177	177
query20	126	122	119	119
query21	211	133	119	119
query22	4504	4655	4341	4341
query23	35339	34551	34093	34093
query24	7445	2694	2691	2691
query25	536	517	427	427
query26	831	293	188	188
query27	2097	490	377	377
query28	5560	2207	2175	2175
query29	727	573	461	461
query30	243	193	160	160
query31	1148	930	845	845
query32	98	64	63	63
query33	503	369	312	312
query34	780	863	539	539
query35	783	820	731	731
query36	1007	1063	974	974
query37	106	100	71	71
query38	3970	4009	3929	3929
query39	1536	1460	1479	1460
query40	209	120	106	106
query41	50	51	49	49
query42	127	112	109	109
query43	521	516	505	505
query44	1347	800	818	800
query45	185	181	178	178
query46	874	1049	680	680
query47	1931	1973	1977	1973
query48	427	439	361	361
query49	739	490	426	426
query50	673	702	431	431
query51	7446	7281	7234	7234
query52	102	104	94	94
query53	242	261	193	193
query54	553	554	467	467
query55	83	80	80	80
query56	261	292	255	255
query57	1268	1297	1190	1190
query58	252	216	239	216
query59	3086	3231	3013	3013
query60	306	278	270	270
query61	118	147	112	112
query62	765	743	682	682
query63	229	190	194	190
query64	3749	1035	641	641
query65	3421	3282	3311	3282
query66	735	405	313	313
query67	16399	15761	15522	15522
query68	7819	823	531	531
query69	481	306	262	262
query70	1219	1142	1052	1052
query71	422	296	271	271
query72	5199	2615	3590	2615
query73	645	754	351	351
query74	10329	9482	9258	9258
query75	3910	3142	2708	2708
query76	3524	1194	755	755
query77	769	364	276	276
query78	10284	10424	9633	9633
query79	2124	874	595	595
query80	702	517	426	426
query81	491	258	221	221
query82	230	122	88	88
query83	165	169	145	145
query84	273	106	73	73
query85	728	356	300	300
query86	361	305	282	282
query87	4293	4357	4190	4190
query88	3747	2411	2375	2375
query89	405	336	299	299
query90	1962	187	192	187
query91	131	140	113	113
query92	67	56	52	52
query93	1659	903	539	539
query94	687	415	316	316
query95	342	275	268	268
query96	483	604	278	278
query97	3173	3292	3131	3131
query98	216	214	202	202
query99	1491	1390	1286	1286
Total cold run time: 291724 ms
Total hot run time: 190248 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.41 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6594630725c5de83b31992571985ef434ecfdec0, data reload: false

query1	0.03	0.03	0.02
query2	0.07	0.03	0.03
query3	0.24	0.06	0.07
query4	1.63	0.11	0.11
query5	0.54	0.52	0.52
query6	1.13	0.73	0.73
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.58	0.50	0.50
query10	0.55	0.55	0.55
query11	0.15	0.10	0.10
query12	0.14	0.11	0.11
query13	0.63	0.60	0.60
query14	0.76	0.81	0.82
query15	0.85	0.84	0.83
query16	0.37	0.38	0.38
query17	1.05	1.03	1.05
query18	0.24	0.22	0.21
query19	1.96	1.85	1.87
query20	0.02	0.01	0.01
query21	15.38	0.96	0.58
query22	0.74	0.78	0.62
query23	15.13	1.42	0.59
query24	3.02	1.26	1.49
query25	0.18	0.14	0.16
query26	0.24	0.14	0.15
query27	0.05	0.04	0.04
query28	14.08	0.92	0.43
query29	12.56	3.91	3.32
query30	0.25	0.09	0.08
query31	2.81	0.62	0.38
query32	3.22	0.54	0.45
query33	3.00	2.98	3.06
query34	16.64	5.17	4.56
query35	4.55	4.55	4.55
query36	0.64	0.51	0.49
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.03	0.02
query40	0.17	0.14	0.12
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.04
Total cold run time: 103.99 s
Total hot run time: 29.41 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 0.00% (0/7) 🎉
Increment coverage report
Complete coverage report

@morrySnow morrySnow closed this Aug 9, 2025
@morrySnow morrySnow reopened this Aug 9, 2025
@morrySnow morrySnow merged commit 2e27b81 into apache:branch-3.1 Aug 9, 2025
28 checks passed
@morrySnow morrySnow changed the title branch-3.1 [fix](nereids) fix bug in StatsCalculator.disableJoinReorderIfStatsInvalid when rowCount is not aviable #53834 branch-3.1: [fix](nereids) fix bug in StatsCalculator.disableJoinReorderIfStatsInvalid when rowCount is not aviable #53834 Aug 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants