Skip to content

branch-3.1: [fix](mtmv) Fix aggregate function roll up fail when function is always nullable #52960 #54802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morrySnow merged 2 commits into from
Aug 19, 2025
Merged

branch-3.1: [fix](mtmv) Fix aggregate function roll up fail when function is always nullable #52960 #54802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5228a57
[fix](mtmv) Fix aggregate function roll up fail when function is alwa…
seawinde Aug 13, 2025
456383b
fix code usage
seawinde Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ...pache/doris/nereids/rules/exploration/mv/rollup/ContainDistinctFunctionRollupHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,14 @@ public class ContainDistinctFunctionRollupHandler extends AggFunctionRollUpHandl
public static final ContainDistinctFunctionRollupHandler INSTANCE = new ContainDistinctFunctionRollupHandler();
public static Set<AggregateFunction> SUPPORTED_AGGREGATE_FUNCTION_SET = ImmutableSet.of(
new Max(true, Any.INSTANCE), new Min(true, Any.INSTANCE),
new Max(true, Any.INSTANCE).withAlwaysNullable(true),
new Min(true, Any.INSTANCE).withAlwaysNullable(true),
new Max(false, Any.INSTANCE), new Min(false, Any.INSTANCE),
new Count(true, Any.INSTANCE), new Sum(true, Any.INSTANCE),
new Avg(true, Any.INSTANCE));
new Max(false, Any.INSTANCE).withAlwaysNullable(true),
new Min(false, Any.INSTANCE).withAlwaysNullable(true),
new Count(true, Any.INSTANCE),
new Sum(true, Any.INSTANCE), new Sum(true, Any.INSTANCE).withAlwaysNullable(true),
new Avg(true, Any.INSTANCE), new Avg(true, Any.INSTANCE).withAlwaysNullable(true));

@Override
public boolean canRollup(AggregateFunction queryAggregateFunction,
Expand Down
2 changes: 1 addition & 1 deletion regression-test/data/mv_p0/agg_use_key_direct/agg_use_key_direct.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@
-4

-- !select_avg --
-4
-4.0

2 changes: 1 addition & 1 deletion regression-test/suites/mv_p0/agg_use_key_direct/agg_use_key_direct.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,5 +59,5 @@ suite ("agg_use_key_direct") {
order_qt_select_min """select min(distinct k3) from agg_use_key_direct"""

mv_rewrite_success("""select avg(distinct k3) from agg_use_key_direct""", "common_mv")
order_qt_select_avg """select min(distinct k3) from agg_use_key_direct"""
order_qt_select_avg """select avg(distinct k3) from agg_use_key_direct"""
}
22 changes: 0 additions & 22 deletions regression-test/suites/nereids_rules_p0/mv/agg_variety/agg_variety.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,28 +130,6 @@ suite("agg_variety") {
sql """alter table lineitem modify column l_comment set stats ('row_count'='5');"""
sql """alter table partsupp modify column ps_comment set stats ('row_count'='2');"""

def check_rewrite_but_not_chose = { mv_sql, query_sql, mv_name ->

sql """DROP MATERIALIZED VIEW IF EXISTS ${mv_name}"""
sql"""
CREATE MATERIALIZED VIEW ${mv_name}
BUILD IMMEDIATE REFRESH COMPLETE ON MANUAL
DISTRIBUTED BY RANDOM BUCKETS 2
PROPERTIES ('replication_num' = '1')
AS ${mv_sql}
"""

def job_name = getJobName(db, mv_name);
waitingMTMVTaskFinished(job_name)
explain {
sql("${query_sql}")
check {result ->
def splitResult = result.split("MaterializedViewRewriteFail")
splitResult.length == 2 ? splitResult[0].contains(mv_name) : false
}
}
}

// query dimension is less then mv
def mv1_0 = """
select
Expand Down