[Opt](mow) Opt mow load performance and CPU usage #55073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
bobhan1
force-pushed
the
opt-mow-load-dbm-contains
branch
from
d98c449 to
b9c5284
Compare
Contributor
Author
|
run buildall |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 34339 ms |
TPC-DS: Total hot run time: 185719 ms |
ClickBench: Total hot run time: 32.23 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run buildall |
github-actions
bot
removed
the
approved
TPC-H: Total hot run time: 34071 ms |
TPC-DS: Total hot run time: 184377 ms |
ClickBench: Total hot run time: 33.03 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run p0 |
Contributor
Author
|
run cloud_p0 |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
1 similar comment
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
bobhan1
force-pushed
the
opt-mow-load-dbm-contains
branch
from
f3c83f8 to
2e85851
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34510 ms |
bobhan1
force-pushed
the
opt-mow-load-dbm-contains
branch
from
de65dfb to
5a2c6f2
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34357 ms |
TPC-DS: Total hot run time: 186808 ms |
ClickBench: Total hot run time: 32.85 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
16 tasks
dataroaring
pushed a commit
that referenced
this pull request
Sep 6, 2025
wenzhenghu
pushed a commit
to wenzhenghu/doris
that referenced
this pull request
Sep 8, 2025
### What problem does this PR solve?
This PR let mow load use delete bitmap cache if possible when lookup row
key to reduce CPU usage.
Add 2 configs
`enable_prefill_output_dbm_agg_cache_after_compaction`/`enable_prefill_all_dbm_agg_cache_after_compaction`(default
true) to control whether to fresh delete bitmap cache on corresponding
rowsets after compaction.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
wenzhenghu
pushed a commit
to wenzhenghu/doris
that referenced
this pull request
Sep 8, 2025
bobhan1
added a commit
to bobhan1/doris
that referenced
this pull request
Sep 8, 2025
This PR let mow load use delete bitmap cache if possible when lookup row
key to reduce CPU usage.
Add 2 configs
`enable_prefill_output_dbm_agg_cache_after_compaction`/`enable_prefill_all_dbm_agg_cache_after_compaction`(default
true) to control whether to fresh delete bitmap cache on corresponding
rowsets after compaction.
None
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
bobhan1
added a commit
to bobhan1/doris
that referenced
this pull request
Sep 8, 2025
This was referenced Sep 8, 2025
bobhan1
added a commit
to bobhan1/doris
that referenced
this pull request
Sep 12, 2025
This PR let mow load use delete bitmap cache if possible when lookup row
key to reduce CPU usage.
Add 2 configs
`enable_prefill_output_dbm_agg_cache_after_compaction`/`enable_prefill_all_dbm_agg_cache_after_compaction`(default
true) to control whether to fresh delete bitmap cache on corresponding
rowsets after compaction.
None
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
bobhan1
added a commit
to bobhan1/doris
that referenced
this pull request
Sep 12, 2025
dataroaring
pushed a commit
that referenced
this pull request
Sep 15, 2025
### What problem does this PR solve?
1. fix wrong tablet_id in `DeleteBitmap`
```cpp
Status CloudMetaMgr::get_tablet_meta(int64_t tablet_id, TabletMetaSharedPtr* tablet_meta) {
// ...
*tablet_meta = std::make_shared<TabletMeta>();
(*tablet_meta)
->init_from_pb(cloud_tablet_meta_to_doris(std::move(*resp.mutable_tablet_meta())));
VLOG_DEBUG << "get tablet meta, tablet_id: " << (*tablet_meta)->tablet_id();
// tablet_meta._delete_bitmap._tablet_id is always 0
return Status::OK();
}
TabletMeta::TabletMeta()
: _tablet_uid(0, 0),
_schema(new TabletSchema),
_delete_bitmap(new DeleteBitmap(_tablet_id)) {}
```
2. fix #55073,
#55733 case stuck due to not sending
reply
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR let mow load use delete bitmap cache if possible when lookup row key to reduce CPU usage.
Add 2 configs
enable_prefill_output_dbm_agg_cache_after_compaction/enable_prefill_all_dbm_agg_cache_after_compaction(default true) to control whether to fresh delete bitmap cache on corresponding rowsets after compaction.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)