[Colocate plan][Step1] Colocate join covers more situations#5521
Merged
morningman merged 6 commits intoapache:masterfrom Apr 11, 2021
Merged
[Colocate plan][Step1] Colocate join covers more situations#5521morningman merged 6 commits intoapache:masterfrom
morningman merged 6 commits intoapache:masterfrom
Conversation
HappenLee
reviewed
Mar 18, 2021
fe/fe-core/src/main/java/org/apache/doris/planner/PlanNode.java
Outdated
Show resolved
Hide resolved
Contributor
Author
The order of import should comply with http://doris.apache.org/master/zh-CN/developer-guide/fe-eclipse-dev.html#%E4%BB%A3%E7%A0%81%E6%9B%B4%E6%96%B0 |
Contributor
Author
changed |
Contributor
Author
removed |
morningman
reviewed
Mar 25, 2021
| Collections.shuffle(list); | ||
| backends.add(list.get(0)); | ||
| if (FeConstants.runningUnitTest) { | ||
| backends.addAll(list); |
Contributor
Author
There was a problem hiding this comment.
If it is a test, add all the backends belonging to this ip.
| @VariableMgr.VarAttr(name = DISABLE_COLOCATE_JOIN) | ||
| public boolean disableColocateJoin = false; | ||
| @VariableMgr.VarAttr(name = DISABLE_COLOCATE_PLAN) | ||
| public boolean disableColocatePlan = false; |
Contributor
Author
There was a problem hiding this comment.
Because the previous configuration name is colocate join. It only controls the colocate of the join.
Now this new configuration uniformly controls the colocate of all plan node.
So it would be too one-sided to call colocate join.
morningman
reviewed
Apr 7, 2021
fe/fe-core/src/main/java/org/apache/doris/planner/DistributedPlanner.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/planner/DistributedPlanner.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/planner/DistributedPlanner.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/planner/DistributedPlanner.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/planner/DistributedPlanner.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/planner/DistributedPlanner.java
Outdated
Show resolved
Hide resolved
The old colocate join can only cover the case where the child is hash or scan. In fact, as long as the child's data distribution meets the requirements, no matter what the plan node on the child node is, a colocate join can be performed.
EmmyMiao87
added a commit
to EmmyMiao87/incubator-doris
that referenced
this pull request
May 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
There are 4 steps in colocate plan: join, agg, sort and set operation.
This is the first step.
The old colocate join can only cover the case where the child is hash or scan.
In fact, as long as the child's data distribution meets the requirements,
no matter what the plan node on the child node is, a colocate join can be performed.
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
document is comming