Skip to content

support unescape some invisible char in separator#5524

Merged
morningman merged 1 commit intoapache:masterfrom
yangzhg:escape_seperator
Mar 21, 2021
Merged

support unescape some invisible char in separator#5524
morningman merged 1 commit intoapache:masterfrom
yangzhg:escape_seperator

Conversation

@yangzhg
Copy link
Member

@yangzhg yangzhg commented Mar 16, 2021

Change-Id: Icc920559d97611689bac357813a8c06c6664048d
(cherry picked from commit 9a730c2)
[interna] [doris-1079] support unescape some invisible char in separator

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If these changes need document changes, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Change-Id: Icc920559d97611689bac357813a8c06c6664048d
(cherry picked from commit 9a730c2)
@yangzhg yangzhg changed the title [interna] [doris-1079] support unescape some invisible char in separator support unescape some invisible char in separator Mar 17, 2021
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman self-assigned this Mar 17, 2021
@morningman morningman added approved Indicates a PR has been approved by one committer. kind/improvement labels Mar 17, 2021
@morningman morningman merged commit 6d27ae5 into apache:master Mar 21, 2021
@yangzhg yangzhg deleted the escape_seperator branch March 25, 2021 10:36
@morningman morningman mentioned this pull request Oct 10, 2021
Hastyshell pushed a commit to Hastyshell/doris that referenced this pull request Dec 29, 2025
…n when verify_fail_if_no_peer_cert is not specified (apache#5524)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. kind/improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants