Skip to content

[opt](compatibility) let version mutable #55335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Aug 29, 2025
Merged

[opt](compatibility) let version mutable #55335

morrySnow merged 1 commit into from
Aug 29, 2025

Conversation

@morrySnow
Copy link
Contributor

@morrySnow morrySnow commented Aug 27, 2025 •
edited
Loading

What problem does this PR solve?

Problem Summary:

For some BI tools and data development tools, they send different requests depending on the MySQL version. This PR makes the version configurable, enhancing compatibility with various BI tools by allowing the setting of different server version numbers.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 27, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morrySnow
Copy link
Contributor Author

morrySnow commented Aug 27, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Aug 27, 2025

TPC-H: Total hot run time: 34192 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9e08ef8354b2a2092f6e4ba6d616829ae6a4185e, data reload: false

------ Round 1 ----------------------------------
q1	17617	5237	5060	5060
q2	2028	313	237	237
q3	10219	1307	727	727
q4	10255	1022	533	533
q5	7526	2417	2334	2334
q6	186	176	139	139
q7	918	770	643	643
q8	9361	1339	1145	1145
q9	6891	5313	5192	5192
q10	6984	2354	1992	1992
q11	477	313	290	290
q12	352	358	228	228
q13	17781	3622	2999	2999
q14	233	235	215	215
q15	554	511	501	501
q16	447	434	382	382
q17	595	862	367	367
q18	7488	7247	7032	7032
q19	1221	967	560	560
q20	371	346	233	233
q21	3869	2561	2380	2380
q22	1079	1033	1003	1003
Total cold run time: 106452 ms
Total hot run time: 34192 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5098	5137	5071	5071
q2	257	326	227	227
q3	2150	2694	2298	2298
q4	1376	1846	1375	1375
q5	4207	4363	4638	4363
q6	225	182	134	134
q7	2069	2009	1811	1811
q8	2691	2612	2690	2612
q9	7541	7360	7196	7196
q10	3143	3275	2871	2871
q11	569	502	497	497
q12	697	801	659	659
q13	3583	3914	3346	3346
q14	312	304	281	281
q15	522	497	506	497
q16	463	515	461	461
q17	1238	1601	1356	1356
q18	8222	7677	7596	7596
q19	840	873	999	873
q20	2005	2042	1882	1882
q21	5033	4529	4407	4407
q22	1051	1050	1008	1008
Total cold run time: 53292 ms
Total hot run time: 50821 ms

@doris-robot
Copy link

doris-robot commented Aug 27, 2025

TPC-DS: Total hot run time: 187299 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9e08ef8354b2a2092f6e4ba6d616829ae6a4185e, data reload: false

query1	1051	448	421	421
query2	6591	1817	1797	1797
query3	6749	237	226	226
query4	26515	23813	23027	23027
query5	4941	640	527	527
query6	356	242	212	212
query7	4636	521	302	302
query8	296	261	249	249
query9	8603	2923	2891	2891
query10	530	363	294	294
query11	15821	15027	14812	14812
query12	174	122	117	117
query13	1670	553	442	442
query14	9023	5919	5912	5912
query15	219	188	174	174
query16	7301	637	502	502
query17	1208	776	663	663
query18	2018	428	334	334
query19	208	198	181	181
query20	131	136	129	129
query21	225	129	115	115
query22	4172	4182	4199	4182
query23	34161	32948	32900	32900
query24	8157	2410	2449	2410
query25	596	512	444	444
query26	1236	280	176	176
query27	2705	507	358	358
query28	4332	2300	2256	2256
query29	814	632	494	494
query30	293	230	206	206
query31	898	812	740	740
query32	92	85	82	82
query33	593	420	359	359
query34	839	837	534	534
query35	830	837	761	761
query36	970	1021	920	920
query37	126	110	93	93
query38	4107	4045	3983	3983
query39	1515	1608	1437	1437
query40	228	135	130	130
query41	70	66	64	64
query42	129	117	127	117
query43	561	537	481	481
query44	1354	876	879	876
query45	186	178	179	178
query46	865	1027	664	664
query47	1748	1829	1757	1757
query48	405	422	337	337
query49	747	514	428	428
query50	645	691	405	405
query51	4105	4113	4254	4113
query52	119	112	109	109
query53	247	295	200	200
query54	619	613	542	542
query55	102	96	100	96
query56	328	346	338	338
query57	1201	1205	1121	1121
query58	289	280	282	280
query59	2629	2688	2638	2638
query60	364	358	358	358
query61	169	154	170	154
query62	826	749	687	687
query63	247	206	203	203
query64	4504	1255	965	965
query65	4280	4218	4242	4218
query66	1202	467	365	365
query67	15741	15110	15126	15110
query68	7935	943	618	618
query69	514	349	307	307
query70	1222	1138	1149	1138
query71	459	362	328	328
query72	6002	4899	4843	4843
query73	629	571	362	362
query74	9213	9147	8976	8976
query75	3438	3134	2656	2656
query76	3454	1148	760	760
query77	682	411	346	346
query78	9707	9707	8880	8880
query79	3013	814	611	611
query80	730	594	519	519
query81	512	260	227	227
query82	453	141	120	120
query83	263	273	256	256
query84	263	117	94	94
query85	932	455	420	420
query86	394	314	310	310
query87	4180	4233	4197	4197
query88	3885	2288	2262	2262
query89	403	321	300	300
query90	1923	231	236	231
query91	164	165	136	136
query92	90	74	75	74
query93	2379	968	642	642
query94	747	425	331	331
query95	428	338	338	338
query96	493	571	288	288
query97	2624	2724	2591	2591
query98	257	221	219	219
query99	1457	1382	1323	1323
Total cold run time: 277457 ms
Total hot run time: 187299 ms

@doris-robot
Copy link

doris-robot commented Aug 27, 2025

ClickBench: Total hot run time: 32.53 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9e08ef8354b2a2092f6e4ba6d616829ae6a4185e, data reload: false

query1	0.06	0.05	0.05
query2	0.10	0.05	0.04
query3	0.25	0.09	0.08
query4	1.61	0.12	0.12
query5	0.45	0.42	0.42
query6	1.18	0.64	0.66
query7	0.04	0.03	0.03
query8	0.05	0.04	0.05
query9	0.60	0.53	0.52
query10	0.58	0.58	0.58
query11	0.16	0.11	0.12
query12	0.15	0.12	0.12
query13	0.63	0.62	0.61
query14	0.80	0.83	0.84
query15	0.87	0.86	0.86
query16	0.40	0.40	0.39
query17	1.05	1.07	1.02
query18	0.21	0.20	0.20
query19	1.95	1.85	1.89
query20	0.02	0.01	0.02
query21	15.46	0.96	0.58
query22	0.80	1.25	0.92
query23	14.70	1.42	0.64
query24	6.70	0.92	0.40
query25	0.46	0.14	0.13
query26	0.60	0.17	0.14
query27	0.09	0.05	0.08
query28	9.28	0.93	0.42
query29	12.59	3.95	3.22
query30	3.17	3.12	3.02
query31	2.83	0.60	0.38
query32	3.23	0.56	0.46
query33	3.00	3.14	3.07
query34	15.96	5.53	4.84
query35	4.92	4.88	4.89
query36	0.72	0.50	0.50
query37	0.09	0.07	0.08
query38	0.06	0.05	0.04
query39	0.04	0.03	0.02
query40	0.19	0.16	0.15
query41	0.08	0.03	0.02
query42	0.04	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 106.21 s
Total hot run time: 32.53 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 27, 2025

FE UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉
Increment coverage report
Complete coverage report

@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Aug 29, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2025

PR approved by anyone and no changes requested.

aytrack
aytrack approved these changes Aug 29, 2025
View reviewed changes
Copy link

@aytrack aytrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morrySnow morrySnow merged commit f1fc1d6 into apache:master Aug 29, 2025
28 of 30 checks passed
@morrySnow morrySnow deleted the let_version_mutable branch August 29, 2025 03:26
morrySnow added a commit that referenced this pull request Sep 29, 2025
@morrySnow
branch-3.1: [opt](compatibility) let version mutable #55335
a7f14cb 
picked from #55335
@morrySnow morrySnow mentioned this pull request Sep 29, 2025
Merged
morrySnow added a commit that referenced this pull request Oct 11, 2025
@morrySnow
branch-3.1: [opt](compatibility) let version mutable #55335 (#56630)
c732673 
picked from #55335
Hastyshell pushed a commit to Hastyshell/doris that referenced this pull request Oct 23, 2025
@gavinchou @morrySnow
[opt](compatibility) let version mutable (apache#55335) (apache#5017)
76f0a7e 
For some BI tools and data development tools, they send different
requests depending on the MySQL version. This PR makes the version
configurable, enhancing compatibility with various BI tools by allowing
the setting of different server version numbers.

Co-authored-by: morrySnow <zhangwenxin@selectdb.com>
Hastyshell pushed a commit to Hastyshell/doris that referenced this pull request Nov 12, 2025
@morrySnow
branch-3.0: [opt](compatibility) let version mutable apache#55335 (ap…
60ae9ab 
…ache#4878)

picked from apache#55335
yiguolei pushed a commit to yiguolei/incubator-doris that referenced this pull request Dec 19, 2025
@morrySnow
branch-2.1: [opt](compatibility) let version mutable apache#55335 (ap…
f59617c 
…ache#4879)

picked from apache#55335
w41ter pushed a commit to w41ter/incubator-doris that referenced this pull request Dec 26, 2025
@morrySnow @gavinchou
[opt](compatibility) let version mutable (apache#55335)
49f4500 
### What problem does this PR solve?

Problem Summary:

For some BI tools and data development tools, they send different
requests depending on the MySQL version. This PR makes the version
configurable, enhancing compatibility with various BI tools by allowing
the setting of different server version numbers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

+1 more reviewer

@aytrack aytrack aytrack approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.2-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@morrySnow @hello-stephen @doris-robot @morningman @aytrack