Skip to content

[fix](test) fix unique function test #55377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hello-stephen merged 2 commits into from
Aug 28, 2025
Merged

[fix](test) fix unique function test #55377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fb4a84
fix fe ut
yujun777 Aug 27, 2025
ca7a055
fix test
yujun777 Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .../java/org/apache/doris/nereids/trees/expressions/functions/scalar/UniqueFunctionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,8 @@ void testNoAggregate2() {
Map<ExprId, Expression> exprIdToOriginExprMap = getExprIdToOriginExpressionMap(root);

LogicalProject<?> project = (LogicalProject<?>) root.child(0);
Assertions.assertEquals(ImmutableList.of("a + random()", "a + random()",
Assertions.assertEquals(ImmutableList.of("(a + random()) AS `a + random()`",
"(a + random()) AS `a + random()`",
"sum(a + random()) over(partition by a + random())", "sum(a + random()) over(partition by a + random())"),
toSqls(project.getProjects()));
checkOutputDifferent(project, expressionSet, exprIdToOriginExprMap);
Expand Down Expand Up @@ -811,7 +812,8 @@ void testAggregateWithGroupBy5() {

LogicalProject<?> project = (LogicalProject<?>) root.child(0);
Assertions.assertEquals(ImmutableList.of("a + random()", "a + random() + 1", "a + random() + 2",
"sum(a + random())", "sum(a + random() + 1)", "sum(a + random() + 2)",
"sum(a + random()) AS `sum(a + random())`", "sum(a + random() + 1) AS `sum(a + random() + 1)`",
"sum((a + random() + cast(2 as DOUBLE))) AS `sum(a + random() + 2)`",
"sum(a + random()) over()", "sum(a + random() + 1) over()", "sum(a + random() + 2) over()"),
toSqls(project.getProjects()));
Lists.transform(ImmutableList.of(0, 2, 3, 5, 6, 8), project.getProjects()::get).forEach(random0EqualValidator::checkRandomEqual);
Expand Down
53 changes: 25 additions & 28 deletions regression-test/data/nereids_rules_p0/unique_function/agg_with_unique_function.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,38 +16,38 @@ PhysicalResultSink

-- !check_equal_no_agg_4_shape --
PhysicalResultSink
--PhysicalProject[a + random(), a + random(), sum(a + random()) over() AS `sum(a + random()) over()`, sum(a + random()) over() AS `sum(a + random()) over()`]
--PhysicalProject[(a + random()) AS `a + random()`, (a + random()) AS `a + random()`, sum(a + random()) over() AS `sum(a + random()) over()`, sum(a + random()) over() AS `sum(a + random()) over()`]
----PhysicalWindow
------PhysicalProject[(a + random()) AS `(a + random())`, (a + random()) AS `(a + random())`, (a + random()) AS `a + random()`, (a + random()) AS `a + random()`]
------PhysicalProject[(a + random()) AS `(a + random())`, (a + random()) AS `(a + random())`, tbl_unique_function_with_one_row.a]
--------PhysicalOlapScan[tbl_unique_function_with_one_row]

-- !check_equal_no_agg_5_shape --
PhysicalResultSink
--PhysicalProject[a + random(), a + random()]
--PhysicalProject[(a + random()) AS `a + random()`, (a + random()) AS `a + random()`]
----filter((sum((a + random())) OVER() > 0.01) and (sum((a + random())) OVER(PARTITION BY (a + random())) > 0.01))
------PhysicalWindow
--------PhysicalWindow
----------PhysicalQuickSort[LOCAL_SORT]
------------PhysicalProject[(a + random()) AS `(a + random())`, (a + random()) AS `(a + random())`, (a + random()) AS `(a + random())`, (a + random()) AS `a + random()`, (a + random()) AS `a + random()`]
------------PhysicalProject[(a + random()) AS `(a + random())`, (a + random()) AS `(a + random())`, (a + random()) AS `(a + random())`, tbl_unique_function_with_one_row.a]
--------------PhysicalOlapScan[tbl_unique_function_with_one_row]

-- !check_equal_no_agg_6_shape --
PhysicalResultSink
--PhysicalProject[a + random(), a + random(), sum(a + random()) over (partition by a + random())]
--PhysicalProject[(a + random()) AS `a + random()`, (a + random()) AS `a + random()`, sum(a + random()) over (partition by a + random())]
----filter((sum((a + random())) OVER() > 0.01) and (sum((a + random())) OVER(PARTITION BY (a + random())) > 0.01))
------PhysicalWindow
--------PhysicalWindow
----------PhysicalQuickSort[LOCAL_SORT]
------------PhysicalWindow
--------------PhysicalQuickSort[LOCAL_SORT]
----------------PhysicalProject[(a + random()) AS `(a + random())`, (a + random()) AS `(a + random())`, (a + random()) AS `(a + random())`, (a + random()) AS `(a + random())`, (a + random()) AS `(a + random())`, (a + random()) AS `a + random()`, (a + random()) AS `a + random()`]
----------------PhysicalProject[(a + random()) AS `(a + random())`, (a + random()) AS `(a + random())`, (a + random()) AS `(a + random())`, (a + random()) AS `(a + random())`, (a + random()) AS `(a + random())`, tbl_unique_function_with_one_row.a]
------------------PhysicalOlapScan[tbl_unique_function_with_one_row]

-- !check_equal_one_row_to_agg_1_shape --
PhysicalResultSink
--PhysicalProject[random(), random(), sum(random()), sum(random()), sum(random()) over() AS `sum(random()) over()`, sum(random()) over() AS `sum(random()) over()`]
--PhysicalProject[random() AS `random()`, random() AS `random()`, sum(random()), sum(random()), sum(random()) over() AS `sum(random()) over()`, sum(random()) over() AS `sum(random()) over()`]
----PhysicalWindow
------PhysicalProject[random() AS `random()`, random() AS `random()`, random() AS `random()`, random() AS `random()`, sum(random()), sum(random())]
------PhysicalProject[random() AS `random()`, random() AS `random()`, sum(random()), sum(random())]
--------hashAgg[GLOBAL]
----------hashAgg[LOCAL]
------------PhysicalProject[random() AS `random()`, random() AS `random()`]
Expand Down Expand Up @@ -168,37 +168,34 @@ PhysicalResultSink

-- !check_equal_agg_with_groupby_7_shape --
PhysicalResultSink
--PhysicalProject[a + random(), a + random() AS `a + random()`, sum(a + random()), sum(a + random()) over() AS `sum(a + random()) over()`]
--PhysicalProject[a + random(), a + random() AS `a + random()`, sum(a + random()) AS `sum(a + random())`, sum(a + random()) over() AS `sum(a + random()) over()`]
----PhysicalWindow
------PhysicalProject[a + random() AS `a + random()`, sum(a + random()) AS `sum(a + random())`]
--------hashAgg[GLOBAL]
----------hashAgg[LOCAL]
------------PhysicalProject[(a + random()) AS `a + random()`]
--------------PhysicalOlapScan[tbl_unique_function_with_one_row]
------hashAgg[GLOBAL]
--------hashAgg[LOCAL]
----------PhysicalProject[(a + random()) AS `a + random()`]
------------PhysicalOlapScan[tbl_unique_function_with_one_row]

-- !check_equal_agg_with_groupby_8_shape --
PhysicalResultSink
--PhysicalProject[a + random(), a + random() AS `a + random()`, sum(a + random()), sum(a + random()) over() AS `sum(a + random()) over()`]
--PhysicalProject[a + random(), a + random() AS `a + random()`, sum(a + random()) AS `sum(a + random())`, sum(a + random()) over() AS `sum(a + random()) over()`]
----PhysicalWindow
------PhysicalProject[a + random() AS `a + random()`, sum(a + random()) AS `sum(a + random())`]
--------hashAgg[GLOBAL]
----------hashAgg[LOCAL]
------------filter((a + random() > 0.01))
--------------PhysicalProject[(a + random()) AS `a + random()`]
----------------PhysicalOlapScan[tbl_unique_function_with_one_row]
------hashAgg[GLOBAL]
--------hashAgg[LOCAL]
----------filter((a + random() > 0.01))
------------PhysicalProject[(a + random()) AS `a + random()`]
--------------PhysicalOlapScan[tbl_unique_function_with_one_row]

-- !check_equal_agg_with_groupby_9_shape --
PhysicalResultSink
--PhysicalQuickSort[MERGE_SORT]
----PhysicalQuickSort[LOCAL_SORT]
------PhysicalProject[a + random(), a + random() AS `a + random()`, abs(a + random()), sum(a + random()), sum(a + random()) over() AS `sum(a + random()) over()`]
------PhysicalProject[a + random(), a + random() AS `a + random()`, abs(a + random()) AS `abs(a + random())`, sum(a + random()) AS `sum(a + random())`, sum(a + random()) over() AS `sum(a + random()) over()`]
--------PhysicalWindow
----------PhysicalProject[a + random() AS `a + random()`, abs(a + random()) AS `abs(a + random())`, sum(a + random()) AS `sum(a + random())`]
------------hashAgg[GLOBAL]
--------------hashAgg[LOCAL]
----------------filter((a + random() > 0.01))
------------------PhysicalProject[(a + random()) AS `a + random()`]
--------------------PhysicalOlapScan[tbl_unique_function_with_one_row]
----------hashAgg[GLOBAL]
------------hashAgg[LOCAL]
--------------filter((a + random() > 0.01))
----------------PhysicalProject[(a + random()) AS `a + random()`]
------------------PhysicalOlapScan[tbl_unique_function_with_one_row]

-- !check_equal_agg_with_groupby_10_shape --
PhysicalResultSink
Expand Down