Skip to content

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #51379

### What problem does this PR solve?

Related PR: #42038

Problem Summary: Ldap group filter for OpenDirectory implementation is
not functional, as it fetches everything. This fix filters on "dn"
attribute to fetch group.
@github-actions github-actions bot requested a review from dataroaring as a code owner August 28, 2025 02:48
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Aug 28, 2025
@hello-stephen
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40134 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f62ce3fe31427ff158f59e0dcc8225c4e420a8ae, data reload: false

------ Round 1 ----------------------------------
q1	17789	7160	6635	6635
q2	2034	181	167	167
q3	10666	1167	1118	1118
q4	10558	751	734	734
q5	7727	2895	2863	2863
q6	211	128	128	128
q7	964	601	592	592
q8	9361	1948	2004	1948
q9	6721	6469	6460	6460
q10	7006	2293	2306	2293
q11	456	262	263	262
q12	401	215	217	215
q13	17790	2952	2978	2952
q14	230	203	213	203
q15	526	451	461	451
q16	487	379	377	377
q17	982	583	568	568
q18	7395	6798	6820	6798
q19	1397	1140	1011	1011
q20	478	202	215	202
q21	3939	3221	3153	3153
q22	1134	1017	1004	1004
Total cold run time: 108252 ms
Total hot run time: 40134 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6645	6607	6615	6607
q2	329	228	241	228
q3	2955	2897	2971	2897
q4	2053	1797	1820	1797
q5	5711	5762	5697	5697
q6	209	123	132	123
q7	2229	1760	1796	1760
q8	3414	3553	3633	3553
q9	8719	8884	8856	8856
q10	3584	3539	3560	3539
q11	593	488	483	483
q12	808	599	610	599
q13	8105	3126	3170	3126
q14	295	284	257	257
q15	527	465	461	461
q16	510	453	454	453
q17	1854	1641	1646	1641
q18	8280	7930	7811	7811
q19	1681	1533	1479	1479
q20	2063	1864	1886	1864
q21	5205	5031	5092	5031
q22	1172	1055	1034	1034
Total cold run time: 66941 ms
Total hot run time: 59296 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192357 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f62ce3fe31427ff158f59e0dcc8225c4e420a8ae, data reload: false

query1	945	401	418	401
query2	6290	1948	1848	1848
query3	8684	205	205	205
query4	33983	23811	23323	23323
query5	3552	470	454	454
query6	289	186	185	185
query7	4218	318	324	318
query8	301	224	241	224
query9	9183	2594	2571	2571
query10	491	257	256	256
query11	17994	15189	15189	15189
query12	157	99	101	99
query13	1549	431	426	426
query14	9327	7357	6509	6509
query15	268	174	184	174
query16	8070	505	468	468
query17	1605	652	587	587
query18	2148	327	327	327
query19	388	165	163	163
query20	132	124	115	115
query21	209	108	106	106
query22	4768	4753	4570	4570
query23	35142	34459	34327	34327
query24	11801	2913	2933	2913
query25	684	404	395	395
query26	1813	171	166	166
query27	2829	346	371	346
query28	7530	2177	2176	2176
query29	1048	432	430	430
query30	283	163	165	163
query31	1042	827	837	827
query32	97	53	57	53
query33	773	296	308	296
query34	1000	505	535	505
query35	882	723	718	718
query36	1127	927	943	927
query37	269	71	67	67
query38	4011	4000	3884	3884
query39	1608	1678	1502	1502
query40	260	102	109	102
query41	57	55	52	52
query42	132	105	105	105
query43	529	483	486	483
query44	1253	815	797	797
query45	191	171	176	171
query46	1168	729	725	725
query47	2063	1989	1935	1935
query48	475	408	381	381
query49	1028	399	383	383
query50	828	429	439	429
query51	7453	7350	7203	7203
query52	106	93	95	93
query53	260	188	182	182
query54	1451	472	481	472
query55	83	80	83	80
query56	268	240	247	240
query57	1344	1224	1214	1214
query58	225	204	220	204
query59	3194	3072	3172	3072
query60	291	261	271	261
query61	115	106	106	106
query62	874	687	691	687
query63	228	194	202	194
query64	5067	695	629	629
query65	3390	3324	3322	3322
query66	1314	295	312	295
query67	16399	15641	15589	15589
query68	5007	585	589	585
query69	411	269	266	266
query70	1208	1083	1111	1083
query71	355	263	260	260
query72	6171	4048	4029	4029
query73	756	345	343	343
query74	10623	9184	9253	9184
query75	3364	2636	2637	2636
query76	2603	1090	1039	1039
query77	369	287	273	273
query78	10621	9657	9630	9630
query79	1275	604	593	593
query80	765	426	438	426
query81	496	217	219	217
query82	663	89	87	87
query83	240	150	152	150
query84	235	74	76	74
query85	1108	309	295	295
query86	319	272	270	270
query87	4386	4222	4283	4222
query88	3768	2415	2407	2407
query89	402	290	296	290
query90	2259	182	183	182
query91	186	153	149	149
query92	59	48	51	48
query93	1078	544	558	544
query94	868	309	294	294
query95	362	255	254	254
query96	609	290	287	287
query97	3321	3155	3135	3135
query98	214	230	205	205
query99	1509	1334	1281	1281
Total cold run time: 302146 ms
Total hot run time: 192357 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.59 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f62ce3fe31427ff158f59e0dcc8225c4e420a8ae, data reload: false

query1	0.04	0.03	0.03
query2	0.06	0.03	0.03
query3	0.23	0.07	0.06
query4	1.63	0.10	0.10
query5	0.54	0.51	0.53
query6	1.13	0.73	0.73
query7	0.02	0.01	0.02
query8	0.05	0.03	0.04
query9	0.57	0.54	0.50
query10	0.55	0.55	0.55
query11	0.15	0.11	0.10
query12	0.14	0.12	0.11
query13	0.62	0.58	0.60
query14	0.75	0.86	0.79
query15	0.84	0.82	0.83
query16	0.38	0.38	0.39
query17	1.05	1.06	0.99
query18	0.24	0.23	0.21
query19	1.92	1.82	1.87
query20	0.02	0.01	0.01
query21	15.40	0.59	0.58
query22	2.24	2.36	1.65
query23	17.05	1.03	0.76
query24	3.27	1.54	2.07
query25	0.23	0.06	0.24
query26	0.43	0.14	0.14
query27	0.06	0.05	0.04
query28	9.00	0.55	0.48
query29	12.56	3.24	3.25
query30	0.26	0.06	0.06
query31	2.87	0.38	0.39
query32	3.23	0.46	0.45
query33	2.99	3.00	3.07
query34	17.15	4.54	4.54
query35	4.66	4.54	4.59
query36	0.65	0.47	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.04	0.02	0.02
query40	0.17	0.13	0.12
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 103.48 s
Total hot run time: 30.59 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit a50a51e into branch-3.0 Sep 5, 2025
25 of 26 checks passed
@github-actions github-actions bot deleted the auto-pick-51379-branch-3.0 branch September 5, 2025 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants