-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](function) auto_partition_name make BE crashed while use legacy planner #55464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
Does |
lide-reed
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
xy720
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
只在旧优化器有问题,3.0不会fallback了,所以没有问题。 |
What problem does this PR solve?
Problem:
Incorrect input arguments for auto_partition_name cause a fallback to the legacy planner in branch 2.1. However, since this function is handled by the FE legacy code, there is no parameter checking logic. (See: #38853)
Furthermore, there is a lack of sufficient checks on the BE side, which can lead to crashes. Such as:
How to Fix:
So here we simply remove function
auto_partition_namein legacy plannerThe stack is like:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)