[Colocate plan][Step2] Colocate aggregation covers more situations#5555
Merged
morningman merged 3 commits intoapache:masterfrom May 22, 2021
Merged
[Colocate plan][Step2] Colocate aggregation covers more situations#5555morningman merged 3 commits intoapache:masterfrom
morningman merged 3 commits intoapache:masterfrom
Conversation
EmmyMiao87
added
kind/improvement
area/planner
EmmyMiao87
force-pushed
the
colocate_agg
branch
5 times, most recently
from
8144375 to
7486619
Compare
The old colocate join can only cover the case where the child is hash or scan. In fact, as long as the child's data distribution meets the requirements, no matter what the plan node on the child node is, a colocate join can be performed.
The old colocate aggregation can only cover the case where the child is scan. In fact, as long as the child's data distribution meets the requirements, no matter what the plan node on the child node is, a colocate aggregation can be performed. This PR also fixes the correct data partition attribute of fragment. The data partition of fragment which contains scan node is Hash Partition rather than Random. This modification is mainly to determine the possibility of colocate through the correct distribution of child fragments.
EmmyMiao87
force-pushed
the
colocate_agg
branch
from
7486619 to
5d161a9
Compare
morningman
reviewed
Apr 22, 2021
| * 1. Session variables disable_colocate_plan = false | ||
| ======= | ||
| * 1. Session variables disable_colocate_plan = true | ||
| >>>>>>> 26f4e1fa8 ([Colocate plan][Step1] Colocate join covers more situations) |
|
|
||
| /** | ||
| * Colocate Agg can be performed when the following 2 conditions are met at the same time. | ||
| * 1. Session variables disable_colocate_plan = true |
Contributor
There was a problem hiding this comment.
disable_colocate_plan=false?
| private boolean canColocateAgg(AggregateInfo aggregateInfo, List<DataPartition> childFragmentDataPartition) { | ||
| // Condition1 | ||
| if (ConnectContext.get().getSessionVariable().isDisableColocatePlan()) { | ||
| LOG.info("Agg node is not colocate in:" + ConnectContext.get().getQueryDetail().getQueryId() |
stdpain
pushed a commit
to stdpain/incubator-doris
that referenced
this pull request
Jul 8, 2021
…pache#5555) The old colocate aggregation can only cover the case where the child is scan. In fact, as long as the child's data distribution meets the requirements, no matter what the plan node on the child node is, a colocate aggregation can be performed. This PR also fixes the correct data partition attribute of fragment. The data partition of fragment which contains scan node is Hash Partition rather than Random. This modification is mainly to determine the possibility of colocate through the correct distribution of child fragments. Change-Id: I6ac76aa331dfa5966a4a84143c9983bc1d55c808
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
[Colocate plan][Step2] Colocate aggregation covers more situations
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
unit test is coming.