Skip to content

branch-3.1: [opt](recycler) Avoid doing many Aws::Internal::GetEC2MetadataClient http call #55546 #55682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Sep 5, 2025
Merged

branch-3.1: [opt](recycler) Avoid doing many Aws::Internal::GetEC2MetadataClient http call #55546 #55682

morrySnow merged 1 commit into from
Sep 5, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Sep 4, 2025

Cherry-picked from #55546

@swjtu-zhanglei
[opt](recycler) Avoid doing many `Aws::Internal::GetEC2MetadataClient…
03c2176 
…` http call (#55546)

* The default constructor of ClientConfiguration will do some http call
such as Aws::Internal::GetEC2MetadataClient and other init operation,
which is unnecessary.So here we use a static instance, and deep cpy
every time to avoid unnecessary operations.
@github-actions github-actions bot requested a review from morrySnow as a code owner September 4, 2025 10:12
@Thearas
Copy link
Contributor

Thearas commented Sep 4, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Sep 4, 2025
@dataroaring dataroaring reopened this Sep 4, 2025
@Thearas
Copy link
Contributor

Thearas commented Sep 4, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Sep 4, 2025

Cloud UT Coverage Report

Increment line coverage 71.43% (5/7) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 82.03% (1219/1486)
Line Coverage 65.91% (21813/33094)
Region Coverage 67.44% (10975/16274)
Branch Coverage 57.03% (5794/10160)

@morrySnow morrySnow merged commit d1cbff1 into branch-3.1 Sep 5, 2025
24 checks passed
@github-actions github-actions bot deleted the auto-pick-55546-branch-3.1 branch September 5, 2025 10:23
@morrySnow morrySnow mentioned this pull request Sep 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Thearas @doris-robot @morrySnow @dataroaring @swjtu-zhanglei