Skip to content

[refacor] Remove minizip source code #5571

Merged
yangzhg merged 2 commits intoapache:masterfrom
yangzhg:remove_minizip
Apr 8, 2021
Merged

[refacor] Remove minizip source code #5571
yangzhg merged 2 commits intoapache:masterfrom
yangzhg:remove_minizip

Conversation

@yangzhg
Copy link
Member

@yangzhg yangzhg commented Mar 25, 2021

Proposed changes

Remove minizip source code to thirdyparty, since the minizip is already exists in zlib

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If these changes need document changes, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman self-assigned this Apr 7, 2021
@morningman morningman added approved Indicates a PR has been approved by one committer. area/dependency Issues or PRs related to Doris dependencies labels Apr 7, 2021
@yangzhg yangzhg merged commit 5a0a039 into apache:master Apr 8, 2021
@yangzhg yangzhg deleted the remove_minizip branch April 12, 2021 02:52
EmmyMiao87 pushed a commit to EmmyMiao87/incubator-doris that referenced this pull request May 14, 2021
Hastyshell pushed a commit to Hastyshell/doris that referenced this pull request Nov 12, 2025
apache#57696 (apache#5617)

cherry-picks from apache#57696
Related to apache#5571

Co-authored-by: lw112 <131352377+felixwluo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/dependency Issues or PRs related to Doris dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants