Skip to content

Conversation

@deardeng
Copy link
Contributor

What problem does this PR solve?

When setting up a default cluster on the current cloud, it will check whether the user has cluster permissions. However, this check only checks the entire domain. If you create a user using a partial domain, setting up the default cluster will result in an error. Fix it.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Sep 14, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@deardeng
Copy link
Contributor Author

run buildall

gavinchou
gavinchou previously approved these changes Sep 14, 2025
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 14, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 34452 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b29c51d79af2b22d47f4548a820345df7c1b11b3, data reload: false

------ Round 1 ----------------------------------
q1	17610	5229	5068	5068
q2	1973	326	216	216
q3	10245	1300	700	700
q4	10224	1022	534	534
q5	7562	2393	2326	2326
q6	185	168	135	135
q7	914	779	633	633
q8	9337	1319	1045	1045
q9	6940	5156	5114	5114
q10	6936	2383	1968	1968
q11	475	315	276	276
q12	350	359	228	228
q13	17794	3619	3001	3001
q14	231	246	217	217
q15	578	493	488	488
q16	994	1005	951	951
q17	610	835	361	361
q18	7967	7057	7118	7057
q19	1518	961	567	567
q20	339	336	225	225
q21	3664	3143	2365	2365
q22	1062	1044	977	977
Total cold run time: 107508 ms
Total hot run time: 34452 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5206	5113	5086	5086
q2	246	333	226	226
q3	2187	2672	2365	2365
q4	1368	1796	1324	1324
q5	4222	4464	4544	4464
q6	217	170	131	131
q7	2059	2003	1808	1808
q8	2611	2627	2535	2535
q9	7459	7180	7419	7180
q10	3057	3299	2877	2877
q11	592	547	509	509
q12	875	792	629	629
q13	3392	3862	3350	3350
q14	283	303	291	291
q15	527	480	489	480
q16	1047	1113	1076	1076
q17	1168	1550	1423	1423
q18	8112	7772	7588	7588
q19	822	796	908	796
q20	2003	2057	1908	1908
q21	4752	4271	4140	4140
q22	1117	1067	1006	1006
Total cold run time: 53322 ms
Total hot run time: 51192 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 188830 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b29c51d79af2b22d47f4548a820345df7c1b11b3, data reload: false

query1	1055	457	405	405
query2	6583	1674	1686	1674
query3	6758	221	215	215
query4	25845	23459	23388	23388
query5	4362	613	471	471
query6	356	255	226	226
query7	4661	522	305	305
query8	306	269	256	256
query9	8641	2649	2674	2649
query10	498	328	292	292
query11	15570	15353	14977	14977
query12	175	119	112	112
query13	1690	577	444	444
query14	11210	9179	9140	9140
query15	215	196	177	177
query16	7711	686	512	512
query17	1663	828	617	617
query18	2033	437	332	332
query19	198	200	171	171
query20	143	122	122	122
query21	212	130	117	117
query22	4015	4093	4183	4093
query23	34233	32961	33116	32961
query24	8476	2426	2435	2426
query25	569	529	429	429
query26	1241	280	159	159
query27	2712	520	358	358
query28	4320	2227	2198	2198
query29	773	619	481	481
query30	293	254	198	198
query31	940	807	725	725
query32	81	70	72	70
query33	586	383	329	329
query34	796	877	511	511
query35	826	830	736	736
query36	977	1022	927	927
query37	119	109	84	84
query38	3525	3518	3515	3515
query39	1479	1463	1415	1415
query40	222	131	122	122
query41	80	61	62	61
query42	123	113	119	113
query43	502	512	476	476
query44	1314	845	827	827
query45	183	186	170	170
query46	846	1023	658	658
query47	1780	1819	1754	1754
query48	395	419	312	312
query49	777	506	406	406
query50	651	691	405	405
query51	3860	3960	3892	3892
query52	113	111	106	106
query53	239	262	200	200
query54	588	578	524	524
query55	91	86	85	85
query56	316	317	304	304
query57	1189	1184	1126	1126
query58	277	269	269	269
query59	2528	2651	2562	2562
query60	361	340	331	331
query61	184	191	165	165
query62	868	760	677	677
query63	225	194	196	194
query64	4441	1153	836	836
query65	4057	3995	3974	3974
query66	1092	437	330	330
query67	15326	15256	15092	15092
query68	8275	917	584	584
query69	475	317	289	289
query70	1419	1290	1361	1290
query71	566	356	342	342
query72	5989	4983	5043	4983
query73	697	593	361	361
query74	8928	9097	8778	8778
query75	4007	3369	2792	2792
query76	3755	1174	768	768
query77	812	407	307	307
query78	9570	9719	8964	8964
query79	2192	810	593	593
query80	637	559	505	505
query81	487	332	233	233
query82	459	167	135	135
query83	264	269	253	253
query84	261	116	103	103
query85	924	469	428	428
query86	400	329	317	317
query87	3772	3766	3637	3637
query88	3580	2237	2239	2237
query89	406	344	295	295
query90	1845	218	222	218
query91	169	172	148	148
query92	85	66	60	60
query93	1710	1002	659	659
query94	705	457	334	334
query95	404	321	308	308
query96	493	557	284	284
query97	2911	3015	2892	2892
query98	238	217	212	212
query99	1357	1400	1333	1333
Total cold run time: 276266 ms
Total hot run time: 188830 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.89 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b29c51d79af2b22d47f4548a820345df7c1b11b3, data reload: false

query1	0.06	0.05	0.05
query2	0.10	0.05	0.05
query3	0.25	0.08	0.09
query4	1.61	0.11	0.12
query5	0.28	0.27	0.26
query6	1.19	0.67	0.66
query7	0.04	0.03	0.03
query8	0.06	0.04	0.04
query9	0.61	0.53	0.52
query10	0.59	0.58	0.58
query11	0.16	0.11	0.12
query12	0.15	0.12	0.12
query13	0.62	0.63	0.62
query14	1.05	1.05	1.04
query15	0.85	0.85	0.87
query16	0.40	0.40	0.40
query17	1.07	1.05	1.07
query18	0.22	0.20	0.20
query19	1.91	1.83	1.83
query20	0.02	0.02	0.01
query21	15.42	0.98	0.61
query22	0.77	1.18	0.72
query23	14.88	1.38	0.64
query24	6.68	2.34	0.49
query25	0.44	0.18	0.20
query26	0.63	0.16	0.13
query27	0.06	0.06	0.06
query28	9.71	0.85	0.44
query29	12.54	3.87	3.27
query30	0.28	0.13	0.11
query31	2.84	0.59	0.40
query32	3.26	0.56	0.49
query33	3.14	3.04	3.06
query34	16.05	5.49	4.93
query35	4.98	4.89	4.94
query36	0.72	0.53	0.52
query37	0.12	0.07	0.07
query38	0.06	0.04	0.04
query39	0.04	0.02	0.03
query40	0.18	0.14	0.14
query41	0.09	0.03	0.03
query42	0.04	0.04	0.03
query43	0.05	0.04	0.03
Total cold run time: 104.22 s
Total hot run time: 29.89 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 0.00% (0/10) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 80.00% (8/10) 🎉
Increment coverage report
Complete coverage report

@deardeng
Copy link
Contributor Author

run nonConcurrent

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 80.00% (8/10) 🎉
Increment coverage report
Complete coverage report

@deardeng
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Sep 29, 2025
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-DS: Total hot run time: 190952 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 76c7a027ee73c9d4e1f9910159c6c1f22266d0a3, data reload: false

query1	1060	427	408	408
query2	6577	1752	1685	1685
query3	6748	227	217	217
query4	26225	23671	23807	23671
query5	5123	661	502	502
query6	341	267	238	238
query7	4665	498	292	292
query8	313	272	280	272
query9	8704	2555	2583	2555
query10	525	330	296	296
query11	15238	15191	14874	14874
query12	183	120	114	114
query13	1673	581	429	429
query14	11379	9336	9478	9336
query15	218	199	176	176
query16	7685	669	512	512
query17	1619	817	665	665
query18	2093	552	353	353
query19	238	206	208	206
query20	141	133	138	133
query21	217	136	127	127
query22	4571	4749	4646	4646
query23	35084	33992	33913	33913
query24	8755	2502	2564	2502
query25	596	550	499	499
query26	2362	297	160	160
query27	3195	544	398	398
query28	4496	2223	2254	2223
query29	854	605	484	484
query30	302	237	210	210
query31	961	792	781	781
query32	105	83	78	78
query33	618	411	323	323
query34	989	888	552	552
query35	837	895	779	779
query36	1038	1073	952	952
query37	127	105	83	83
query38	3499	3555	3466	3466
query39	1475	1461	1441	1441
query40	218	126	118	118
query41	59	59	64	59
query42	122	113	114	113
query43	504	510	458	458
query44	1377	842	827	827
query45	185	179	172	172
query46	845	1005	638	638
query47	1782	1838	1730	1730
query48	423	426	317	317
query49	776	517	416	416
query50	659	680	406	406
query51	3926	3995	3919	3919
query52	108	112	102	102
query53	241	300	205	205
query54	596	587	538	538
query55	90	84	83	83
query56	309	314	310	310
query57	1179	1207	1125	1125
query58	286	292	274	274
query59	2642	2595	2535	2535
query60	359	338	329	329
query61	155	150	149	149
query62	796	732	675	675
query63	227	199	199	199
query64	4468	1156	820	820
query65	4102	3971	4000	3971
query66	1080	439	338	338
query67	15299	15430	15147	15147
query68	8150	890	608	608
query69	506	368	299	299
query70	1395	1316	1338	1316
query71	518	339	322	322
query72	6035	4848	4999	4848
query73	663	576	374	374
query74	8886	8956	8720	8720
query75	4033	3368	2809	2809
query76	3658	1162	742	742
query77	816	406	323	323
query78	9669	9793	9021	9021
query79	2935	830	577	577
query80	702	581	512	512
query81	493	262	226	226
query82	455	159	133	133
query83	283	279	240	240
query84	297	115	94	94
query85	938	481	415	415
query86	357	333	303	303
query87	3811	3859	3670	3670
query88	3694	2221	2194	2194
query89	414	327	296	296
query90	2084	217	219	217
query91	186	166	131	131
query92	81	67	72	67
query93	2008	981	643	643
query94	698	456	331	331
query95	398	323	316	316
query96	486	567	282	282
query97	2960	3048	2871	2871
query98	238	217	210	210
query99	1425	1426	1318	1318
Total cold run time: 282914 ms
Total hot run time: 190952 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.17 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 76c7a027ee73c9d4e1f9910159c6c1f22266d0a3, data reload: false

query1	0.05	0.05	0.05
query2	0.09	0.05	0.06
query3	0.25	0.08	0.08
query4	1.60	0.12	0.12
query5	0.27	0.26	0.25
query6	1.17	0.66	0.66
query7	0.04	0.02	0.02
query8	0.05	0.04	0.04
query9	0.62	0.53	0.51
query10	0.59	0.58	0.56
query11	0.17	0.13	0.11
query12	0.15	0.12	0.12
query13	0.63	0.62	0.62
query14	1.03	1.03	1.04
query15	0.87	0.87	0.85
query16	0.41	0.39	0.40
query17	1.05	1.08	1.06
query18	0.21	0.20	0.20
query19	1.95	1.85	1.86
query20	0.02	0.02	0.01
query21	15.41	0.94	0.57
query22	0.75	1.23	0.72
query23	14.85	1.38	0.67
query24	7.70	1.22	0.44
query25	0.42	0.15	0.07
query26	0.67	0.16	0.14
query27	0.07	0.06	0.06
query28	8.79	1.33	0.93
query29	12.56	3.97	3.25
query30	0.30	0.13	0.11
query31	2.85	0.60	0.40
query32	3.25	0.56	0.49
query33	3.10	3.13	3.06
query34	16.10	5.49	4.88
query35	4.87	4.95	4.93
query36	0.69	0.51	0.50
query37	0.10	0.07	0.07
query38	0.07	0.05	0.04
query39	0.04	0.03	0.03
query40	0.19	0.15	0.14
query41	0.08	0.03	0.03
query42	0.03	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 104.15 s
Total hot run time: 30.17 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 0.00% (0/10) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 80.00% (8/10) 🎉
Increment coverage report
Complete coverage report

@gavinchou gavinchou merged commit 9ef11f0 into apache:master Sep 29, 2025
27 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 29, 2025
When setting up a default cluster on the current cloud, it will check
whether the user has cluster permissions. However, this check only
checks the entire domain. If you create a user using a partial domain,
setting up the default cluster will result in an error. Fix it.
yiguolei pushed a commit that referenced this pull request Sep 30, 2025
#56032 (#56644)

Cherry-picked from #56032

Co-authored-by: deardeng <dengxin@selectdb.com>
deardeng added a commit to deardeng/incubator-doris that referenced this pull request Oct 31, 2025
…6032)

When setting up a default cluster on the current cloud, it will check
whether the user has cluster permissions. However, this check only
checks the entire domain. If you create a user using a partial domain,
setting up the default cluster will result in an error. Fix it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants