-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](nereids) runtime filter generation bug for topn lazy materialization #56137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 34754 ms |
TPC-DS: Total hot run time: 188311 ms |
ClickBench: Total hot run time: 29.51 s |
FE Regression Coverage ReportIncrement line coverage |
yujun777
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ation (apache#56137) ### What problem does this PR solve? Previous pr (topn lazy materialization, apache#51329 commit id a4b5008) introduces a bug in runtime filter target translation. the runtime filter target should be basased on PhysicalLazyMaterializeOlapScan, not the inner PhysicalOlapScan.
What problem does this PR solve?
Previous pr (topn lazy materialization, #51329 commit id a4b5008) introduces a bug in runtime filter target translation.
the runtime filter target should be basased on PhysicalLazyMaterializeOlapScan, not the inner PhysicalOlapScan.
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)