Skip to content

[fix](streaming job) fix register callback id invalid #56142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JNSimba merged 1 commit into from
Sep 17, 2025
Merged

[fix](streaming job) fix register callback id invalid #56142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions ...rc/main/java/org/apache/doris/nereids/trees/plans/commands/insert/OlapInsertExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,26 +99,16 @@ public void beginTransaction() {
throw new BeginTransactionException("current running txns on db is larger than limit");
}
this.txnId = Env.getCurrentGlobalTransactionMgr().beginTransaction(
database.getId(), ImmutableList.of(table.getId()), labelName, null,
database.getId(), ImmutableList.of(table.getId()), labelName,
new TxnCoordinator(TxnSourceType.FE, 0,
FrontendOptions.getLocalHostAddress(),
ExecuteEnv.getInstance().getStartupTime()),
LoadJobSourceType.INSERT_STREAMING, getListenerId(), ctx.getExecTimeoutS());
LoadJobSourceType.INSERT_STREAMING, ctx.getExecTimeoutS());
} catch (Exception e) {
throw new AnalysisException("begin transaction failed. " + e.getMessage(), e);
}
}

private long getListenerId() {
long listenerId = -1;
StreamingInsertTask streamingInsertTask =
Env.getCurrentEnv().getJobManager().getStreamingTaskManager().getStreamingInsertTaskById(jobId);
if (streamingInsertTask != null) {
listenerId = streamingInsertTask.getJobId();
}
return listenerId;
}

@Override
public void finalizeSink(PlanFragment fragment, DataSink sink, PhysicalSink physicalSink) {
OlapTableSink olapTableSink = (OlapTableSink) sink;
Expand Down Expand Up @@ -199,6 +189,7 @@ protected void beforeExec() {

@Override
protected void onComplete() throws UserException {
setTxnCallbackId();
if (ctx.getState().getStateType() == MysqlStateType.ERR) {
try {
String errMsg = Strings.emptyToNull(ctx.getState().getErrorMessage());
Expand Down Expand Up @@ -234,6 +225,18 @@ protected void onComplete() throws UserException {
}
}

private void setTxnCallbackId() {
TransactionState state = Env.getCurrentGlobalTransactionMgr().getTransactionState(database.getId(), txnId);
if (state == null) {
throw new AnalysisException("txn does not exist: " + txnId);
}
StreamingInsertTask streamingInsertTask =
Env.getCurrentEnv().getJobManager().getStreamingTaskManager().getStreamingInsertTaskById(jobId);
if (streamingInsertTask != null) {
state.setCallbackId(streamingInsertTask.getJobId());
}
}

@Override
protected void onFail(Throwable t) {
errMsg = t.getMessage() == null ? "unknown reason" : t.getMessage();
Expand Down