[Bug] The operator on single Sql has affected the session varaiables#5620
Merged
yangzhg merged 29 commits intoapache:masterfrom Apr 30, 2021
Merged
[Bug] The operator on single Sql has affected the session varaiables#5620yangzhg merged 29 commits intoapache:masterfrom
yangzhg merged 29 commits intoapache:masterfrom
Conversation
morningman
reviewed
Apr 14, 2021
|
|
||
| // origin value init | ||
| VariableMgr.setIsSingleSetVar(false); | ||
| VariableMgr.clearMapSessionOriginValue(); |
Contributor
There was a problem hiding this comment.
VariableMgr is not a thread safe class.
But execute() can be called by multi threads
Contributor
There was a problem hiding this comment.
So isSingleSetVar and sessionOriginValue should be set in SessionVariables instance.
Contributor
Author
There was a problem hiding this comment.
Got it and Fixed. sorry for my fault.
morningman
reviewed
Apr 20, 2021
| public static final long MIN_INSERT_VISIBLE_TIMEOUT_MS = 1000; // If user set a very small value, use this value instead. | ||
|
|
||
| // session origin value | ||
| public static final Map<Field, String> sessionOriginValue = new HashMap<Field, String>(); |
EmmyMiao87
pushed a commit
to EmmyMiao87/incubator-doris
that referenced
this pull request
May 14, 2021
…pache#5620) Change-Id: I783a1ee424e3d82564e5c64e4716dee739e6ed5b
Hastyshell
pushed a commit
to Hastyshell/doris
that referenced
this pull request
Nov 12, 2025
…alog read project-schema-table. apache#57012 (apache#5620) cherry-picks from apache#57012 Related to apache#5289 Co-authored-by: daidai <changyuwei@selectdb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.