Skip to content

[DOC] Add docs of warning of Docker env 1.3 of JDK 11 and some doc of FE config. #5628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 2 commits into from
Apr 13, 2021
Merged

[DOC] Add docs of warning of Docker env 1.3 of JDK 11 and some doc of FE config. #5628

morningman merged 2 commits into from
Apr 13, 2021

Conversation

@HappenLee
Copy link
Contributor

@HappenLee HappenLee commented Apr 11, 2021

Proposed changes

RT

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [x ] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • [x ] I have added tests that prove my fix is effective or that my feature works
  • [x ] If these changes need document changes, I have updated the document
  • [x ] Any dependent changes have been merged

@HappenLee HappenLee force-pushed the docs branch 2 times, most recently from 2823bf5 to 73266fc Compare April 11, 2021 11:07
morningman
morningman reviewed Apr 11, 2021
View reviewed changes
docs/zh-CN/administrator-guide/config/fe_config.md

### `frontend_address`

类型：string
Copy link
Contributor

@morningman morningman Apr 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个参数可以废弃了，直接标注为废弃吧

Copy link
Contributor Author

@HappenLee HappenLee Apr 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

morningman
morningman approved these changes Apr 11, 2021
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman self-assigned this Apr 11, 2021
@morningman morningman added approved Indicates a PR has been approved by one committer. kind/docs Categorizes issue or PR as related to documentation. labels Apr 11, 2021
@morningman morningman merged commit 9403157 into apache:master Apr 13, 2021
EmmyMiao87 pushed a commit to EmmyMiao87/incubator-doris that referenced this pull request May 14, 2021
@HappenLee @morningman-cmy
[DOC] Add docs of warning of Docker env 1.3 of JDK 11 and some doc of…
9381977 
… FE config. (apache#5628)
yiguolei pushed a commit to yiguolei/incubator-doris that referenced this pull request Dec 30, 2025
@hubgeter
[enhancement](s3)Add TotalGetRequestTime profile metric to the S3 rea…
3a42f9b 
…der. (apache#57519) (apache#5628)

bp apache#57519

Problem Summary:
This PR adds a `TotalGetRequestTime` profile metric to the S3 reader.
The new metric records the total time spent on all `GetObject` requests,
which will be useful for future performance analysis and optimization.

Example profile (Some less relevant information was manually removed.):
```
FILE_SCAN_OPERATOR  (id=0.  nereids_id=104.  table  name  =  lineitem):
      CommonCounters:
            -  ExecTime:  11sec669ms
            -  OpenTime:  7.395ms
            -  WaitForDependency[FILE_SCAN_OPERATOR_DEPENDENCY]Time:  11sec634ms
              ....
      CustomCounters:
              ....
          Scanner:
                ....
                -  FileReadTime:  4min8sec
                -  FileScannerGetBlockTime:  4min9sec
                -  MergedSmallIO:  0ns
                    -  ReadTime:  4min8sec
                    -  RequestBytes:  2.05  MB
                    -  RequestIO:  20.0K  (20000)
                -  ParquetReader:  0ns
                    -  ColumnReadTime:  4min9sec
                    -  FileOpenTime:  365.293ms
                    -  ParseFooterTime:  5min6sec
                    -  ParseMetaTime:  126.383ms
                         .....
                -  S3Profile:  0ns
                    -  TooManyRequestErr:  0
                    -  TooManyRequestSleepTime:  0ms
                    -  TotalBytesRead:  199.14  MB
                    -  TotalGetRequestTime:  9min12sec
                    -  TotalGetRequest:  40.0K  (40000)
                -  ScannerCpuTime:  20sec946ms
                -  ScannerGetBlockTime:  9min19sec
```

## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

Assignees

@morningman morningman

Labels

approved Indicates a PR has been approved by one committer. kind/docs Categorizes issue or PR as related to documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HappenLee @morningman