Skip to content

Conversation

@0AyanamiRei
Copy link
Contributor

What problem does this PR solve?

streaming_label_keep_max_second = 10 is too short to make the job record count error

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Sep 25, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@0AyanamiRei
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

ClickBench: Total hot run time: 30.58 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4ded6838f0eb5d5e4ef911a8b5c60a6ddb0bb870, data reload: false

query1	0.05	0.05	0.05
query2	0.09	0.05	0.06
query3	0.25	0.08	0.08
query4	1.61	0.12	0.12
query5	0.28	0.26	0.25
query6	1.18	0.66	0.65
query7	0.03	0.02	0.03
query8	0.06	0.04	0.04
query9	0.60	0.52	0.52
query10	0.59	0.58	0.58
query11	0.15	0.11	0.11
query12	0.15	0.11	0.12
query13	0.64	0.61	0.62
query14	1.02	1.03	1.02
query15	0.85	0.85	0.87
query16	0.41	0.40	0.41
query17	1.06	1.03	1.03
query18	0.22	0.19	0.20
query19	1.95	1.86	1.85
query20	0.01	0.01	0.02
query21	15.43	0.91	0.59
query22	0.77	1.15	0.60
query23	15.06	1.37	0.58
query24	6.47	2.19	1.11
query25	0.51	0.17	0.14
query26	0.58	0.16	0.14
query27	0.07	0.06	0.05
query28	9.88	1.32	0.93
query29	12.58	3.91	3.21
query30	0.27	0.13	0.11
query31	2.82	0.60	0.39
query32	3.26	0.56	0.47
query33	3.08	3.17	3.11
query34	16.20	5.46	4.83
query35	4.95	4.92	4.93
query36	0.69	0.51	0.48
query37	0.10	0.08	0.07
query38	0.07	0.05	0.05
query39	0.04	0.03	0.04
query40	0.18	0.15	0.14
query41	0.09	0.03	0.04
query42	0.03	0.03	0.03
query43	0.04	0.03	0.04
Total cold run time: 104.37 s
Total hot run time: 30.58 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 28, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liaoxin01 liaoxin01 merged commit b4a025a into apache:master Sep 28, 2025
29 of 30 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 28, 2025
github-actions bot pushed a commit that referenced this pull request Sep 28, 2025
dataroaring pushed a commit that referenced this pull request Sep 28, 2025
… the streaming_label_keep_max_second set #56428 (#56569)

Cherry-picked from #56428

Co-authored-by: Refrain <113875799+0AyanamiRei@users.noreply.github.com>
morrySnow pushed a commit that referenced this pull request Sep 29, 2025
… the streaming_label_keep_max_second set #56428 (#56568)

Cherry-picked from #56428

Co-authored-by: Refrain <113875799+0AyanamiRei@users.noreply.github.com>
Hastyshell pushed a commit to Hastyshell/doris that referenced this pull request Nov 12, 2025
…onNormal remove the streaming_label_keep_max_second set apache#56428 (apache#4844)

cherry-picks from apache#56428
Related to apache#4843

Co-authored-by: Refrain <113875799+0AyanamiRei@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.2-merged dev/4.0.0-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants