Skip to content

[fix](cloud) Skip tablet report when CloudTabletRebalancer is not inited #56989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
liutang123 merged 2 commits into from
Oct 28, 2025
Merged

[fix](cloud) Skip tablet report when CloudTabletRebalancer is not inited #56989

liutang123 merged 2 commits into from
Oct 28, 2025
+78 −0

Conversation

@liutang123
Copy link
Contributor

@liutang123 liutang123 commented Oct 15, 2025

What problem does this PR solve?

Issue Number: close #56583

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 15, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@liutang123
Copy link
Contributor Author

liutang123 commented Oct 15, 2025

@deardeng Hi, do you have time to see this PR?

@liutang123
Copy link
Contributor Author

liutang123 commented Oct 15, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Oct 15, 2025

TPC-DS: Total hot run time: 190390 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 22dce383e5f9fd58dea12185ef366264f64bb92a, data reload: false

query1	1072	469	413	413
query2	6593	1733	1683	1683
query3	6755	220	220	220
query4	26508	23346	23453	23346
query5	5006	659	489	489
query6	337	232	234	232
query7	4650	501	298	298
query8	306	266	255	255
query9	8730	2548	2554	2548
query10	566	341	303	303
query11	15628	15150	14815	14815
query12	185	121	111	111
query13	1679	541	439	439
query14	11546	9162	9172	9162
query15	230	191	180	180
query16	7697	675	516	516
query17	1292	767	619	619
query18	2052	462	394	394
query19	243	253	198	198
query20	136	131	138	131
query21	223	158	138	138
query22	4746	4671	4556	4556
query23	35159	34535	34381	34381
query24	8895	2510	2619	2510
query25	601	560	463	463
query26	1287	300	162	162
query27	2763	520	369	369
query28	4433	2230	2211	2211
query29	823	625	531	531
query30	299	234	212	212
query31	913	829	749	749
query32	79	67	76	67
query33	593	391	387	387
query34	819	894	525	525
query35	859	1073	815	815
query36	1027	1024	922	922
query37	135	118	82	82
query38	3648	3644	3464	3464
query39	1473	1441	1461	1441
query40	231	126	113	113
query41	91	56	57	56
query42	126	111	109	109
query43	480	504	473	473
query44	1320	823	814	814
query45	188	182	177	177
query46	830	991	629	629
query47	1770	1817	1706	1706
query48	404	411	310	310
query49	767	513	408	408
query50	651	697	409	409
query51	3949	3944	3914	3914
query52	114	108	103	103
query53	236	267	208	208
query54	598	588	537	537
query55	85	86	91	86
query56	318	330	331	330
query57	1174	1212	1115	1115
query58	288	286	272	272
query59	2587	2575	2532	2532
query60	347	337	347	337
query61	152	154	189	154
query62	802	730	671	671
query63	228	199	193	193
query64	4453	1150	839	839
query65	4064	3942	3976	3942
query66	1096	448	363	363
query67	15756	15357	14958	14958
query68	8779	894	593	593
query69	488	325	362	325
query70	1383	1261	1301	1261
query71	529	336	315	315
query72	5957	4767	4843	4767
query73	692	558	361	361
query74	9024	9203	8706	8706
query75	4165	3370	2897	2897
query76	3776	1162	733	733
query77	835	424	324	324
query78	9620	9759	8896	8896
query79	2823	809	584	584
query80	673	631	496	496
query81	495	265	224	224
query82	458	162	134	134
query83	299	274	248	248
query84	305	120	103	103
query85	892	470	410	410
query86	352	305	309	305
query87	3810	3814	3693	3693
query88	3059	2222	2216	2216
query89	417	332	307	307
query90	2073	217	218	217
query91	163	184	135	135
query92	90	69	73	69
query93	1681	1002	648	648
query94	703	445	351	351
query95	399	319	307	307
query96	495	573	285	285
query97	2945	2984	2873	2873
query98	244	216	228	216
query99	1437	1410	1296	1296
Total cold run time: 282152 ms
Total hot run time: 190390 ms

@doris-robot
Copy link

doris-robot commented Oct 15, 2025

ClickBench: Total hot run time: 30.16 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 22dce383e5f9fd58dea12185ef366264f64bb92a, data reload: false

query1	0.05	0.05	0.05
query2	0.10	0.06	0.06
query3	0.25	0.09	0.09
query4	1.62	0.12	0.11
query5	0.28	0.29	0.26
query6	1.18	0.64	0.64
query7	0.03	0.02	0.02
query8	0.06	0.05	0.04
query9	0.62	0.52	0.53
query10	0.58	0.59	0.57
query11	0.17	0.12	0.12
query12	0.15	0.12	0.15
query13	0.63	0.62	0.61
query14	1.04	1.03	1.02
query15	0.87	0.86	0.89
query16	0.41	0.39	0.42
query17	1.03	1.09	1.05
query18	0.22	0.20	0.20
query19	1.95	1.81	1.86
query20	0.02	0.01	0.02
query21	15.44	0.94	0.56
query22	0.78	1.33	0.76
query23	14.75	1.39	0.67
query24	7.21	1.16	0.45
query25	0.48	0.12	0.22
query26	0.66	0.16	0.13
query27	0.07	0.05	0.06
query28	9.34	1.41	0.94
query29	12.55	4.05	3.28
query30	0.28	0.14	0.12
query31	2.83	0.59	0.40
query32	3.24	0.55	0.49
query33	3.16	3.08	3.09
query34	16.18	5.47	4.80
query35	4.95	4.87	4.94
query36	0.69	0.52	0.50
query37	0.10	0.08	0.07
query38	0.06	0.04	0.04
query39	0.04	0.03	0.04
query40	0.19	0.17	0.15
query41	0.09	0.03	0.03
query42	0.04	0.04	0.03
query43	0.05	0.04	0.04
Total cold run time: 104.44 s
Total hot run time: 30.16 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 15, 2025

FE UT Coverage Report

Increment line coverage 20.00% (1/5) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 15, 2025

FE Regression Coverage Report

Increment line coverage 60.00% (3/5) 🎉
Increment coverage report
Complete coverage report

@liutang123 liutang123 changed the title [fix](cloud) Skip tablet report when CloudTabletRebalancer is not ited [fix](cloud) Skip tablet report when CloudTabletRebalancer is not inited Oct 15, 2025
deardeng
deardeng reviewed Oct 15, 2025
View reviewed changes
Copy link
Contributor

@deardeng deardeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a regression case would be perfect

@liutang123 liutang123 force-pushed the fix-cloud-drop-tablet-master branch from 22dce38 to 5921cee Compare October 16, 2025 11:33
@xy720
Copy link
Member

xy720 commented Oct 20, 2025

May be add a FE UT?

@liutang123 liutang123 force-pushed the fix-cloud-drop-tablet-master branch from 5921cee to 8a49921 Compare October 23, 2025 07:08
@liutang123
Copy link
Contributor Author

liutang123 commented Oct 23, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Oct 23, 2025

ClickBench: Total hot run time: 27.77 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8a49921a2b9b7c37ad17f93feae6a5646df1830c, data reload: false

query1	0.06	0.05	0.06
query2	0.10	0.06	0.05
query3	0.25	0.08	0.09
query4	1.62	0.12	0.12
query5	0.29	0.26	0.24
query6	1.17	0.68	0.68
query7	0.04	0.03	0.03
query8	0.06	0.04	0.04
query9	0.62	0.54	0.52
query10	0.59	0.60	0.60
query11	0.17	0.12	0.11
query12	0.16	0.12	0.12
query13	0.64	0.62	0.60
query14	1.02	1.02	1.02
query15	0.86	0.86	0.84
query16	0.40	0.41	0.40
query17	1.06	1.07	1.06
query18	0.23	0.21	0.21
query19	1.98	1.85	1.81
query20	0.01	0.01	0.01
query21	15.42	0.19	0.14
query22	5.02	0.08	0.06
query23	15.65	0.26	0.12
query24	3.16	1.08	0.29
query25	0.07	0.07	0.07
query26	0.14	0.15	0.13
query27	0.07	0.06	0.05
query28	3.94	1.16	0.93
query29	12.56	3.98	3.30
query30	0.28	0.14	0.11
query31	2.83	0.60	0.39
query32	3.25	0.56	0.48
query33	3.11	3.14	3.06
query34	15.86	5.14	4.57
query35	4.58	4.63	4.61
query36	0.69	0.53	0.50
query37	0.11	0.07	0.07
query38	0.07	0.04	0.04
query39	0.04	0.04	0.03
query40	0.19	0.15	0.14
query41	0.10	0.03	0.03
query42	0.04	0.03	0.03
query43	0.05	0.04	0.03
Total cold run time: 98.56 s
Total hot run time: 27.77 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 23, 2025

FE Regression Coverage Report

Increment line coverage 57.14% (4/7) 🎉
Increment coverage report
Complete coverage report

xy720
xy720 approved these changes Oct 23, 2025
View reviewed changes
Copy link
Member

@xy720 xy720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2025

PR approved by anyone and no changes requested.

lide-reed
lide-reed approved these changes Oct 24, 2025
View reviewed changes
Copy link
Contributor

@lide-reed lide-reed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

deardeng
deardeng approved these changes Oct 26, 2025
View reviewed changes
Copy link
Contributor

@deardeng deardeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dataroaring
dataroaring approved these changes Oct 27, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liutang123 liutang123 merged commit c23b9bb into apache:master Oct 28, 2025
31 of 32 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 28, 2025
@liutang123
[fix](cloud) Skip tablet report when CloudTabletRebalancer is not ini…
5db11a1 
…ted (#56989)

Issue Number: close #56583

---------
Co-authored-by: liutang123 <liulijia@gmail.com>
@github-actions github-actions bot mentioned this pull request Oct 28, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Oct 28, 2025
@liutang123
[fix](cloud) Skip tablet report when CloudTabletRebalancer is not ini…
4742a3e 
…ted (#56989)

Issue Number: close #56583

---------
Co-authored-by: liutang123 <liulijia@gmail.com>
@github-actions github-actions bot mentioned this pull request Oct 28, 2025
Merged
yiguolei pushed a commit that referenced this pull request Oct 28, 2025
@github-actions @liutang123
branch-4.0: [fix](cloud) Skip tablet report when CloudTabletRebalance…
f40a903 
…r is not inited #56989 (#57394)

Cherry-picked from #56989

Co-authored-by: Lijia Liu <liutang123@yeah.net>
Co-authored-by: liutang123 <liulijia@gmail.com>
morrySnow pushed a commit that referenced this pull request Oct 30, 2025
@github-actions @liutang123
branch-3.1: [fix](cloud) Skip tablet report when CloudTabletRebalance…
168863f 
…r is not inited #56989 (#57393)

Cherry-picked from #56989

Co-authored-by: Lijia Liu <liutang123@yeah.net>
Co-authored-by: liutang123 <liulijia@gmail.com>
dwdwqfwe pushed a commit to dwdwqfwe/doris that referenced this pull request Oct 31, 2025
@liutang123 @dwdwqfwe
[fix](cloud) Skip tablet report when CloudTabletRebalancer is not ini…
2a7e0ee 
…ted (apache#56989)

Issue Number: close apache#56583

---------
Co-authored-by: liutang123 <liulijia@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lide-reed lide-reed lide-reed approved these changes

@xy720 xy720 xy720 approved these changes

@dataroaring dataroaring dataroaring approved these changes

@gavinchou gavinchou Awaiting requested review from gavinchou gavinchou is a code owner

@w41ter w41ter Awaiting requested review from w41ter w41ter is a code owner

+1 more reviewer

@deardeng deardeng deardeng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.x dev/3.1.3-merged dev/4.0.1-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Some cache will be removed after FE restarted

9 participants

@liutang123 @hello-stephen @doris-robot @xy720 @lide-reed @deardeng @dataroaring @yiguolei @morrySnow