[opt](function) Enhance the handling of a single struct-type argument in the EXPLODE function #57050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
Member
Author
|
run buildall |
Member
Author
|
run buildall |
TPC-DS: Total hot run time: 189309 ms |
ClickBench: Total hot run time: 30.4 s |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Member
Author
|
run buildall |
TPC-DS: Total hot run time: 190296 ms |
ClickBench: Total hot run time: 30.16 s |
… in the EXPLODE function
Member
Author
|
run buildall |
ClickBench: Total hot run time: 30.15 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE Regression Coverage ReportIncrement line coverage |
zhangstar333
approved these changes
Oct 17, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Contributor
|
PR approved by anyone and no changes requested. |
starocean999
approved these changes
Oct 17, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Oct 17, 2025
… in the EXPLODE function (#57050) ### What problem does this PR solve? Since the EXPLODE function supports multiple arguments, its return value is defined as a STRUCT type. Even when it has only a single argument, it still returns a STRUCT. Consider the following example: ```sql SELECT * FROM (SELECT 1) t1 LATERAL VIEW explode(array(struct('a', 1), struct('b', 2))) t2 AS c1, c2; ``` ```text +------+------------------------+ | 1 | c1 | +------+------------------------+ | 1 | {"col1":"a", "col2":1} | | 1 | {"col1":"b", "col2":2} | +------+------------------------+ ``` In this SQL statement, the return value of the EXPLODE function is a nested STRUCT (that is, the child column inside the struct is struct too). As a result, the final output extracts the child column from the outer struct, but those child columns themselves are not correctly assigned to c1 and c2. With this PR, the result will be like this: ```text +------+------+------+ | 1 | c1 | c2 | +------+------+------+ | 1 | a | 1 | | 1 | b | 2 | +------+------+------+ ``` Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
mrhhsg
added a commit
to mrhhsg/doris
that referenced
this pull request
Nov 8, 2025
…ype argument in the EXPLODE function (apache#57050) Cherry-picked from apache#57050 Co-authored-by: Jerry Hu <hushenggang@selectdb.com>
w41ter
pushed a commit
to w41ter/incubator-doris
that referenced
this pull request
Dec 26, 2025
… in the EXPLODE function apache#57050 (apache#5641) pick apache#57050
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Since the EXPLODE function supports multiple arguments, its return value is defined as a STRUCT type. Even when it has only a single argument, it still returns a STRUCT.
Consider the following example:
In this SQL statement, the return value of the EXPLODE function is a nested STRUCT (that is, the child column inside the struct is struct too).
As a result, the final output extracts the child column from the outer struct, but those child columns themselves are not correctly assigned to c1 and c2.
With this PR, the result will be like this:
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)