Skip to content

branch-3.1: [fix](segcompaction) Fix segcompaction coredump when adding key column #57162 #57212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Oct 28, 2025
Merged

branch-3.1: [fix](segcompaction) Fix segcompaction coredump when adding key column #57162 #57212

morrySnow merged 1 commit into from
Oct 28, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Oct 22, 2025

Cherry-picked from #57162

@Hastyshell
[fix](segcompaction) Fix segcompaction coredump when adding key column (
21d8c5c 
#57162)

Issue Number: close #56431 

Only check segment compaction when importing data.
@github-actions github-actions bot requested a review from morrySnow as a code owner October 22, 2025 02:17
@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 22, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Oct 22, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 22, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Oct 22, 2025

TPC-H: Total hot run time: 33702 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 21d8c5c86578a14a7022a6d2c810c6f8734b2737, data reload: false

------ Round 1 ----------------------------------
q1	17599	5471	5487	5471
q2	2049	411	291	291
q3	11754	1282	785	785
q4	10366	917	500	500
q5	9642	2462	2164	2164
q6	200	168	139	139
q7	949	775	631	631
q8	9371	1514	1275	1275
q9	5284	5003	4994	4994
q10	6791	2305	1824	1824
q11	478	294	289	289
q12	359	372	230	230
q13	17788	3663	3096	3096
q14	233	236	213	213
q15	527	479	466	466
q16	444	456	392	392
q17	672	879	404	404
q18	6930	6498	6408	6408
q19	1217	960	562	562
q20	373	357	231	231
q21	3266	2394	2284	2284
q22	1101	1087	1053	1053
Total cold run time: 107393 ms
Total hot run time: 33702 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5574	5517	5621	5517
q2	245	340	234	234
q3	2271	2670	2331	2331
q4	1499	1855	1445	1445
q5	4533	5173	5057	5057
q6	178	165	134	134
q7	2082	1991	1841	1841
q8	2694	2853	2733	2733
q9	7349	7306	7300	7300
q10	3073	3291	2863	2863
q11	611	542	522	522
q12	704	775	646	646
q13	3508	3852	3281	3281
q14	305	295	274	274
q15	550	481	475	475
q16	470	495	463	463
q17	1275	1734	1300	1300
q18	7584	7665	7433	7433
q19	887	1216	1096	1096
q20	2068	2098	1933	1933
q21	5596	4970	4884	4884
q22	1153	1162	1030	1030
Total cold run time: 54209 ms
Total hot run time: 52792 ms

@Hastyshell
Copy link
Collaborator

Hastyshell commented Oct 22, 2025

run compile

@doris-robot
Copy link

doris-robot commented Oct 22, 2025

TPC-DS: Total hot run time: 198807 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 21d8c5c86578a14a7022a6d2c810c6f8734b2737, data reload: false

query1	969	387	391	387
query2	6341	2161	2147	2147
query3	8693	221	219	219
query4	33699	24047	23546	23546
query5	3933	663	492	492
query6	304	213	196	196
query7	4210	529	342	342
query8	332	272	261	261
query9	9529	2914	2917	2914
query10	490	348	282	282
query11	18160	15523	15189	15189
query12	158	118	116	116
query13	1556	587	473	473
query14	10064	7272	6879	6879
query15	246	195	192	192
query16	8071	674	524	524
query17	1581	762	627	627
query18	2206	450	336	336
query19	257	212	185	185
query20	128	121	126	121
query21	222	138	124	124
query22	4647	4752	4519	4519
query23	35792	34895	34801	34801
query24	7352	2801	2795	2795
query25	539	514	470	470
query26	767	272	189	189
query27	1929	511	394	394
query28	5355	2487	2496	2487
query29	656	577	483	483
query30	258	209	164	164
query31	1027	964	864	864
query32	106	65	64	64
query33	513	400	359	359
query34	809	911	584	584
query35	838	833	750	750
query36	1114	1161	1112	1112
query37	125	109	88	88
query38	4139	4175	4156	4156
query39	1615	1531	1511	1511
query40	215	133	114	114
query41	52	55	57	55
query42	141	122	121	121
query43	603	615	576	576
query44	1532	977	963	963
query45	194	187	187	187
query46	983	1110	741	741
query47	2037	2064	2000	2000
query48	475	494	411	411
query49	777	537	447	447
query50	788	775	497	497
query51	7864	7841	7672	7672
query52	121	115	105	105
query53	259	295	212	212
query54	610	621	542	542
query55	91	86	87	86
query56	299	306	278	278
query57	1273	1297	1257	1257
query58	259	249	259	249
query59	3464	3437	3378	3378
query60	325	309	332	309
query61	127	118	115	115
query62	789	790	698	698
query63	247	218	220	218
query64	4063	1060	724	724
query65	3412	3362	3322	3322
query66	1020	445	322	322
query67	16936	16172	16094	16094
query68	7417	877	591	591
query69	523	330	290	290
query70	1296	1220	1197	1197
query71	373	326	290	290
query72	5780	3847	4147	3847
query73	703	781	406	406
query74	10486	9225	9231	9225
query75	3261	3202	2730	2730
query76	3176	1229	851	851
query77	527	375	295	295
query78	10529	10576	9800	9800
query79	3928	938	628	628
query80	739	549	470	470
query81	514	269	227	227
query82	587	126	100	100
query83	175	168	155	155
query84	287	121	91	91
query85	795	380	323	323
query86	361	351	343	343
query87	4478	4405	4288	4288
query88	4967	2715	2694	2694
query89	434	347	316	316
query90	1902	202	201	201
query91	143	153	120	120
query92	66	61	56	56
query93	2757	945	580	580
query94	692	429	286	286
query95	376	306	293	293
query96	558	656	314	314
query97	3269	3323	3204	3204
query98	250	208	208	208
query99	1576	1431	1353	1353
Total cold run time: 300611 ms
Total hot run time: 198807 ms

@doris-robot
Copy link

doris-robot commented Oct 22, 2025

BE UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.78% (12875/28126)
Line Coverage 36.66% (115332/314581)
Region Coverage 34.17% (65768/192459)
Branch Coverage 31.19% (34527/110702)

@doris-robot
Copy link

doris-robot commented Oct 22, 2025

ClickBench: Total hot run time: 30.44 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 21d8c5c86578a14a7022a6d2c810c6f8734b2737, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.03	0.03
query3	0.24	0.08	0.06
query4	1.61	0.11	0.11
query5	0.53	0.53	0.50
query6	1.15	0.73	0.73
query7	0.02	0.02	0.01
query8	0.05	0.04	0.03
query9	0.62	0.52	0.51
query10	0.57	0.57	0.56
query11	0.15	0.11	0.11
query12	0.15	0.12	0.12
query13	0.64	0.60	0.60
query14	0.78	0.80	0.81
query15	0.85	0.85	0.84
query16	0.40	0.39	0.43
query17	1.02	1.01	1.02
query18	0.24	0.22	0.24
query19	1.99	1.96	1.97
query20	0.01	0.01	0.02
query21	15.38	1.05	0.63
query22	0.74	0.77	0.92
query23	14.86	1.52	0.63
query24	2.94	1.90	1.58
query25	0.18	0.05	0.05
query26	0.27	0.15	0.14
query27	0.06	0.05	0.05
query28	14.19	1.05	0.46
query29	12.55	4.24	3.54
query30	0.25	0.09	0.07
query31	2.82	0.65	0.39
query32	3.23	0.56	0.47
query33	3.10	3.08	3.13
query34	16.51	5.20	4.56
query35	4.61	4.61	4.56
query36	0.64	0.52	0.48
query37	0.09	0.06	0.07
query38	0.05	0.04	0.04
query39	0.03	0.03	0.03
query40	0.18	0.14	0.13
query41	0.08	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 103.98 s
Total hot run time: 30.44 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 22, 2025

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.44% (21145/27663)
Line Coverage 69.67% (218668/313880)
Region Coverage 67.58% (130670/193346)
Branch Coverage 61.20% (68087/111254)

dataroaring
dataroaring approved these changes Oct 27, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morrySnow morrySnow merged commit fc21fd1 into branch-3.1 Oct 28, 2025
22 of 23 checks passed
@morrySnow morrySnow deleted the auto-pick-57162-branch-3.1 branch October 28, 2025 07:26
@morrySnow morrySnow mentioned this pull request Nov 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hello-stephen @doris-robot @Hastyshell @dataroaring @morrySnow