Skip to content

branch-4.0: [opt](var) change merge_io_read_slice_size to merge_io_read_slice_size_bytes #57272 #57273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiguolei merged 1 commit into from
Oct 24, 2025
Merged

branch-4.0: [opt](var) change merge_io_read_slice_size to merge_io_read_slice_size_bytes #57272 #57273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ...ore/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/SetSessionVarOp.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,16 @@ public void validate(ConnectContext ctx) throws UserException {
}
}

if (name.equalsIgnoreCase(SessionVariable.MERGE_IO_READ_SLICE_SIZE_BYTES)) {
try {
this.value = new StringLiteral(
Long.toString(ParseUtil.analyzeDataVolume(value.getStringValue())));
} catch (Throwable t) {
// see comments of FILE_SPLIT_SIZE
this.value = new StringLiteral(value.getStringValue());
}
}

if (name.equalsIgnoreCase("is_report_success")) {
name = SessionVariable.ENABLE_PROFILE;
}
Expand Down
9 changes: 5 additions & 4 deletions fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -868,7 +868,7 @@ public static double getHotValueThreshold() {
public static final String MULTI_DISTINCT_STRATEGY = "multi_distinct_strategy";
public static final String AGG_PHASE = "agg_phase";

public static final String MERGE_IO_READ_SLICE_SIZE = "merge_io_read_slice_size";
public static final String MERGE_IO_READ_SLICE_SIZE_BYTES = "merge_io_read_slice_size_bytes";

public static final String ENABLE_PREFER_CACHED_ROWSET = "enable_prefer_cached_rowset";
public static final String QUERY_FRESHNESS_TOLERANCE_MS = "query_freshness_tolerance_ms";
Expand Down Expand Up @@ -2589,9 +2589,10 @@ public void setSkewRewriteAggBucketNum(int num) {
public int aggPhase = 0;


@VariableMgr.VarAttr(name = MERGE_IO_READ_SLICE_SIZE, description = {"调整 READ_SLICE_SIZE 大小，降低 Merge IO 读放大影响",
@VariableMgr.VarAttr(name = MERGE_IO_READ_SLICE_SIZE_BYTES, description = {
"调整 READ_SLICE_SIZE 大小，降低 Merge IO 读放大影响",
"Make the READ_SLICE_SIZE variable configurable to reduce the impact caused by read amplification."})
public int mergeReadSliceSize = 8388608;
public int mergeReadSliceSizeBytes = 8388608;

public void setAggPhase(int phase) {
aggPhase = phase;
Expand Down Expand Up @@ -4751,7 +4752,7 @@ public TQueryOptions toThrift() {
tResult.setHnswEfSearch(hnswEFSearch);
tResult.setHnswCheckRelativeDistance(hnswCheckRelativeDistance);
tResult.setHnswBoundedQueue(hnswBoundedQueue);
tResult.setMergeReadSliceSize(mergeReadSliceSize);
tResult.setMergeReadSliceSize(mergeReadSliceSizeBytes);
return tResult;
}

Expand Down
Loading