Skip to content

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Oct 27, 2025

followup #57181
After upgrading gtest to 1.12, need include <gtest/gtest.h>

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morningman
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-DS: Total hot run time: 190586 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit fe1a8655e4cb7553afe5264bb1462827a0c30ab5, data reload: false

query1	1071	451	411	411
query2	6558	1751	1726	1726
query3	6752	220	217	217
query4	26047	23949	23342	23342
query5	5928	672	512	512
query6	350	253	222	222
query7	4645	497	298	298
query8	311	290	257	257
query9	8712	2573	2568	2568
query10	557	348	292	292
query11	15320	15167	14934	14934
query12	192	116	110	110
query13	1682	556	437	437
query14	12709	9437	9497	9437
query15	252	193	177	177
query16	7765	687	504	504
query17	1584	881	808	808
query18	2149	484	390	390
query19	315	240	205	205
query20	138	140	147	140
query21	236	145	123	123
query22	4623	4676	4494	4494
query23	35019	33890	33763	33763
query24	8297	2538	2592	2538
query25	593	539	511	511
query26	1248	285	174	174
query27	3660	525	373	373
query28	4403	2253	2235	2235
query29	816	626	522	522
query30	328	259	204	204
query31	971	846	814	814
query32	78	75	72	72
query33	585	450	379	379
query34	856	878	559	559
query35	829	895	826	826
query36	1022	1065	971	971
query37	148	128	93	93
query38	3685	3631	3519	3519
query39	1482	1404	1417	1404
query40	228	128	120	120
query41	62	57	57	57
query42	118	109	117	109
query43	505	504	485	485
query44	1239	752	744	744
query45	183	184	177	177
query46	933	998	653	653
query47	1727	1746	1679	1679
query48	438	428	312	312
query49	764	508	416	416
query50	661	693	431	431
query51	3935	3898	3914	3898
query52	114	117	98	98
query53	245	279	202	202
query54	611	592	566	566
query55	88	84	81	81
query56	322	320	313	313
query57	1158	1180	1117	1117
query58	286	288	285	285
query59	2528	2625	2589	2589
query60	351	347	338	338
query61	157	154	154	154
query62	768	749	672	672
query63	234	212	198	198
query64	4389	1152	862	862
query65	4042	4021	3943	3943
query66	1043	438	339	339
query67	15317	15334	14839	14839
query68	7617	945	608	608
query69	518	353	305	305
query70	1412	1262	1279	1262
query71	464	365	332	332
query72	6117	4876	4815	4815
query73	605	572	367	367
query74	9196	9083	8695	8695
query75	3324	3320	2806	2806
query76	3104	1193	772	772
query77	591	410	329	329
query78	9656	9632	8948	8948
query79	2265	809	609	609
query80	644	564	529	529
query81	522	258	228	228
query82	489	165	130	130
query83	271	263	252	252
query84	262	109	98	98
query85	902	472	437	437
query86	329	325	302	302
query87	3770	3721	3587	3587
query88	4042	2262	2275	2262
query89	401	326	302	302
query90	1992	234	225	225
query91	169	164	134	134
query92	84	68	70	68
query93	1986	1002	642	642
query94	752	457	341	341
query95	403	320	322	320
query96	495	580	283	283
query97	2917	2966	2862	2862
query98	249	217	219	217
query99	1491	1408	1281	1281
Total cold run time: 281401 ms
Total hot run time: 190586 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.63 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit fe1a8655e4cb7553afe5264bb1462827a0c30ab5, data reload: false

query1	0.06	0.05	0.04
query2	0.09	0.06	0.06
query3	0.26	0.08	0.08
query4	1.63	0.12	0.11
query5	0.28	0.28	0.25
query6	1.20	0.65	0.64
query7	0.04	0.02	0.02
query8	0.05	0.04	0.04
query9	0.62	0.53	0.53
query10	0.58	0.58	0.59
query11	0.17	0.11	0.11
query12	0.16	0.13	0.12
query13	0.61	0.60	0.63
query14	1.00	1.01	1.01
query15	0.84	0.84	0.84
query16	0.40	0.43	0.40
query17	1.00	1.03	1.04
query18	0.21	0.20	0.20
query19	1.93	1.81	1.77
query20	0.02	0.01	0.01
query21	15.47	0.17	0.13
query22	5.19	0.07	0.04
query23	15.73	0.27	0.10
query24	3.02	0.70	0.41
query25	0.09	0.06	0.06
query26	0.14	0.14	0.13
query27	0.08	0.05	0.05
query28	4.68	1.12	0.94
query29	12.68	4.01	3.32
query30	0.30	0.13	0.12
query31	2.81	0.57	0.38
query32	3.22	0.55	0.46
query33	3.01	3.06	3.06
query34	15.88	5.19	4.58
query35	4.55	4.60	4.56
query36	0.68	0.50	0.49
query37	0.10	0.07	0.06
query38	0.07	0.04	0.04
query39	0.03	0.03	0.04
query40	0.18	0.15	0.15
query41	0.09	0.03	0.02
query42	0.04	0.03	0.04
query43	0.04	0.04	0.03
Total cold run time: 99.23 s
Total hot run time: 27.63 s

@morningman
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

ClickBench: Total hot run time: 27.47 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e5c663c19e51a74df22fc8557392dd3bd8ca110c, data reload: false

query1	0.05	0.05	0.05
query2	0.10	0.05	0.05
query3	0.25	0.08	0.09
query4	1.60	0.12	0.12
query5	0.29	0.27	0.25
query6	1.15	0.66	0.64
query7	0.04	0.03	0.03
query8	0.06	0.05	0.05
query9	0.63	0.51	0.52
query10	0.58	0.58	0.56
query11	0.16	0.12	0.11
query12	0.16	0.12	0.12
query13	0.64	0.59	0.59
query14	1.00	1.02	1.00
query15	0.85	0.83	0.84
query16	0.40	0.39	0.39
query17	1.03	1.02	1.04
query18	0.22	0.20	0.20
query19	1.94	1.85	1.83
query20	0.02	0.01	0.02
query21	15.76	0.19	0.12
query22	5.60	0.07	0.05
query23	15.68	0.27	0.11
query24	3.34	0.51	0.27
query25	0.09	0.07	0.05
query26	0.15	0.13	0.12
query27	0.06	0.06	0.05
query28	3.66	1.14	0.93
query29	12.62	3.94	3.28
query30	0.28	0.15	0.11
query31	2.82	0.60	0.38
query32	3.24	0.55	0.47
query33	3.03	3.11	3.06
query34	15.96	5.14	4.55
query35	4.62	4.62	4.61
query36	0.68	0.51	0.50
query37	0.10	0.07	0.07
query38	0.06	0.04	0.04
query39	0.03	0.03	0.03
query40	0.18	0.15	0.14
query41	0.08	0.04	0.03
query42	0.05	0.03	0.03
query43	0.05	0.03	0.03
Total cold run time: 99.31 s
Total hot run time: 27.47 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.75% (18049/34214)
Line Coverage 37.99% (163676/430852)
Region Coverage 32.37% (124777/385445)
Branch Coverage 33.74% (54557/161711)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.39% (23933/33526)
Line Coverage 57.80% (248938/430666)
Region Coverage 53.04% (206953/390171)
Branch Coverage 54.69% (88865/162486)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.38% (23930/33526)
Line Coverage 57.79% (248901/430666)
Region Coverage 53.02% (206856/390171)
Branch Coverage 54.69% (88865/162486)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 28, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman morningman merged commit a8973d6 into apache:master Oct 28, 2025
28 of 30 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 28, 2025
followup #57181
After upgrading gtest to 1.12, need include <gtest/gtest.h>
github-actions bot pushed a commit that referenced this pull request Oct 28, 2025
followup #57181
After upgrading gtest to 1.12, need include <gtest/gtest.h>
dwdwqfwe pushed a commit to dwdwqfwe/doris that referenced this pull request Oct 31, 2025
followup apache#57181
After upgrading gtest to 1.12, need include <gtest/gtest.h>
morningman added a commit to morningman/doris that referenced this pull request Oct 31, 2025
followup apache#57181
After upgrading gtest to 1.12, need include <gtest/gtest.h>
morningman added a commit that referenced this pull request Nov 3, 2025
followup #57181
After upgrading gtest to 1.12, need include <gtest/gtest.h>
yiguolei pushed a commit that referenced this pull request Nov 3, 2025
Cherry-picked from #57181 #57359

---------

Co-authored-by: Mingyu Chen (Rayner) <morningman@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.3-merged dev/4.0.1-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants