Skip to content

[fix](cloud) fix wrong private endpoint when only configured port number #57429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
liaoxin01 merged 1 commit into from
Nov 4, 2025
Merged

[fix](cloud) fix wrong private endpoint when only configured port number #57429

liaoxin01 merged 1 commit into from
Nov 4, 2025

Conversation

@liaoxin01
Copy link
Contributor

@liaoxin01 liaoxin01 commented Oct 28, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
use request host here, because private endpoint may be unknown for cloud mode.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 28, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@liaoxin01
Copy link
Contributor Author

liaoxin01 commented Oct 28, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 28, 2025

FE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 28, 2025

FE Regression Coverage Report

Increment line coverage 0.00% (0/1) 🎉
Increment coverage report
Complete coverage report

1 similar comment
@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 29, 2025

FE Regression Coverage Report

Increment line coverage 0.00% (0/1) 🎉
Increment coverage report
Complete coverage report

@liaoxin01
Copy link
Contributor Author

liaoxin01 commented Nov 1, 2025

run performance

@doris-robot
Copy link

doris-robot commented Nov 1, 2025

TPC-DS: Total hot run time: 189841 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6ae677b80cff5a381e1bd5424f53d1b87f68384e, data reload: false

query1	1040	433	396	396
query2	6566	1692	1695	1692
query3	6752	231	226	226
query4	26950	23735	23073	23073
query5	4855	610	470	470
query6	335	241	233	233
query7	4655	496	288	288
query8	314	259	245	245
query9	8719	2579	2559	2559
query10	533	344	296	296
query11	15593	15162	15128	15128
query12	209	116	117	116
query13	1690	557	451	451
query14	11980	9220	9349	9220
query15	207	193	170	170
query16	7693	679	542	542
query17	1485	757	631	631
query18	2110	487	375	375
query19	223	245	202	202
query20	152	139	145	139
query21	245	145	113	113
query22	4575	4887	4654	4654
query23	35275	33858	33771	33771
query24	8426	2570	2733	2570
query25	607	514	461	461
query26	1237	299	162	162
query27	2936	521	374	374
query28	4350	2229	2191	2191
query29	831	630	513	513
query30	320	226	201	201
query31	962	853	776	776
query32	126	85	82	82
query33	957	384	317	317
query34	843	852	536	536
query35	823	842	737	737
query36	987	1043	942	942
query37	134	120	91	91
query38	3959	3599	3641	3599
query39	1721	1431	1458	1431
query40	210	121	114	114
query41	59	61	55	55
query42	125	105	112	105
query43	491	508	473	473
query44	1223	730	717	717
query45	186	188	168	168
query46	897	978	628	628
query47	1722	1809	1687	1687
query48	384	427	309	309
query49	766	492	423	423
query50	637	681	410	410
query51	3878	3873	3838	3838
query52	117	109	102	102
query53	231	268	198	198
query54	295	288	285	285
query55	87	90	82	82
query56	329	317	302	302
query57	1154	1189	1089	1089
query58	285	270	292	270
query59	2436	2628	2564	2564
query60	342	345	316	316
query61	168	156	156	156
query62	799	727	694	694
query63	231	195	194	194
query64	4444	1163	853	853
query65	4025	3978	3972	3972
query66	1084	425	339	339
query67	15353	15293	15255	15255
query68	7961	868	597	597
query69	482	328	299	299
query70	1325	1263	1295	1263
query71	466	339	313	313
query72	6067	5125	4923	4923
query73	652	571	363	363
query74	9149	8950	8686	8686
query75	3349	3444	2827	2827
query76	3343	1144	715	715
query77	493	417	321	321
query78	9794	9947	8895	8895
query79	2290	805	594	594
query80	722	556	510	510
query81	498	264	227	227
query82	254	171	132	132
query83	271	265	244	244
query84	264	105	90	90
query85	888	469	441	441
query86	394	326	294	294
query87	3752	3733	3626	3626
query88	3085	2247	2242	2242
query89	376	332	293	293
query90	2021	205	213	205
query91	160	160	131	131
query92	80	69	62	62
query93	2204	975	634	634
query94	703	447	337	337
query95	393	315	312	312
query96	485	564	284	284
query97	2892	2974	2882	2882
query98	242	214	206	206
query99	1323	1386	1322	1322
Total cold run time: 279711 ms
Total hot run time: 189841 ms

@doris-robot
Copy link

doris-robot commented Nov 1, 2025

ClickBench: Total hot run time: 28.04 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6ae677b80cff5a381e1bd5424f53d1b87f68384e, data reload: false

query1	0.06	0.05	0.05
query2	0.09	0.05	0.05
query3	0.26	0.09	0.09
query4	1.60	0.12	0.11
query5	0.27	0.26	0.25
query6	1.19	0.65	0.63
query7	0.04	0.03	0.03
query8	0.06	0.05	0.04
query9	0.61	0.53	0.51
query10	0.57	0.59	0.57
query11	0.17	0.11	0.12
query12	0.16	0.12	0.12
query13	0.62	0.61	0.62
query14	1.00	1.00	1.00
query15	0.83	0.82	0.84
query16	0.41	0.38	0.39
query17	1.06	1.04	1.02
query18	0.22	0.20	0.22
query19	1.92	1.80	1.82
query20	0.01	0.01	0.01
query21	15.44	0.19	0.12
query22	5.10	0.06	0.04
query23	15.68	0.26	0.10
query24	3.16	0.83	0.87
query25	0.08	0.07	0.07
query26	0.14	0.12	0.12
query27	0.06	0.05	0.06
query28	4.91	1.13	0.94
query29	12.62	4.02	3.43
query30	0.30	0.13	0.12
query31	2.81	0.59	0.38
query32	3.23	0.54	0.46
query33	3.01	2.99	3.08
query34	15.87	5.17	4.59
query35	4.59	4.61	4.57
query36	0.68	0.49	0.49
query37	0.10	0.06	0.07
query38	0.06	0.04	0.03
query39	0.04	0.03	0.03
query40	0.18	0.15	0.14
query41	0.09	0.03	0.03
query42	0.04	0.03	0.02
query43	0.05	0.04	0.03
Total cold run time: 99.39 s
Total hot run time: 28.04 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

PR approved by anyone and no changes requested.

sollhui
sollhui approved these changes Nov 4, 2025
View reviewed changes
Copy link
Contributor

@sollhui sollhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liaoxin01 liaoxin01 merged commit efbfa95 into apache:master Nov 4, 2025
31 of 32 checks passed
@liaoxin01 liaoxin01 deleted the fix_load_action_doris branch November 4, 2025 06:21
github-actions bot pushed a commit that referenced this pull request Nov 4, 2025
@liaoxin01
[fix](cloud) fix wrong private endpoint when only configured port num…
b004da0 
…ber (#57429)

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
use request host here, because private endpoint may be unknown for cloud
mode.

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@github-actions github-actions bot mentioned this pull request Nov 4, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Nov 4, 2025
@liaoxin01
[fix](cloud) fix wrong private endpoint when only configured port num…
d4384c4 
…ber (#57429)

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
use request host here, because private endpoint may be unknown for cloud
mode.

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@github-actions github-actions bot mentioned this pull request Nov 4, 2025
Merged
yiguolei pushed a commit that referenced this pull request Nov 4, 2025
@github-actions @liaoxin01
branch-4.0: [fix](cloud) fix wrong private endpoint when only configu…
5d6e4cd 
…red port number #57429 (#57676)

Cherry-picked from #57429

Co-authored-by: Xin Liao <liaoxin@selectdb.com>
morrySnow pushed a commit that referenced this pull request Nov 5, 2025
@github-actions @liaoxin01
branch-3.1: [fix](cloud) fix wrong private endpoint when only configu…
c0fe6bc 
…red port number #57429 (#57675)

Cherry-picked from #57429

Co-authored-by: Xin Liao <liaoxin@selectdb.com>
wyxxxcat pushed a commit to wyxxxcat/doris that referenced this pull request Nov 18, 2025
@liaoxin01 @wyxxxcat
[fix](cloud) fix wrong private endpoint when only configured port num…
822fc76 
…ber (apache#57429)

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
use request host here, because private endpoint may be unknown for cloud
mode.

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
Hastyshell pushed a commit to Hastyshell/doris that referenced this pull request Dec 29, 2025
@liaoxin01
[fix](cloud) fix wrong private endpoint when only configured port num…
cf4d24f 
…ber apache#57429 (apache#5360)

pick from：apache#57429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

+1 more reviewer

@sollhui sollhui sollhui approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.3-merged dev/4.0.1-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@liaoxin01 @hello-stephen @doris-robot @gavinchou @sollhui @yiguolei @morrySnow