[opt](filecache) schema change adaptive to file cache#57470
Merged
gavinchou merged 9 commits intoapache:masterfrom Nov 28, 2025
Merged
[opt](filecache) schema change adaptive to file cache#57470gavinchou merged 9 commits intoapache:masterfrom
gavinchou merged 9 commits intoapache:masterfrom
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
gavinchou
changed the title
gavinchou
reviewed
Nov 4, 2025
| DCHECK_EQ(_output_rowset->version(), _input_rowsets[0]->version()); | ||
| // MUST NOT move input rowset to stale path. | ||
| cloud_tablet()->add_rowsets({_output_rowset}, true, wrlock); | ||
| cloud_tablet()->add_rowsets({_output_rowset}, true, wrlock, true); |
Contributor
There was a problem hiding this comment.
This should be also fixed, we cannot always warm up data when doing index compaction.
Contributor
Author
|
run buildall |
1 similar comment
Contributor
Author
|
run buildall |
TPC-DS: Total hot run time: 190149 ms |
ClickBench: Total hot run time: 27.81 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
gavinchou
previously approved these changes
Nov 6, 2025
HaolinGuan7211
force-pushed
the
ghl/sc_cache_adaptive
branch
from
7974597 to
915dcbd
Compare
HaolinGuan7211
force-pushed
the
ghl/sc_cache_adaptive
branch
from
fecf849 to
c33eb68
Compare
gavinchou
previously approved these changes
Nov 10, 2025
Contributor
|
run buildall |
TPC-H: Total hot run time: 35645 ms |
TPC-DS: Total hot run time: 187610 ms |
ClickBench: Total hot run time: 27.32 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
| double input_hit_rate = static_cast<double>(cached_index_size + cached_data_size) / total_size; | ||
|
|
||
| if (input_hit_rate > config::file_cache_keep_schema_change_output_min_hit_ratio) { | ||
| return true; |
Contributor
There was a problem hiding this comment.
please add LOG(INFO) here to clarify the decision
Contributor
There was a problem hiding this comment.
tabletid, xxx_size, ratio, etc
Contributor
Author
There was a problem hiding this comment.
Ok, I wiil add LOG here.
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34471 ms |
Contributor
Author
|
run cloud_p0 |
TPC-DS: Total hot run time: 183967 ms |
ClickBench: Total hot run time: 28.02 s |
Contributor
Author
|
run cloud_p0 |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34263 ms |
TPC-DS: Total hot run time: 184847 ms |
ClickBench: Total hot run time: 27.55 s |
gavinchou
approved these changes
Nov 28, 2025
Contributor
|
run check_coverage |
Contributor
|
skip check_coverage |
HaolinGuan7211
added a commit
to HaolinGuan7211/doris
that referenced
this pull request
Dec 2, 2025
This was referenced Dec 2, 2025
nagisa-kunhah
pushed a commit
to nagisa-kunhah/doris
that referenced
this pull request
Dec 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.