Skip to content

branch-3.1: [Enhancement](sql-dialect) Support retrying original sql after error #57498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 2 commits into from
Oct 31, 2025
Merged

branch-3.1: [Enhancement](sql-dialect) Support retrying original sql after error #57498

morningman merged 2 commits into from
Oct 31, 2025

Conversation

@zy-kkk
Copy link
Member

@zy-kkk zy-kkk commented Oct 30, 2025

pick (#55566)

@zy-kkk
[Enhancement](sql-dialect) Support retrying original sql after error (a…
9f33559 
…pache#55566)

Add a retry logic. When using SqlConverter for dialect conversion, in
some cases we use the doris dialect instead of others, but these SQLs
will also be converted once by SqlConverter, which may cause errors.
Therefore, you can use the enable_sql_converter_retry_original variable
to control whether to use the original SQL to retry the parser.

```sql
Doris > set sql_dialect = 'hive';
Query OK, 0 rows affected (0.03 sec)

Doris > SELECT   DATE(     DATE_SUB(       requirement_created_date,       INTERVAL DAYOFWEEK (requirement_created_date) - 1 DAY     )   ) AS requirement_created_date,   COUNT(distinct tapd_id) AS count FROM   test.test_tapd_data GROUP BY   DATE(     DATE_SUB(       requirement_created_date,       INTERVAL DAYOFWEEK (requirement_created_date) - 1 DAY     )   ) LIMIT   10000;
ERROR 1105 (HY000): errCode = 2, detailMessage =
Only supported: +(line 1, pos 61)

== SQL ==
SELECT DATE(DATE_ADD(CAST(requirement_created_date AS DATE), (INTERVAL (DAYOFWEEK(requirement_created_date) - 1) DAY) * -1)) AS requirement_created_date, COUNT(DISTINCT tapd_id) AS `count` FROM test.test_tapd_data AS test_tapd_data GROUP BY DATE(DATE_ADD(CAST(requirement_created_date AS DATE), (INTERVAL (DAYOFWEEK(requirement_created_date) - 1) DAY) * -1)) LIMIT 10000;
-------------------------------------------------------------^^^
Doris > set retry_origin_sql_on_convert_fail = true;
Query OK, 0 rows affected (0.02 sec)

Doris > SELECT   DATE(     DATE_SUB(       requirement_created_date,       INTERVAL DAYOFWEEK (requirement_created_date) - 1 DAY     )   ) AS requirement_created_date,   COUNT(distinct tapd_id) AS count FROM   test.test_tapd_data GROUP BY   DATE(     DATE_SUB(       requirement_created_date,       INTERVAL DAYOFWEEK (requirement_created_date) - 1 DAY     )   ) LIMIT   10000;
Empty set (0.07 sec)
```
@zy-kkk zy-kkk requested a review from morrySnow as a code owner October 30, 2025 06:50
@zy-kkk
Copy link
Member Author

zy-kkk commented Oct 30, 2025

run buildall

@zy-kkk
Copy link
Member Author

zy-kkk commented Oct 31, 2025

run buildall

@morningman morningman merged commit e1007ef into apache:branch-3.1 Oct 31, 2025
22 checks passed
@morrySnow morrySnow mentioned this pull request Nov 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zy-kkk @morrySnow @morningman