Skip to content

Conversation

@zy-kkk
Copy link
Member

@zy-kkk zy-kkk commented Oct 30, 2025

When using Iceberg REST catalog with vended credentials enabled:

  • Polaris returns s3.region, s3.access-key-id, etc.
  • Gravitino returns client.region, s3.access-key-id, etc. (following Iceberg official naming)

Current implementation only filters properties with s3., oss., etc. prefixes, causing client.region to be filtered out, which leads to No storage properties found for schema: s3 error.

@Thearas
Copy link
Contributor

Thearas commented Oct 30, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zy-kkk
Copy link
Member Author

zy-kkk commented Oct 30, 2025

run buildall

@doris-robot
Copy link

ClickBench: Total hot run time: 27.9 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7b1b3302d51e92f88d9518056fca809091f2170e, data reload: false

query1	0.06	0.05	0.06
query2	0.09	0.05	0.05
query3	0.26	0.08	0.08
query4	1.60	0.13	0.12
query5	0.29	0.27	0.25
query6	1.19	0.68	0.64
query7	0.04	0.03	0.03
query8	0.06	0.05	0.04
query9	0.63	0.55	0.53
query10	0.59	0.58	0.58
query11	0.17	0.12	0.12
query12	0.15	0.12	0.14
query13	0.62	0.61	0.60
query14	1.01	1.03	1.00
query15	0.87	0.86	0.86
query16	0.40	0.41	0.42
query17	1.05	1.08	1.04
query18	0.23	0.20	0.21
query19	1.91	1.79	1.84
query20	0.02	0.01	0.02
query21	15.44	0.18	0.12
query22	5.10	0.08	0.05
query23	15.65	0.27	0.11
query24	2.97	0.60	0.49
query25	0.09	0.07	0.06
query26	0.14	0.13	0.13
query27	0.07	0.06	0.06
query28	4.44	1.17	0.96
query29	12.55	4.03	3.32
query30	0.29	0.14	0.12
query31	2.83	0.59	0.38
query32	3.23	0.55	0.47
query33	3.07	3.07	3.14
query34	15.94	5.13	4.58
query35	4.62	4.58	4.61
query36	0.68	0.51	0.50
query37	0.10	0.07	0.07
query38	0.07	0.05	0.04
query39	0.04	0.03	0.03
query40	0.18	0.14	0.15
query41	0.09	0.04	0.03
query42	0.04	0.04	0.03
query43	0.05	0.04	0.04
Total cold run time: 98.92 s
Total hot run time: 27.9 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 100% (0/0) 🎉
Increment coverage report
Complete coverage report

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 30, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 100% (0/0) 🎉
Increment coverage report
Complete coverage report

@zy-kkk zy-kkk merged commit d3c2408 into apache:master Oct 31, 2025
30 of 31 checks passed
@zy-kkk zy-kkk deleted the fix_gravitino_vended branch October 31, 2025 02:01
github-actions bot pushed a commit that referenced this pull request Oct 31, 2025
…vended credentials (#57521)

When using Iceberg REST catalog with vended credentials enabled:
  - **Polaris** returns `s3.region`, `s3.access-key-id`, etc.
- **Gravitino** returns `client.region`, `s3.access-key-id`, etc.
(following Iceberg official naming)

Current implementation only filters properties with `s3.`, `oss.`, etc.
prefixes, causing `client.region` to be filtered out, which leads to `No
storage
  properties found for schema: s3` error.
github-actions bot pushed a commit that referenced this pull request Oct 31, 2025
…vended credentials (#57521)

When using Iceberg REST catalog with vended credentials enabled:
  - **Polaris** returns `s3.region`, `s3.access-key-id`, etc.
- **Gravitino** returns `client.region`, `s3.access-key-id`, etc.
(following Iceberg official naming)

Current implementation only filters properties with `s3.`, `oss.`, etc.
prefixes, causing `client.region` to be filtered out, which leads to `No
storage
  properties found for schema: s3` error.
dwdwqfwe pushed a commit to dwdwqfwe/doris that referenced this pull request Oct 31, 2025
…vended credentials (apache#57521)

When using Iceberg REST catalog with vended credentials enabled:
  - **Polaris** returns `s3.region`, `s3.access-key-id`, etc.
- **Gravitino** returns `client.region`, `s3.access-key-id`, etc.
(following Iceberg official naming)

Current implementation only filters properties with `s3.`, `oss.`, etc.
prefixes, causing `client.region` to be filtered out, which leads to `No
storage
  properties found for schema: s3` error.
morningman pushed a commit that referenced this pull request Nov 4, 2025
yiguolei pushed a commit that referenced this pull request Nov 5, 2025
…vended credentials (#57521)

When using Iceberg REST catalog with vended credentials enabled:
  - **Polaris** returns `s3.region`, `s3.access-key-id`, etc.
- **Gravitino** returns `client.region`, `s3.access-key-id`, etc.
(following Iceberg official naming)

Current implementation only filters properties with `s3.`, `oss.`, etc.
prefixes, causing `client.region` to be filtered out, which leads to `No
storage
  properties found for schema: s3` error.
yiguolei pushed a commit that referenced this pull request Nov 10, 2025
…roperties invended credentials #57521 (#57540)

Cherry-picked from #57521

Co-authored-by: zy-kkk <zhongyk10@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.3-merged dev/4.0.2-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants