Skip to content

Conversation

@xinghuayu007
Copy link
Contributor

Proposed changes

For #5726 . Last commit is not logic perfect, which will cause some unit tests not passed.

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If these changes need document changes, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added the kind/fix Categorizes issue or PR as related to a bug. label May 7, 2021
@morningman morningman merged commit 86d2ddc into apache:master May 8, 2021
EmmyMiao87 pushed a commit to EmmyMiao87/incubator-doris that referenced this pull request May 14, 2021
For apache#5726 . Last commit is not logic perfect, which will cause some unit tests not passed.
yiguolei pushed a commit to yiguolei/incubator-doris that referenced this pull request Dec 30, 2025
…st target data type is same to cast source data type apache#56804 (apache#5766)

## Proposed changes

It would fail when create partition mv when contain cast and the cast
target data type is same to cast source data type
such as materialized view def sql is as following
l_shipdate data type is `date`

```sql

        CREATE MATERIALIZED VIEW mv_10086
        BUILD IMMEDIATE REFRESH AUTO ON MANUAL
        partition by(l_shipdate_d)
        DISTRIBUTED BY RANDOM BUCKETS 2
        PROPERTIES ('replication_num' = '1')
        AS
        select cast(l_shipdate as DATE) as l_shipdate_d, l_partkey, l_suppkey
        from lineitem;
```

the pr fix this

Issue Number: close #xxx

<!--Describe your changes.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/fix Categorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants