branch-3.1: [fix](catalog) Prevent removing catalog from refresh queue on CREATE/ALTER #57671
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Summary:
catalogs are incorrectly removed from the auto-refresh queue when:
metadata_refresh_interval_secALTER CATALOG SET PROPERTIESThis causes auto-refresh to stop working even though
metadata_refresh_interval_secis configured.Root Cause:
CREATE/ALTER CATALOG
→ resetToUninitialized()
→ onClose()
→ CatalogIf.super.onClose()
→ removeFromRefreshMap(catalogId) ❌ Wrong!
Fix:
CatalogIf.super.onClose()call fromExternalCatalog.onClose()removeFromRefreshMap()inCatalogMgr.removeCatalog()Related: #57680