Skip to content

branch-3.1: [fix](catalog) Clean up refresh thread when deleting catalog #57680 #57733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
github-actions wants to merge 1 commit into from
Closed

branch-3.1: [fix](catalog) Clean up refresh thread when deleting catalog #57680 #57733

github-actions wants to merge 1 commit into from

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 5, 2025

Cherry-picked from #57680

@zy-kkk
[fix](catalog) Clean up refresh thread when deleting catalog (#57680)
a4630ad 
since #49621
Since ExternalCatalog no longer calls methods in the interface when
onClose, we need to manually clean up the values ​​in refreshmanager
when deleting the catalog.
@github-actions github-actions bot requested a review from morrySnow as a code owner November 5, 2025 09:43
@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 5, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Nov 5, 2025
@dataroaring dataroaring reopened this Nov 5, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 5, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 5, 2025

FE UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

@morningman morningman closed this Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow Awaiting requested review from morrySnow morrySnow is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hello-stephen @morningman @dataroaring @zy-kkk