Skip to content

branch-3.1: [fix](catalog) max_meta_object_cache_num config must > 0 #57742 #57793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 1 commit into from
Nov 7, 2025
Merged

branch-3.1: [fix](catalog) max_meta_object_cache_num config must > 0 #57742 #57793

morningman merged 1 commit into from
Nov 7, 2025
+3 −4

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 7, 2025

Cherry-picked from #57742

@morningman
[fix](catalog) max_meta_object_cache_num config must > 0 (#57742)
33dd6cd 
### What problem does this PR solve?

1.
Issue Number: close #55426

When `max_meta_object_cache_num = 0`, the desc command fails because it
tries to access disabled meta cache.
```
ERROR 1105 (HY000): errCode = 2, detailMessage = Unknown table '7311664922056505694'
```

So force set `max_meta_object_cache_num` > 0

2.
Remove the removalListener of ExternalDatabase's meta cache, it may
cause thread pool exausted:

```
"CommonRefreshExecutor-55" #19386 daemon prio=5 os_prio=0 tid=0x00007ef928005000 nid=0x61aa waiting on condition [0x00007ef8aaf5a000]
   java.lang.Thread.State: TIMED_WAITING (parking)
    at sun.misc.Unsafe.park(Native Method)
    - parking to wait for  <0x00007f03c435af50> (a java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
    at java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:215)
    at java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2078)
    at java.util.concurrent.LinkedBlockingQueue.offer(LinkedBlockingQueue.java:385)
    at org.apache.doris.common.ThreadPoolManager$BlockedPolicy.rejectedExecution(ThreadPoolManager.java:347)
    at java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.java:830)
    at java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.java:1379)
    at com.github.benmanes.caffeine.cache.BoundedLocalCache.notifyRemoval(BoundedLocalCache.java:333)
    at com.github.benmanes.caffeine.cache.BoundedLocalCache.removeNode(BoundedLocalCache.java:1882)
    at com.github.benmanes.caffeine.cache.BoundedLocalCache.clear(BoundedLocalCache.java:1819)
    at com.github.benmanes.caffeine.cache.LocalManualCache.invalidateAll(LocalManualCache.java:150)
    at org.apache.doris.datasource.metacache.MetaCache.invalidateAll(MetaCache.java:121)
    at org.apache.doris.datasource.ExternalDatabase.setUnInitialized(ExternalDatabase.java:123)
    at org.apache.doris.datasource.ExternalCatalog.lambda$null$2(ExternalCatalog.java:248)
    at org.apache.doris.datasource.ExternalCatalog$$Lambda$3280/1787323570.accept(Unknown Source)
    at java.util.Optional.ifPresent(Optional.java:159)
    at org.apache.doris.datasource.ExternalCatalog.lambda$makeSureInitialized$3(ExternalCatalog.java:248)
    at org.apache.doris.datasource.ExternalCatalog$$Lambda$2317/2029647164.onRemoval(Unknown Source)
    at com.github.benmanes.caffeine.cache.BoundedLocalCache.lambda$notifyRemoval$1(BoundedLocalCache.java:327)
    at com.github.benmanes.caffeine.cache.BoundedLocalCache$$Lambda$3279/2010922194.run(Unknown Source)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
    at java.lang.Thread.run(Thread.java:750)
```
@github-actions github-actions bot requested a review from morrySnow as a code owner November 7, 2025 03:27
@morningman
Copy link
Contributor

morningman commented Nov 7, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 7, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Nov 7, 2025
@dataroaring dataroaring reopened this Nov 7, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 7, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 7, 2025

FE UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉
Increment coverage report
Complete coverage report

@morningman morningman merged commit e88af0e into branch-3.1 Nov 7, 2025
23 checks passed
@github-actions github-actions bot deleted the auto-pick-57742-branch-3.1 branch November 7, 2025 06:38
@morrySnow morrySnow mentioned this pull request Nov 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@morningman @hello-stephen @morrySnow @dataroaring