Skip to content

Conversation

@suxiaogang223
Copy link
Contributor

What problem does this PR solve?

bp: #45367

Problem Summary:
In pr#45367, we chose not to pass the Iceberg partition metadata to the beta, but this caused the Iceberg table, which doesn't store partition columns in the file, to be unreadable. Therefore, this pr reverted some code and modified the FileScanner logic.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@suxiaogang223
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 42.10% (11245/26712)
Line Coverage 32.64% (96302/295087)
Region Coverage 30.56% (55291/180900)
Branch Coverage 26.89% (27367/101788)

@suxiaogang223
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 0.00% (0/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 42.09% (11244/26712)
Line Coverage 32.62% (96252/295087)
Region Coverage 30.55% (55272/180900)
Branch Coverage 26.88% (27359/101788)

@suxiaogang223
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 0.00% (0/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 42.09% (11243/26712)
Line Coverage 32.61% (96234/295087)
Region Coverage 30.55% (55263/180900)
Branch Coverage 26.87% (27355/101788)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 75.03% (19697/26253)
Line Coverage 68.31% (201047/294308)
Region Coverage 66.47% (120420/181170)
Branch Coverage 59.78% (61087/102184)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants