Skip to content

Add buffer to s3 reader and fix bug in BufferedReader#5791

Merged
yangzhg merged 1 commit intoapache:masterfrom
yangzhg:add_buffer_to_s3
May 17, 2021
Merged

Add buffer to s3 reader and fix bug in BufferedReader#5791
yangzhg merged 1 commit intoapache:masterfrom
yangzhg:add_buffer_to_s3

Conversation

@yangzhg
Copy link
Member

@yangzhg yangzhg commented May 11, 2021

Proposed changes

  1. add buffer when use s3 reader
  2. fix bug ([BUG] BufferedReader return wrong data when read size is larger than buffer  #5789 ) in BufferedReader
  3. change the read method in FileReader, separate buf_len and read bytes

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morningman morningman added the kind/fix Categorizes issue or PR as related to a bug. label May 12, 2021
@yangzhg yangzhg force-pushed the add_buffer_to_s3 branch from 2f0b960 to 9fb7a14 Compare May 12, 2021 03:18
Copy link
Member

@xy720 xy720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added the approved Indicates a PR has been approved by one committer. label May 13, 2021
@yangzhg yangzhg merged commit 01a45e8 into apache:master May 17, 2021
@yangzhg yangzhg deleted the add_buffer_to_s3 branch June 7, 2021 03:05
stdpain pushed a commit to stdpain/incubator-doris that referenced this pull request Jul 8, 2021
Change-Id: If4994d94784da5079cada3bb3f15b676080b0d6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. kind/fix Categorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] BufferedReader return wrong data when read size is larger than buffer

3 participants