Skip to content

Conversation

@gavinchou
Copy link
Contributor

@gavinchou gavinchou commented Nov 15, 2025

cold hot separation will call cached remote reader

@Thearas
Copy link
Contributor

Thearas commented Nov 15, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@gavinchou
Copy link
Contributor Author

run buildall

Copy link
Contributor

@deardeng deardeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 33729 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8ef1c65d451513b44a0e5d76dc51020a0f265a44, data reload: false

------ Round 1 ----------------------------------
q1	17590	5117	5012	5012
q2	2071	319	203	203
q3	10254	1311	699	699
q4	10238	946	385	385
q5	7559	2370	2274	2274
q6	179	170	138	138
q7	917	741	603	603
q8	9331	1363	1020	1020
q9	6911	5120	5057	5057
q10	6831	2237	1808	1808
q11	500	293	276	276
q12	326	366	226	226
q13	17797	3625	2984	2984
q14	228	228	211	211
q15	574	503	502	502
q16	1031	1006	932	932
q17	579	852	375	375
q18	7570	7198	7050	7050
q19	1101	942	526	526
q20	347	351	226	226
q21	3713	2505	2230	2230
q22	1055	1045	992	992
Total cold run time: 106702 ms
Total hot run time: 33729 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5091	5107	5069	5069
q2	245	329	232	232
q3	2148	2638	2302	2302
q4	1341	1800	1307	1307
q5	4180	4130	4473	4130
q6	232	182	136	136
q7	2013	1981	1864	1864
q8	2742	2456	2525	2456
q9	7299	7260	7358	7260
q10	2999	3300	2858	2858
q11	576	505	510	505
q12	680	759	640	640
q13	3510	3936	3235	3235
q14	296	324	282	282
q15	544	488	533	488
q16	1117	1095	1060	1060
q17	1184	1656	1388	1388
q18	7757	7706	7414	7414
q19	750	775	971	775
q20	1889	1956	1811	1811
q21	4670	4295	4282	4282
q22	1146	1051	993	993
Total cold run time: 52409 ms
Total hot run time: 50487 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 187642 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8ef1c65d451513b44a0e5d76dc51020a0f265a44, data reload: false

query1	1019	393	400	393
query2	6561	1703	1702	1702
query3	6749	239	234	234
query4	26429	23894	22932	22932
query5	4866	649	511	511
query6	354	262	235	235
query7	4647	499	304	304
query8	307	263	248	248
query9	8710	2921	2918	2918
query10	508	352	310	310
query11	16232	15088	14770	14770
query12	184	129	123	123
query13	1687	566	450	450
query14	11146	9332	9105	9105
query15	193	192	173	173
query16	7637	651	444	444
query17	1164	748	608	608
query18	2022	423	326	326
query19	212	195	184	184
query20	135	123	121	121
query21	218	130	117	117
query22	4160	4185	4142	4142
query23	33954	33221	32971	32971
query24	8185	2391	2373	2373
query25	596	541	447	447
query26	1229	269	158	158
query27	2765	498	355	355
query28	4376	2227	2209	2209
query29	787	649	496	496
query30	297	225	196	196
query31	923	791	710	710
query32	86	80	82	80
query33	583	404	342	342
query34	785	852	508	508
query35	797	862	745	745
query36	957	1002	898	898
query37	136	117	94	94
query38	3535	3528	3440	3440
query39	1461	1415	1401	1401
query40	224	135	128	128
query41	63	60	63	60
query42	129	118	114	114
query43	485	481	450	450
query44	1227	774	762	762
query45	186	181	168	168
query46	882	982	674	674
query47	1771	1817	1760	1760
query48	399	446	324	324
query49	767	490	404	404
query50	648	691	403	403
query51	3895	3879	3926	3879
query52	117	113	117	113
query53	250	275	193	193
query54	327	311	292	292
query55	92	94	89	89
query56	348	331	334	331
query57	1170	1187	1112	1112
query58	301	281	276	276
query59	2516	2663	2510	2510
query60	364	367	343	343
query61	159	158	162	158
query62	803	732	681	681
query63	228	194	199	194
query64	4458	1156	868	868
query65	4023	3931	3922	3922
query66	1121	443	349	349
query67	15077	14963	14930	14930
query68	5960	926	600	600
query69	496	338	296	296
query70	1308	1326	1215	1215
query71	438	349	325	325
query72	6057	5044	5007	5007
query73	641	574	367	367
query74	9230	9052	8645	8645
query75	3280	3229	2739	2739
query76	3297	1118	767	767
query77	531	409	339	339
query78	9565	9736	8922	8922
query79	2547	836	608	608
query80	786	600	525	525
query81	498	268	242	242
query82	442	165	139	139
query83	263	262	262	262
query84	264	115	94	94
query85	910	471	440	440
query86	439	335	320	320
query87	3691	3680	3588	3588
query88	3372	2225	2244	2225
query89	394	335	289	289
query90	1980	238	232	232
query91	163	161	139	139
query92	97	75	74	74
query93	2767	977	646	646
query94	766	433	345	345
query95	413	340	338	338
query96	480	579	284	284
query97	2912	2973	2861	2861
query98	248	232	215	215
query99	1304	1392	1294	1294
Total cold run time: 274161 ms
Total hot run time: 187642 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.25 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8ef1c65d451513b44a0e5d76dc51020a0f265a44, data reload: false

query1	0.05	0.05	0.05
query2	0.10	0.06	0.05
query3	0.25	0.08	0.08
query4	1.61	0.11	0.11
query5	0.27	0.24	0.25
query6	1.20	0.64	0.63
query7	0.04	0.03	0.03
query8	0.06	0.05	0.05
query9	0.58	0.52	0.52
query10	0.59	0.57	0.56
query11	0.16	0.12	0.11
query12	0.15	0.12	0.12
query13	0.62	0.61	0.59
query14	0.99	0.98	0.98
query15	0.84	0.83	0.85
query16	0.38	0.40	0.39
query17	1.03	1.01	1.04
query18	0.22	0.20	0.20
query19	1.95	1.76	1.84
query20	0.01	0.01	0.02
query21	15.44	0.20	0.13
query22	5.04	0.07	0.05
query23	15.68	0.26	0.10
query24	2.57	0.76	0.30
query25	0.07	0.06	0.07
query26	0.13	0.14	0.14
query27	0.06	0.05	0.06
query28	3.78	1.15	0.93
query29	12.53	3.87	3.24
query30	0.29	0.13	0.12
query31	2.81	0.58	0.38
query32	3.23	0.55	0.46
query33	2.98	3.03	3.11
query34	15.83	5.15	4.50
query35	4.56	4.62	4.60
query36	0.66	0.50	0.48
query37	0.09	0.07	0.07
query38	0.06	0.04	0.04
query39	0.04	0.02	0.02
query40	0.17	0.14	0.14
query41	0.09	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.03	0.03
Total cold run time: 97.29 s
Total hot run time: 27.25 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.75% (18282/34657)
Line Coverage 38.14% (166222/435868)
Region Coverage 33.08% (129146/390445)
Branch Coverage 33.85% (55446/163795)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.54% (24363/34057)
Line Coverage 58.02% (253291/436542)
Region Coverage 53.39% (211395/395956)
Branch Coverage 54.66% (90112/164870)

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit bd374aa into apache:master Nov 17, 2025
29 of 31 checks passed
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 17, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.2-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants