Skip to content

[Feature] Support show view statement for table#5813

Merged
morningman merged 5 commits intoapache:masterfrom
xy720:show-view-stmt
May 19, 2021
Merged

[Feature] Support show view statement for table#5813
morningman merged 5 commits intoapache:masterfrom
xy720:show-view-stmt

Conversation

@xy720
Copy link
Member

@xy720 xy720 commented May 13, 2021

Proposed changes

issue #5812

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have created an issue on (Fix [Feature] Support show view from table #5812 ) and described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If these changes need document changes, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

ErrorReport.reportAnalysisException(ErrorCode.ERR_NOT_OLAP_TABLE, getTbl());
}

if (!Catalog.getCurrentCatalog().getAuth().checkTblPriv(ConnectContext.get(), dbName, getTbl(), PrivPredicate.SHOW)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check priv before check db/tbl's existence

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. I have fixed it.

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by one committer. kind/feature Categorizes issue or PR as related to a new feature. labels May 18, 2021
@morningman morningman merged commit bf44435 into apache:master May 19, 2021
stdpain pushed a commit to stdpain/incubator-doris that referenced this pull request Jul 8, 2021
Help to find all views which contain the given table
@morningman morningman mentioned this pull request Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by one committer. kind/feature Categorizes issue or PR as related to a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Support show view from table

2 participants