Skip to content

[fix](cloud) Fix the issue where it takes a long time to come alive on first boot #58152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gavinchou merged 2 commits into from
Nov 20, 2025
Merged

[fix](cloud) Fix the issue where it takes a long time to come alive on first boot #58152

gavinchou merged 2 commits into from
Nov 20, 2025

Conversation

@deardeng
Copy link
Contributor

@deardeng deardeng commented Nov 19, 2025 •
edited by gavinchou
Loading

fix heartbeat abort txn too slow，This caused the first startup to take a very long time to come alive.

@Thearas
Copy link
Contributor

Thearas commented Nov 19, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@deardeng
Copy link
Contributor Author

deardeng commented Nov 19, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 19, 2025

Cloud UT Coverage Report

Increment line coverage 50.00% (3/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 80.77% (1705/2111)
Line Coverage 66.81% (29830/44650)
Region Coverage 67.37% (14886/22097)
Branch Coverage 57.59% (7921/13754)

gavinchou
gavinchou reviewed Nov 19, 2025
View reviewed changes
yujun777
yujun777 reviewed Nov 19, 2025
View reviewed changes
@deardeng
Copy link
Contributor Author

deardeng commented Nov 20, 2025

run buildall

yujun777
yujun777 approved these changes Nov 20, 2025
View reviewed changes
Copy link
Contributor

@yujun777 yujun777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2025

PR approved by anyone and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 20, 2025
@doris-robot
Copy link

doris-robot commented Nov 20, 2025

TPC-H: Total hot run time: 35887 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c6cbb88710bd0e2da9ebc473cd8d05c412ec42f1, data reload: false

------ Round 1 ----------------------------------
q1	17624	5012	4877	4877
q2	1995	303	208	208
q3	10271	1290	702	702
q4	10242	936	375	375
q5	7470	2428	2323	2323
q6	188	170	145	145
q7	952	773	622	622
q8	9359	1335	1145	1145
q9	7246	5319	5428	5319
q10	6926	2181	1851	1851
q11	508	304	288	288
q12	379	371	240	240
q13	17781	3671	3043	3043
q14	252	233	215	215
q15	578	511	511	511
q16	1009	985	941	941
q17	589	892	372	372
q18	7803	7746	8149	7746
q19	1107	997	573	573
q20	403	350	238	238
q21	4038	3354	3132	3132
q22	1156	1125	1021	1021
Total cold run time: 107876 ms
Total hot run time: 35887 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5189	5095	5137	5095
q2	307	409	308	308
q3	2446	2864	2543	2543
q4	1466	1910	1508	1508
q5	4525	4558	4463	4463
q6	205	171	138	138
q7	2018	1905	1825	1825
q8	2648	2560	2550	2550
q9	7650	7564	7666	7564
q10	3011	3140	2644	2644
q11	565	496	483	483
q12	622	730	599	599
q13	3268	3613	3049	3049
q14	270	275	256	256
q15	521	488	488	488
q16	1005	1043	999	999
q17	1086	1471	1323	1323
q18	7298	7025	6958	6958
q19	751	757	738	738
q20	1922	1962	1823	1823
q21	4780	4476	4192	4192
q22	1094	1041	1010	1010
Total cold run time: 52647 ms
Total hot run time: 50556 ms

@doris-robot
Copy link

doris-robot commented Nov 20, 2025

TPC-DS: Total hot run time: 188429 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c6cbb88710bd0e2da9ebc473cd8d05c412ec42f1, data reload: false

query1	1030	402	396	396
query2	6551	1685	1699	1685
query3	6766	249	224	224
query4	25874	23423	22734	22734
query5	4459	678	526	526
query6	371	256	241	241
query7	4672	492	307	307
query8	311	262	263	262
query9	8717	2962	2957	2957
query10	519	361	315	315
query11	15765	15143	14921	14921
query12	183	128	119	119
query13	1716	578	458	458
query14	11059	9096	9028	9028
query15	201	184	175	175
query16	7524	673	492	492
query17	1218	762	614	614
query18	2027	420	327	327
query19	204	195	188	188
query20	136	129	121	121
query21	215	132	110	110
query22	3992	3996	3952	3952
query23	33856	33105	33172	33105
query24	8200	2384	2366	2366
query25	610	524	457	457
query26	1247	274	165	165
query27	2766	506	362	362
query28	4396	2271	2245	2245
query29	807	635	497	497
query30	290	229	185	185
query31	924	783	720	720
query32	89	84	80	80
query33	594	389	364	364
query34	783	842	524	524
query35	811	829	775	775
query36	953	998	906	906
query37	127	116	102	102
query38	3580	3528	3488	3488
query39	1511	1427	1419	1419
query40	234	139	126	126
query41	65	59	61	59
query42	134	118	113	113
query43	489	491	465	465
query44	1258	803	801	801
query45	191	192	173	173
query46	882	998	643	643
query47	1736	1774	1724	1724
query48	395	425	332	332
query49	749	495	418	418
query50	654	672	409	409
query51	3860	3885	3855	3855
query52	120	117	111	111
query53	252	266	204	204
query54	340	314	300	300
query55	98	100	92	92
query56	355	371	341	341
query57	1166	1176	1116	1116
query58	301	288	291	288
query59	2535	2580	2514	2514
query60	369	379	351	351
query61	161	163	165	163
query62	797	711	664	664
query63	233	201	195	195
query64	4477	1173	874	874
query65	4050	3971	3959	3959
query66	1148	442	356	356
query67	15121	14906	14888	14888
query68	4794	966	665	665
query69	504	340	313	313
query70	1274	1340	1255	1255
query71	422	352	336	336
query72	5934	5195	5152	5152
query73	672	583	377	377
query74	8915	9113	8953	8953
query75	3291	3251	2809	2809
query76	3281	1135	784	784
query77	530	418	345	345
query78	9629	9795	8846	8846
query79	2072	845	615	615
query80	1766	596	535	535
query81	555	258	235	235
query82	418	168	144	144
query83	368	258	253	253
query84	252	115	101	101
query85	890	483	451	451
query86	388	320	298	298
query87	3695	3805	3569	3569
query88	2851	2267	2224	2224
query89	381	326	289	289
query90	1759	235	234	234
query91	176	169	138	138
query92	82	83	76	76
query93	1189	1036	692	692
query94	738	436	338	338
query95	435	344	352	344
query96	488	590	277	277
query97	2896	2969	2842	2842
query98	246	220	214	214
query99	1289	1401	1279	1279
Total cold run time: 269404 ms
Total hot run time: 188429 ms

@doris-robot
Copy link

doris-robot commented Nov 20, 2025

ClickBench: Total hot run time: 27.46 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c6cbb88710bd0e2da9ebc473cd8d05c412ec42f1, data reload: false

query1	0.05	0.05	0.05
query2	0.09	0.06	0.05
query3	0.25	0.08	0.08
query4	1.61	0.11	0.10
query5	0.26	0.24	0.25
query6	1.19	0.65	0.65
query7	0.04	0.03	0.03
query8	0.05	0.04	0.04
query9	0.58	0.54	0.52
query10	0.57	0.58	0.58
query11	0.17	0.12	0.11
query12	0.15	0.13	0.12
query13	0.63	0.60	0.60
query14	0.99	1.00	1.00
query15	0.86	0.84	0.83
query16	0.40	0.39	0.40
query17	1.05	1.01	1.02
query18	0.21	0.19	0.20
query19	1.88	1.75	1.85
query20	0.02	0.01	0.01
query21	15.42	0.21	0.13
query22	5.04	0.07	0.05
query23	15.68	0.26	0.10
query24	3.05	0.67	0.42
query25	0.10	0.05	0.06
query26	0.14	0.14	0.14
query27	0.06	0.05	0.05
query28	4.18	1.19	0.94
query29	12.63	3.87	3.23
query30	0.29	0.14	0.12
query31	2.82	0.61	0.38
query32	3.23	0.55	0.48
query33	3.06	3.03	3.01
query34	15.82	5.15	4.60
query35	4.56	4.55	4.56
query36	0.69	0.51	0.49
query37	0.09	0.07	0.07
query38	0.06	0.04	0.03
query39	0.04	0.04	0.04
query40	0.17	0.14	0.14
query41	0.08	0.03	0.03
query42	0.05	0.03	0.03
query43	0.04	0.03	0.04
Total cold run time: 98.35 s
Total hot run time: 27.46 s

@gavinchou gavinchou changed the title [fix](cloud) Fix the issue where it takes a long time to come alive o… [fix](cloud) Fix the issue where it takes a long time to come alive on first boot Nov 20, 2025
@gavinchou gavinchou merged commit b621455 into apache:master Nov 20, 2025
31 of 32 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 20, 2025
@deardeng
[fix](cloud) Fix the issue where it takes a long time to come alive o…
2bb05d5 
…n first boot (#58152)

fix heartbeat abort txn too slow，This caused the first startup to take a
very long time to come alive.
@github-actions github-actions bot mentioned this pull request Nov 20, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Nov 20, 2025
@deardeng
[fix](cloud) Fix the issue where it takes a long time to come alive o…
25845a1 
…n first boot (#58152)

fix heartbeat abort txn too slow，This caused the first startup to take a
very long time to come alive.
@github-actions github-actions bot mentioned this pull request Nov 20, 2025
Merged
@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 20, 2025

FE Regression Coverage Report

Increment line coverage 57.14% (16/28) 🎉
Increment coverage report
Complete coverage report

yiguolei pushed a commit that referenced this pull request Nov 21, 2025
@github-actions @deardeng
branch-4.0: [fix](cloud) Fix the issue where it takes a long time to …
9abb789 
…come alive on first boot #58152 (#58194)

Cherry-picked from #58152

Co-authored-by: deardeng <dengxin@selectdb.com>
morrySnow pushed a commit that referenced this pull request Nov 25, 2025
@github-actions @deardeng
branch-3.1: [fix](cloud) Fix the issue where it takes a long time to …
7e290c7 
…come alive on first boot #58152 (#58195)

Cherry-picked from #58152

Co-authored-by: deardeng <dengxin@selectdb.com>
@yiguolei yiguolei mentioned this pull request Dec 2, 2025
Open
nagisa-kunhah pushed a commit to nagisa-kunhah/doris that referenced this pull request Dec 14, 2025
@deardeng @nagisa-kunhah
[fix](cloud) Fix the issue where it takes a long time to come alive o…
0739f0e 
…n first boot (apache#58152)

fix heartbeat abort txn too slow，This caused the first startup to take a
very long time to come alive.
w41ter pushed a commit to w41ter/incubator-doris that referenced this pull request Dec 26, 2025
@deardeng
[fix](cloud) Fix the issue where it takes a long time to come alive o…
ac5d8fa 
…n first boot (apache#58152) (apache#5857)

pick from apache#58152

fix heartbeat abort txn too slow，This caused the first startup to take a
very long time to come alive.
yiguolei pushed a commit to yiguolei/incubator-doris that referenced this pull request Dec 30, 2025
@deardeng
[fix](cloud) Fix the issue where it takes a long time to come alive o…
23ea7f0 
…n first boot (apache#58152) (apache#5858)

…n first boot (apache#58152)

pick from apache#58152

fix heartbeat abort txn too slow，This caused the first startup to take a
very long time to come alive.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@dataroaring dataroaring Awaiting requested review from dataroaring dataroaring is a code owner

@w41ter w41ter Awaiting requested review from w41ter w41ter is a code owner

+1 more reviewer

@yujun777 yujun777 yujun777 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.4-merged dev/4.0.2-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@deardeng @Thearas @hello-stephen @doris-robot @gavinchou @yujun777 @yiguolei @morrySnow