[BE] Optimize version retrieval efficiency.#5831
Merged
yangzhg merged 2 commits intoapache:masterfrom Jun 2, 2021
Merged
Conversation
…ompaction scenarios.
killxdcj
changed the title
morningman
added
area/compact
Contributor
|
Thanks for your contribution. I will take time to review the PR.. maybe later... |
morningman
reviewed
May 28, 2021
| int64_t next_idx = -1; | ||
| for (const auto& it : _version_graph[cur_idx].edges) { | ||
| // Only consider incremental versions | ||
| if (_version_graph[it].value < _version_graph[cur_idx].value) { |
Contributor
There was a problem hiding this comment.
If we already sort edges in descending order, can we "break" here?
stdpain
pushed a commit
to stdpain/incubator-doris
that referenced
this pull request
Jul 8, 2021
* [FE] Optimize version retrieval efficiency in high-frequency import/compaction scenarios. * Jump out of the loop when encountering the reverse edge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize version retrieval efficiency in high-frequency import/compaction scenarios.
Proposed changes
More detail: #5830
Types of changes
Checklist