Skip to content

[Build] Enable brpc cpu and heap profile#5835

Merged
morningman merged 2 commits intoapache:masterfrom
morningman:brpc_profile
May 19, 2021
Merged

[Build] Enable brpc cpu and heap profile#5835
morningman merged 2 commits intoapache:masterfrom
morningman:brpc_profile

Conversation

@morningman
Copy link
Contributor

Proposed changes

Enable brpc profile with macro BRPC_ENABLE_CPU_PROFILER,
so that we can get cpu and heap profile at runtime via brpc web interface.

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If these changes need document changes, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Enable brpc profile with macro BRPC_ENABLE_CPU_PROFILER,
so that we can get cpu and heap profile at runtime via brpc web interface.
@morningman morningman added the kind/chore Issues or PRs related to compile and install label May 17, 2021
@stdpain
Copy link
Contributor

stdpain commented May 18, 2021

Is there any possibility that this macro definition added to CXX_COMMON_FLAGS could cause Link problems in ASAN or LSAN mode?

Copy link
Member

@yangzhg yangzhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yangzhg yangzhg added the approved Indicates a PR has been approved by one committer. label May 18, 2021
@morningman
Copy link
Contributor Author

Is there any possibility that this macro definition added to CXX_COMMON_FLAGS could cause Link problems in ASAN or LSAN mode?

It is ok for CPU profile, and for heap profile, it will report error like:
To enable all profilers, link tcmalloc and define macros BRPC_ENABLE_CPU_PROFILER
which is reasonable.

@morningman morningman merged commit ad28207 into apache:master May 19, 2021
stdpain pushed a commit to stdpain/incubator-doris that referenced this pull request Jul 8, 2021
Enable brpc profile with macro BRPC_ENABLE_CPU_PROFILER,
so that we can get cpu and heap profile at runtime via brpc web interface.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. kind/chore Issues or PRs related to compile and install

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants