[fix](jdbc) Fix JNI global reference leak in JdbcConnector close #58574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
zhangstar333
approved these changes
Dec 1, 2025
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 33974 ms |
TPC-DS: Total hot run time: 181893 ms |
ClickBench: Total hot run time: 27.4 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
github-actions bot
pushed a commit
that referenced
this pull request
Dec 5, 2025
…8574) ## Problem JNI Global References may not be deleted when `JdbcConnector::close()` fails midway due to early returns from `RETURN_IF_ERROR` macros. This prevents Java GC from collecting `BaseJdbcExecutor` and its associated `ResultSet` objects, causing old generation heap to grow to 99%+. ## Solution - C++: Always delete all three Global References regardless of Java close() failure - Java: Always clear member variable references (`resultSet`, `stmt`, `conn`) in finally block
github-actions bot
pushed a commit
that referenced
this pull request
Dec 5, 2025
…8574) ## Problem JNI Global References may not be deleted when `JdbcConnector::close()` fails midway due to early returns from `RETURN_IF_ERROR` macros. This prevents Java GC from collecting `BaseJdbcExecutor` and its associated `ResultSet` objects, causing old generation heap to grow to 99%+. ## Solution - C++: Always delete all three Global References regardless of Java close() failure - Java: Always clear member variable references (`resultSet`, `stmt`, `conn`) in finally block
yiguolei
added
dev/4.0.2-merged
dev/4.0.3-merged
and removed
dev/4.0.x
dev/4.0.2-merged
labels
nagisa-kunhah
pushed a commit
to nagisa-kunhah/doris
that referenced
this pull request
Dec 14, 2025
…ache#58574) ## Problem JNI Global References may not be deleted when `JdbcConnector::close()` fails midway due to early returns from `RETURN_IF_ERROR` macros. This prevents Java GC from collecting `BaseJdbcExecutor` and its associated `ResultSet` objects, causing old generation heap to grow to 99%+. ## Solution - C++: Always delete all three Global References regardless of Java close() failure - Java: Always clear member variable references (`resultSet`, `stmt`, `conn`) in finally block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
JNI Global References may not be deleted when
JdbcConnector::close()failsmidway due to early returns from
RETURN_IF_ERRORmacros. This prevents JavaGC from collecting
BaseJdbcExecutorand its associatedResultSetobjects,causing old generation heap to grow to 99%+.
Solution
resultSet,stmt,conn) in finally block