-
Notifications
You must be signed in to change notification settings - Fork 3.7k
branch-4.0: [bug](parquet) fix parquet type not handle float16 type #58528 #58630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
b727e30 to
2906657
Compare
Contributor
|
run buildall |
2 similar comments
Contributor
|
run buildall |
Contributor
|
run buildall |
### What problem does this PR solve?
Problem Summary:
before not deal with float16 type, so it's mapping to string type, and
the result is invaild eg:
```
mysql> select * from HDFS("uri" = "hdfs://127.0.0.1:8020/user/doris/tvf_data/test_hdfs_parquet/group0/float16_nonzeros_and_nans.parquet", "hadoop.username" = "doris", "format" = "parquet");
+------+
| x |
+------+
| NULL |
| < |
| � |
| ~ |
| |
| � |
| � |
| @ |
+------+
```
but it's could mapping to float type, eg:
```
mysql> select x from file( "fs.local.support" = "true", "file_path" = "float16_nonzeros_and_nans.parquet", "format" = "parquet",'shared_storage'='true' );
+------+
| x |
+------+
| NULL |
| 1 |
| -2 |
| NaN |
| 0 |
| -1 |
| -0 |
| 2 |
+------+
```
2906657 to
715178e
Compare
Contributor
|
run buildall |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
need this pr: #57959
before merge to other branch
Cherry-picked from #58528