-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[test](mtmv) Add ut test for session variable guard when generate mtmv cache #58863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test](mtmv) Add ut test for session variable guard when generate mtmv cache #58863
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-DS: Total hot run time: 183170 ms |
ClickBench: Total hot run time: 27.24 s |
FE UT Coverage ReportIncrement line coverage |
00f31ae to
cfd72a3
Compare
|
run buildall |
TPC-H: Total hot run time: 36279 ms |
TPC-DS: Total hot run time: 181826 ms |
ClickBench: Total hot run time: 27.27 s |
FE UT Coverage ReportIncrement line coverage |
FE Regression Coverage ReportIncrement line coverage |
1 similar comment
FE Regression Coverage ReportIncrement line coverage |
|
run buildall |
TPC-H: Total hot run time: 36253 ms |
TPC-DS: Total hot run time: 181869 ms |
ClickBench: Total hot run time: 27.77 s |
|
PR approved by anyone and no changes requested. |
5b7946f to
d83f23c
Compare
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
FE UT Coverage ReportIncrement line coverage `` 🎉 |
TPC-H: Total hot run time: 35560 ms |
TPC-DS: Total hot run time: 174605 ms |
ClickBench: Total hot run time: 27.24 s |
yujun777
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
…mv cache (apache#58863) mtmvCache is globally reused, and each query shares the same instance of mtmvCache. When generating the cache, it should not include any attributes that are specific to an individual query. current code has no problem, just add some ut Related PR: apache#58031
What problem does this PR solve?
mtmvCache is globally reused, and each query shares the same instance of mtmvCache. When generating the cache, it should not include any attributes that are specific to an individual query.
current code has no problem, just add some ut
Issue Number: close #xxx
Related PR: #58031
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)